Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 674404 - dev-util/idea-community-2018-3.2 version bump
Summary: dev-util/idea-community-2018-3.2 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Arisu Tachibana
URL:
Whiteboard:
Keywords: EBUILD, PullRequest
Depends on:
Blocks:
 
Reported: 2019-01-03 11:49 UTC by Adam Giergun
Modified: 2019-01-29 15:18 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
idea-community-2018.3.2.183.4886.37.ebuild (idea-community-2018.3.2.183.4886.37.ebuild,1.92 KB, text/plain)
2019-01-03 11:53 UTC, Adam Giergun
Details
potential 2018.3.3 ebuild (idea-community-2018.3.3.183.5153.38.ebuild,1.87 KB, text/plain)
2019-01-19 04:40 UTC, Kyle Elbert
Details
2nd revision potential 2018.3.3 ebuild (idea-community-2018.3.3.183.5153.38.ebuild,1.87 KB, text/plain)
2019-01-19 10:09 UTC, Kyle Elbert
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Giergun 2019-01-03 11:49:01 UTC
A newer version of idea-community is out, also some changes in it's ebuild required (see attachment).

Reproducible: Always
Comment 1 Adam Giergun 2019-01-03 11:53:12 UTC
Created attachment 559590 [details]
idea-community-2018.3.2.183.4886.37.ebuild

Some changes are required due to change in name of jre dir (jre -> jre64), also some files added to fperm list of files in bin dir.
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2019-01-04 06:17:43 UTC
Comment on attachment 559590 [details]
idea-community-2018.3.2.183.4886.37.ebuild

--- idea-community-2018.3.1.183.4588.61.ebuild  2018-12-11 12:43:54.849078380 +0100
+++ -   2019-01-04 07:17:27.570961841 +0100
@@ -41,8 +41,8 @@
                rm bin/fsnotifier-arm || die
        fi
        if ! use custom-jdk; then
-               if [[ -d jre ]]; then
-                       rm -r jre || die
+               if [[ -d jre64 ]]; then
+                       rm -r jre64 || die
                fi
        fi
 }
@@ -52,11 +52,11 @@

        insinto "${dir}"
        doins -r *
-       fperms 755 "${dir}"/bin/{idea.sh,fsnotifier{,64}}
+       fperms 755 "${dir}"/bin/{format.sh,idea.sh,inspect.sh,printenv.py,restart.py,fsnotifier{,64}}

        if use custom-jdk; then
-               if [[ -d jre ]]; then
-               fperms 755 "${dir}"/jre/jre/bin/{java,jjs,keytool,orbd,pack200,policytool,rmid,rmiregistry,servertool,tnameserv,unpack200}
+               if [[ -d jre64 ]]; then
+               fperms 755 "${dir}"/jre64/bin/{java,jjs,keytool,orbd,pack200,policytool,rmid,rmiregistry,servertool,tnameserv,unpack200}
                fi
        fi
Comment 3 Adam Giergun 2019-01-15 10:14:07 UTC
New version 2018.3.3 is out.
Just renaming attached ebuild to idea-community-2018.3.3.183.5153.38.ebuild seems to work OK.
Comment 4 Kyle Elbert 2019-01-19 04:40:18 UTC
Created attachment 562106 [details]
potential 2018.3.3 ebuild

Bump to 2018.3.3. Incorporated the jdk64 change, also since the jdk is now 64 bit only, should mask the custom-jdk use flag on x86 (but that should be done in the profile use.mask?), also switched to eapi 7, seems to work fine with simple get_version_component_range -> ver_cut changes and inheriting the desktop eclass. 

Someone with more experience should certainly double check this, but repoman isn't complaining.
Comment 5 Adam Giergun 2019-01-19 09:47:58 UTC
Comment on attachment 562106 [details]
potential 2018.3.3 ebuild

Line 59 is improper.
"fperms 755 "${dir}"/jre64/jre/bin/{java,jjs,keytool,orbd,pack200,policytool,rmid,rmiregistry,servertool,tnameserv,unpack200}"

Currently there is no /jre64/jre/bin dir, it's simply /jre64/bin. So it should be:

fperms 755 "${dir}"/jre64/bin/{java,jjs,keytool,orbd,pack200,policytool,rmid,rmiregistry,servertool,tnameserv,unpack200}
Comment 6 Kyle Elbert 2019-01-19 10:09:02 UTC
Created attachment 562114 [details]
2nd revision potential 2018.3.3 ebuild

fixed line 59 per comment re:jre bin directory change
Comment 7 Larry the Git Cow gentoo-dev 2019-01-29 14:59:01 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c5bf94fbe98e793c83ffff8615d1ddf93da395e6

commit c5bf94fbe98e793c83ffff8615d1ddf93da395e6
Author:     Kyle Elbert <kcelbert@gmail.com>
AuthorDate: 2019-01-26 06:36:52 +0000
Commit:     Alice Ferrazzi <alicef@gentoo.org>
CommitDate: 2019-01-29 14:58:41 +0000

    dev-util/idea-community: version bump to 2018.3.3 and EAPI 7 port
    
    Bug: https://bugs.gentoo.org/674404
    Package-Manager: Portage-2.3.58, Repoman-2.3.12
    Signed-off-by: Kyle Elbert <kcelbert@gmail.com>
    Signed-off-by: Alice Ferrazzi <alicef@gentoo.org>
    Closes: https://github.com/gentoo/gentoo/pull/10905
    Signed-off-by: Alice Ferrazzi <alicef@gentoo.org>

 dev-util/idea-community/Manifest                   |  1 +
 .../idea-community-2018.3.3.183.5153.38.ebuild     | 70 ++++++++++++++++++++++
 2 files changed, 71 insertions(+)