Bug 674176 – mail-client/mutt-1.11.1 - colours kill the mail start

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description pmn 2018-12-31 15:16:08 UTC]

these two lines of config will crash mutt:

#------------------------------------------------
color index  color245 default ~A
color index  color250 default "~Y 'inbox|unread'"
#------------------------------------------------

IUSE:

debug hcache imap lmdb notmuch sasl smime ssl 
-berkdb -crypt -doc -gdbm -gnutls -gpg -gpgme 
-idn -kerberos -libressl -mbox -nls -nntp 
-pgp_classic -pop -prefix -qdbm -selinux 
-slang -smime_classic -smtp -tokyocabinet 
-vanilla

[Comment 1 pmn 2018-12-31 15:16:40 UTC]

add upstream report ref.

[Comment 2 Kevin J. McCarthy 2018-12-31 20:30:57 UTC]

Inside features-extra/0011-feature-notmuch.patch.  At the part where it patches pattern.c, I would suggest adding a check:

Original fragment of the patch:

diff -r 1694913a8bf8 -r 0de8383bc638 pattern.c
--- a/pattern.c	Sun Dec 02 18:57:02 2018 +0100
+++ b/pattern.c	Sun Dec 02 18:57:05 2018 +0100
@@ -1402,6 +1409,13 @@ mutt_pattern_exec (struct pattern_t *pat
      return (pat->not ^ ((h->security & PGPKEY) == PGPKEY));
     case MUTT_XLABEL:
       return (pat->not ^ (h->env->x_label && patmatch (pat, h->env->x_label) == 0));
+#ifdef USE_NOTMUCH
+    case MUTT_NOTMUCH_LABEL:
+      {
+      char *tags = nm_header_get_tags(h);
+      return (pat->not ^ (tags && patmatch (pat, tags) == 0));
+      }
+#endif
     case MUTT_HORMEL:
       return (pat->not ^ (h->env->spam && h->env->spam->data && patmatch (pat, h->env->spam->data) == 0));
     case MUTT_DUPLICATED:


Change this fragment to:

+#ifdef USE_NOTMUCH
+    case MUTT_NOTMUCH_LABEL:
+      {
+        char *tags;
+        if (!ctx || (ctx->magic != MUTT_NOTMUCH))
+         return 0;
+        tags = nm_header_get_tags(h);
+        return (pat->not ^ (tags && patmatch (pat, tags) == 0));
+      }
+#endif

[Comment 3 Fabian Groffen 2019-01-01 14:37:58 UTC]

Thanks Kevin!

Sgt. Garcia, can you test a change for me if I give you some instructions?

[Comment 4 Fabian Groffen 2019-01-01 17:56:35 UTC]

@Sgt. Garcia:

% cd /usr/portage/mail-client/mutt
% sed -i -e '/^PATCHREV=/s/r0/r1/' mutt-1.11.1.ebuild
% ebuild mutt-1.11.1.ebuild digest
# emerge =mutt-1.11.1

[Comment 5 Larry the Git Cow 2019-01-02 10:54:41 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3df596d62c4acc8e63139433ac8241b93931bd8a

commit 3df596d62c4acc8e63139433ac8241b93931bd8a
Author:     Fabian Groffen <[e-mail]>
AuthorDate: 2019-01-02 10:54:07 +0000
Commit:     Fabian Groffen <[e-mail]>
CommitDate: 2019-01-02 10:54:25 +0000

    mail-client/mutt: revbump to fix some patches
    
    Bug: https://bugs.gentoo.org/674176
    Bug: https://bugs.gentoo.org/674202
    Signed-off-by: Fabian Groffen <[e-mail]>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11

 mail-client/mutt/Manifest                                      | 2 +-
 mail-client/mutt/{mutt-1.11.1.ebuild => mutt-1.11.1-r1.ebuild} | 8 ++++++--
 2 files changed, 7 insertions(+), 3 deletions(-)

[Comment 6 Fabian Groffen 2019-01-02 10:55:45 UTC]

-r1 includes the change, could you please confirm that version fixes it?

[Comment 7 pmn 2019-01-02 15:19:54 UTC]

(In reply to Fabian Groffen from comment #6)
> -r1 includes the change, could you please confirm that version fixes it?

fixed thanks.