Created attachment 559030 [details] emerge --info On armhf, the swig section of dev-python/m2crypto fails with the following error: running build_ext building 'M2Crypto._m2crypto' extension swigging SWIG/_m2crypto.i to SWIG/_m2crypto_wrap.c swig -python -D__armv6l__ -I/usr/include/python2.7 -I/usr/include -I/usr/include/openssl -I/usr/lib/gcc/armv6j-unknown-linux-gnueabihf/8.2.0/include -I/usr/lib/gcc/armv6j-unknown-linux-gnueabihf/8.2.0/include-fixed -I/usr/include -includeall -modern -builtin -outdir /var/tmp/portage/dev-python/m2crypto-0.31.0/work/M2Crypto-0.31.0/M2Crypto -o SWIG/_m2crypto_wrap.c SWIG/_m2crypto.i /usr/include/gnu/stubs.h:7: Error: Unable to find 'gnu/stubs-soft.h' error: command 'swig' failed with exit status 1 It appears to be related to confusion over hard/softfloat ABIs. The contents of /usr/include/gnu/stubs.h are: #if !defined __ARM_PCS_VFP # include <gnu/stubs-soft.h> #endif #if defined __ARM_PCS_VFP # include <gnu/stubs-hard.h> #endif such that stubs-hard.h should be included on armhf systems, and stubs-soft.h otherwise. I have verified that __ARM_PCS_VFP is appropriately defined: #include <stdio.h> #include <gnu/stubs.h> int main() { printf("%i\n", __ARM_PCS_VFP); return 0; } $ gcc -Wall -Wextra -Werror -pedantic test.c -o test $ ./test 1 So this does seem to be swig's fault somehow.
Created attachment 559032 [details] build.log
See also: https://bugs.gentoo.org/667110 cross-armv7a-hardfloat-linux-gnueabi/gcc-8.2.0-r3 fails due to stubs-soft.h missing
I ran tc-is-softfloat from /usr/portage/eclass/toolchain-funcs.eclass with the following output: # tc-is-softfloat no I was also able to reproduce the test results from the original report https://bugs.gentoo.org/674112#c0 I noticed the "-D__armv7l__" the swig command of the error. Maybe this needs to be updated?
bug #667110 is probably unrelated. I guess swig (or m2crypto?) disables all predefined macros and breaks /usr/include/gnu/stubs.h import.
This bug started to influence other packages (iirc openssl related) negatively. They would not update because they depend on m2crypto. I modified /usr/include/gnu/stubs.h as follows: == /usr/include/gnu/stubs.h ============ #if !defined __ARM_PCS_VFP //# include <gnu/stubs-soft.h> # include <gnu/stubs-hard.h> #endif #if defined __ARM_PCS_VFP # include <gnu/stubs-hard.h> #endif ======================================== and ran == root# =============================== emerge -avt dev-python/m2crypto ======================================== which will emerge dev-python/m2crypto successfully. After that, I undid my changes to /usr/include/gnu/stubs.h and updated successfully as usual.
This does need some kind of fix/workaround for updating arm32 systems (although I'm not quite sure exactly where it needs to be fixed; most likely swig). Making a symlink from stubs-hard.h to stubs-soft.h is a viable workaround at least on hardfp, but would break softfp if anyone needs that. Ideas?
(In reply to Steve Arnold from comment #6) We could add some code to the ebuild to set the proper defines in SWIG_FEATURES based on tc-arch and tc-is-softfloat. I would just need someone to help me identify when -D__ARM_PCS_VFP should be added. We already do something similar when building for the x32 ABI on amd64.
Or better yet, we could just call tc-cpp-is-true "defined(__ARM_PCS_VFP)" directly.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d2a02b28d0a6e69cecefae8c2f93adef20ccbfe3 commit d2a02b28d0a6e69cecefae8c2f93adef20ccbfe3 Author: Mike Gilbert <floppym@gentoo.org> AuthorDate: 2019-08-14 19:36:01 +0000 Commit: Mike Gilbert <floppym@gentoo.org> CommitDate: 2019-08-14 19:36:56 +0000 dev-python/m2crypto: fix build on armhf Closes: https://bugs.gentoo.org/674112 Package-Manager: Portage-2.3.71_p6, Repoman-2.3.17_p5 Signed-off-by: Mike Gilbert <floppym@gentoo.org> dev-python/m2crypto/m2crypto-0.31.0-r2.ebuild | 22 +++++++++++++++++----- dev-python/m2crypto/m2crypto-0.35.2.ebuild | 22 +++++++++++++++++----- 2 files changed, 34 insertions(+), 10 deletions(-)
