Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 674080 - sys-libs/glibc-9999 should stop touching C-translit.h as it is now always automatically generated in the build directory
Summary: sys-libs/glibc-9999 should stop touching C-translit.h as it is now always aut...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2018-12-30 12:46 UTC by Bart Oldeman
Modified: 2018-12-30 21:16 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to fix the issue. (glibc-no-touch-C_translit_h.diff,804 bytes, text/plain)
2018-12-30 12:46 UTC, Bart Oldeman
Details
build log (build.log,301.75 KB, application/octet-stream)
2018-12-30 16:37 UTC, Bart Oldeman
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bart Oldeman 2018-12-30 12:46:27 UTC
Created attachment 558986 [details]
Patch to fix the issue.

The glibc ebuild needs to stop touching C-translit.h, as it's now always automatically generated in the build directory. Touching it creates a 0-byte file that causes missing symbols when it's included instead of the generated file.

See here for the glibc change:
https://sourceware.org/git/?p=glibc.git;a=commit;h=053c52b17739a584ee73d336e547b15abcdabd49

Patch attached.
Comment 1 Sergei Trofimovich (RETIRED) gentoo-dev 2018-12-30 13:25:31 UTC
Looks good.

How did you notice?
Comment 2 Bart Oldeman 2018-12-30 16:37:34 UTC
Created attachment 559020 [details]
build log
Comment 3 Bart Oldeman 2018-12-30 16:40:41 UTC
without the patch you get errors such as below, see attached build.log, because the wrong empty C_translit.h was included.

x86_64-pc-linux-gnu-gcc -m64 -pipe -pipe -O2 -fno-strict-aliasing -Wl,-O1 -Wl,--as-needed C-address.c -c -std=gnu11 -fgnu89-inline  -pipe -pipe -O2 -fno-strict-aliasing -Wall -Wwrite-strings -Wundef -fmerge-all-constants -frounding-math -fstack-protector-all -Wstrict-prototypes -Wold-style-definition -fno-math-errno      -ftls-model=initial-exec   -U_FORTIFY_SOURCE  -DCOMPLOCALEDIR='"/localscratch/boldeman/gentoo/usr/lib64/locale"' -DLOCALE_ALIAS_PATH='"/localscratch/boldeman/gentoo/usr/share/locale"' -Iprograms -I../include -I/localscratch/boldeman/gentoo/var/tmp/portage/sys-libs/glibc-9999/work/build-amd64-x86_64-pc-linux-gnu-nptl/locale  -I/localscratch/boldeman/gentoo/var/tmp/portage/sys-libs/glibc-9999/work/build-amd64-x86_64-pc-linux-gnu-nptl  -I../sysdeps/unix/sysv/linux/x86_64/64  -I../sysdeps/unix/sysv/linux/x86_64  -I../sysdeps/unix/sysv/linux/x86/include -I../sysdeps/unix/sysv/linux/x86  -I../sysdeps/x86/nptl  -I../sysdeps/unix/sysv/linux/wordsize-64  -I../sysdeps/x86_64/nptl  -I../sysdeps/unix/sysv/linux/include -I../sysdeps/unix/sysv/linux  -I../sysdeps/nptl  -I../sysdeps/pthread  -I../sysdeps/gnu  -I../sysdeps/unix/inet  -I../sysdeps/unix/sysv  -I../sysdeps/unix/x86_64  -I../sysdeps/unix  -I../sysdeps/posix  -I../sysdeps/x86_64/64  -I../sysdeps/x86_64/fpu/multiarch  -I../sysdeps/x86_64/fpu  -I../sysdeps/x86/fpu/include -I../sysdeps/x86/fpu  -I../sysdeps/x86_64/multiarch  -I../sysdeps/x86_64  -I../sysdeps/x86  -I../sysdeps/ieee754/float128  -I../sysdeps/ieee754/ldbl-96/include -I../sysdeps/ieee754/ldbl-96  -I../sysdeps/ieee754/dbl-64/wordsize-64  -I../sysdeps/ieee754/dbl-64  -I../sysdeps/ieee754/flt-32  -I../sysdeps/wordsize-64  -I../sysdeps/ieee754  -I../sysdeps/generic  -I.. -I../libio -I. -nostdinc -isystem /localscratch/boldeman/gentoo/usr/lib/gcc/x86_64-pc-linux-gnu/8.2.0/include -isystem /localscratch/boldeman/gentoo/usr/lib/gcc/x86_64-pc-linux-gnu/8.2.0/include-fixed -isystem /localscratch/boldeman/gentoo/usr/include  -D_LIBC_REENTRANT -include /localscratch/boldeman/gentoo/var/tmp/portage/sys-libs/glibc-9999/work/build-amd64-x86_64-pc-linux-gnu-nptl/libc-modules.h -DMODULE_NAME=libc -include ../include/libc-symbols.h  -DPIC     -DTOP_NAMESPACE=glibc -o /localscratch/boldeman/gentoo/var/tmp/portage/sys-libs/glibc-9999/work/build-amd64-x86_64-pc-linux-gnu-nptl/locale/C-address.o -MD -MP -MF /localscratch/boldeman/gentoo/var/tmp/portage/sys-libs/glibc-9999/work/build-amd64-x86_64-pc-linux-gnu-nptl/locale/C-address.o.dt -MT /localscratch/boldeman/gentoo/var/tmp/portage/sys-libs/glibc-9999/work/build-amd64-x86_64-pc-linux-gnu-nptl/locale/C-address.o
C-ctype.c:638:15: error: 'NTRANSLIT' undeclared here (not in a function)
     { .word = NTRANSLIT },
               ^~~~~~~~~
Comment 4 Larry the Git Cow gentoo-dev 2018-12-30 21:14:15 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1c21dcc94ef9d60d9a655275dc0cf989ae8980ac

commit 1c21dcc94ef9d60d9a655275dc0cf989ae8980ac
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2018-12-30 21:09:50 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2018-12-30 21:14:07 +0000

    sys-libs/glibc: fix live ebuild build failure, bug #674080
    
    Fix by Bart Oldeman:
    
    Stop touching C-translit.h, as it's now always automatically generated in the
    build directory. Touching it creates a 0-byte file that causes missing symbols
    when it's included instead of the generated file.
    
    See here for the glibc change:
    https://sourceware.org/git/?p=glibc.git;a=commit;h=053c52b17739a584ee73d336e547b15abcdabd49
    
    Closes: https://bugs.gentoo.org/674080
    Signed-off-by: Bart Oldeman <bartoldeman@gmail.com>
    Package-Manager: Portage-2.3.53, Repoman-2.3.12
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 sys-libs/glibc/glibc-9999.ebuild | 3 ---
 1 file changed, 3 deletions(-)
Comment 5 Sergei Trofimovich (RETIRED) gentoo-dev 2018-12-30 21:16:04 UTC
Pushed the change as is. Thank you!