Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 673804 - media-video/cheese-3.30.0 should not depend on media-libs/gst-plugins-base[X]
Summary: media-video/cheese-3.30.0 should not depend on media-libs/gst-plugins-base[X]
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2018-12-27 10:09 UTC by David Heidelberg (okias)
Modified: 2020-03-01 15:01 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Heidelberg (okias) 2018-12-27 10:09:50 UTC 
cheese works properly from wayland, X flag is not required.
Comment 1 David Heidelberg (okias) 2018-12-27 10:12:27 UTC 
to be more descriptive,

    >=media-libs/gst-plugins-base-1.4:1.0[introspection?,ogg,pango,theora,vorbis]
is enough to cheese work just fine. No Need to introduce X use flag
Comment 2 Matt Turner gentoo-dev 2019-10-19 20:13:25 UTC 
But still

    x11-libs/libX11
    x11-libs/libXtst

are listed in COMMON_DEPEND.
Comment 3 Larry the Git Cow gentoo-dev 2020-02-02 03:53:21 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=59a9a772ac2ad618268fc0f29533c02f00f67126

commit 59a9a772ac2ad618268fc0f29533c02f00f67126
Author:     David Heidelberg <david@ixit.cz>
AuthorDate: 2019-10-22 10:05:53 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2020-02-02 03:51:00 +0000

    media-video/cheese: bump 3.34.0
    
    - ported to meson
    - ported to EAPI7
    - make X dependency optional, since meson build do not requires xserver
    
    Closes: https://bugs.gentoo.org/673804
    Closes: https://bugs.gentoo.org/698250
    Closes: https://github.com/gentoo/gentoo/pull/13378
    Signed-off-by: David Heidelberg <david@ixit.cz>
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 media-video/cheese/Manifest                        |   1 +
 media-video/cheese/cheese-3.34.0.ebuild            | 103 +++++++++++++
 .../cheese/files/cheese-3.34.0-buildfix.patch      |  17 +++
 ...-3.34.0-help-No-more-menu-bars-in-3.34-UI.patch | 160 +++++++++++++++++++++
 4 files changed, 281 insertions(+)
Comment 4 Mart Raudsepp gentoo-dev 2020-03-01 13:31:16 UTC 
This seems to be some sort of wishful thinking here. meson.build very clearly and unconditionally checks for libX11 and automagically for libXtst, so I'm going to back all of this out in a revbump...
Comment 5 Mart Raudsepp gentoo-dev 2020-03-01 15:01:48 UTC 
I'll not reintroduce the gst-plugins-base[X] dep though, going to assume people get that properly from gst-plugins-meta or elsewhere when needed