Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 673494 - sys-kernel/linux-firmware-20181218[savedconfig] fails to remove files with spaces in their names
Summary: sys-kernel/linux-firmware-20181218[savedconfig] fails to remove files with sp...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Chí-Thanh Christopher Nguyễn
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-20 19:34 UTC by Daniel Nilsson
Modified: 2018-12-23 13:15 UTC (History)
11 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge-info-linux-fírmware.txt,6.11 KB, text/plain)
2018-12-20 19:34 UTC, Daniel Nilsson
Details
build log (sys-kernel:linux-firmware-20181218:20181220-191827.log,2.20 KB, text/plain)
2018-12-20 19:36 UTC, Daniel Nilsson
Details
Patch (linux-firmware.patch,3.22 KB, patch)
2018-12-22 07:24 UTC, Arfrever Frehtes Taifersar Arahesis
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Nilsson 2018-12-20 19:34:44 UTC
Created attachment 558230 [details]
emerge --info

Emerging sys-kernel/linux-firmware-20181218 with savedconfig fails when it tries to 'rm' a file with a space character in the name. Probably lack of quoting.

 * Building using saved configfile //etc/portage/savedconfig//sys-kernel/linux-firmware
 * Removing all files not listed in config ...
rm: cannot remove 'brcm/brcmfmac43430a0-sdio.ONDA-V80': No such file or directory
rm: cannot remove 'PLUS.txt': No such file or directory

The offending file is 'brcm/brcmfmac43430a0-sdio.ONDA-V80 PLUS.txt' which was recently added to linux-firmware.git.
Adding this filename to the savedconfig as a workaround allows the package to emerge correctly.

I will attach the full build log and emerge --info.
Comment 1 Daniel Nilsson 2018-12-20 19:36:16 UTC
Created attachment 558232 [details]
build log
Comment 2 Arfrever Frehtes Taifersar Arahesis 2018-12-22 07:24:06 UTC
Created attachment 558338 [details, diff]
Patch
Comment 3 Duncan 2018-12-23 07:36:22 UTC
(In reply to Arfrever Frehtes Taifersar Arahesis from comment #2)
> Created attachment 558338 [details, diff] [details, diff]
> Patch

Thanks.

I have a local script that allows me to patch ebuilds similar to the way $PORTDIR/patches/ works, but with $PORTDIR/patches.ebuild/ (drop the patch in the appropriate category/package/ subdir and it gets auto-applied after the repo git pull and sig check), and confirming...

This patch (modified to apply to only a single ebuild at a time, the script tries to apply it to all in category/package), applies and seems to work well.  sys-kernel/linux-firmware updated and based on the qmerge phase output, the appropriate files were merged.  I'll know for sure when I update/rebuild my kernel and reboot.  =:^)
Comment 4 Larry the Git Cow gentoo-dev 2018-12-23 13:15:29 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d9d822b5a8cb5c982247fb6871eef8b8467a05cb

commit d9d822b5a8cb5c982247fb6871eef8b8467a05cb
Author:     Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
AuthorDate: 2018-12-22 07:19:25 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2018-12-23 13:15:22 +0000

    sys-kernel/linux-firmware: Fix building with USE="savedconfig".
    
    Replace 'sort' + 'uniq -u' hack with BASH loops.
    
    Fixes: https://bugs.gentoo.org/673494
    Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 .../linux-firmware/linux-firmware-20181218.ebuild  | 29 +++++++++++++++++---
 .../linux-firmware/linux-firmware-99999999.ebuild  | 31 ++++++++++++++++++----
 2 files changed, 51 insertions(+), 9 deletions(-)