Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 673464 - media-plugins/alsa-plugins-1.1.7 aborts installation due to QA concerns on Gentoo Prefix
Summary: media-plugins/alsa-plugins-1.1.7 aborts installation due to QA concerns on Ge...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-20 00:48 UTC by Sammy Pfeiffer
Modified: 2019-04-25 07:56 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sammy Pfeiffer 2018-12-20 00:48:05 UTC
Installing media-plugins/alsa-plugins-1.1.7 on Gentoo Prefix one gets:

 * QA Notice: the following files are outside of the prefix:
 * /etc
 * /etc/alsa
 * /etc/alsa/conf.d
 * /etc/alsa/conf.d/60-upmix.conf
 * /etc/alsa/conf.d/60-vdownmix.conf
 * /etc/alsa/conf.d/98-usb-stream.conf
 * ERROR: media-plugins/alsa-plugins-1.1.7::gentoo failed:
 *   Aborting due to QA concerns: there are files installed outside the prefix
 * 
 * Call stack:
 *   misc-functions.sh, line 552:  Called install_qa_check
 *   misc-functions.sh, line  98:  Called source 'install_symlink_html_docs'
 *            05prefix, line 114:  Called install_qa_check_prefix
 *            05prefix, line  27:  Called die
 * The specific snippet of code:
 *   			die "Aborting due to QA concerns: there are files installed outside the prefix"


Note that media-plugins/alsa-plugins-1.1.6 does NOT show this behaviour. (The ebuilds look almost identical, so I guess it's somewhere in the package that this is happening).

Reproducible: Always
Comment 1 Sammy Pfeiffer 2018-12-20 00:53:47 UTC
The full list (sorry, I was messing around with the ebuild and I posted the output of a moment I commented out the contents of multilib_src_install_all):

 * QA Notice: the following files are outside of the prefix:
 * /etc
 * /etc/alsa
 * /etc/alsa/conf.d
 * /etc/alsa/conf.d/50-pulseaudio.conf
 * /etc/alsa/conf.d/99-pulseaudio-default.conf.example
 * /etc/alsa/conf.d/60-vdownmix.conf
 * /etc/alsa/conf.d/60-upmix.conf
 * /etc/alsa/conf.d/98-usb-stream.conf
Comment 2 Sammy Pfeiffer 2018-12-20 01:15:51 UTC
I found a fix, adding to the ebuild:

multilib_src_configure() {
	use debug || append-cppflags -DNDEBUG

	local myeconfargs=(
                # To avoid QA concerns about installing out of prefix
                --with-alsagconfdir=${D#/}/etc/alsa/conf.d
                --with-alsalconfdir=${D#/}/etc/alsa/conf.d
		--with-speex="$(usex speex lib no)"


(The interesting lines are --with-alsa...)
Comment 3 Sammy Pfeiffer 2018-12-20 01:16:51 UTC
Forgot to mention that:

--with-alsagconfdir
--with-alsalconfdir

Appeared in the configure file as options in 1.1.7 (they weren't there in 1.1.6). Found them doing a diff/meld.
Comment 4 Sammy Pfeiffer 2019-01-10 06:05:45 UTC
@sound
Comment 5 Larry the Git Cow gentoo-dev 2019-04-25 07:56:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0810609af1d6d3e0f2df719bb8f3d0b46d8367f1

commit 0810609af1d6d3e0f2df719bb8f3d0b46d8367f1
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2019-04-25 07:54:05 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2019-04-25 07:56:00 +0000

    media-plugins/alsa-plugins: respect EPREFIX, bug #673464
    
    Sammy Pfeiffer discovered and provided a fix for alsa-plugins
    where from version 1.1.7 new option got a default without $(prefix):
                    --with-alsalconfdir=/etc/alsa/conf.d
    
    The fix is to add a prefix:
        --with-alsalconfdir="${EPREFIX}"/etc/alsa/conf.d
    
    Reported-by: Sammy Pfeiffer
    Closes: https://bugs.gentoo.org/673464
    Package-Manager: Portage-2.3.64, Repoman-2.3.12
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 .../alsa-plugins/alsa-plugins-1.1.8-r1.ebuild      | 101 +++++++++++++++++++++
 1 file changed, 101 insertions(+)