build fails with: In file included from /usr/include/qt5/QtCore/qconfig.h:1, from /usr/include/qt5/QtCore/qglobal.h:66, from /var/tmp/notmpfs/portage/dev-qt/qtwebengine-5.12.0/work/qtwebengine-everywhere-src-5.12.0/src/core/build_config_qt.h:43, from /var/tmp/notmpfs/portage/dev-qt/qtwebengine-5.12.0/work/qtwebengine-everywhere-src-5.12.0/src/core/web_engine_context.h:43, from /var/tmp/notmpfs/portage/dev-qt/qtwebengine-5.12.0/work/qtwebengine-everywhere-src-5.12.0/src/core/web_engine_context.cpp:40: /usr/include/qt5/Gentoo/gentoo-qconfig.h:11: note: this is the location of the previous definition #define QT_LINKED_OPENSSL /var/tmp/notmpfs/portage/dev-qt/qtwebengine-5.12.0/work/qtwebengine-everywhere-src-5.12.0/src/core/web_engine_context.cpp: In constructor ‘QtWebEngineCore::WebEngineContext::WebEngineContext()’: /var/tmp/notmpfs/portage/dev-qt/qtwebengine-5.12.0/work/qtwebengine-everywhere-src-5.12.0/src/core/web_engine_context.cpp:488:82: error: ‘platform’ was not declared in this scope if (!qEnvironmentVariableIsSet("QT_WEBENGINE_DISABLE_WAYLAND_WORKAROUND") && platform.startsWith("wayland", Qt::CaseInsensitive)) ^~~~~~~~ /var/tmp/notmpfs/portage/dev-qt/qtwebengine-5.12.0/work/qtwebengine-everywhere-src-5.12.0/src/core/web_engine_context.cpp:488:82: note: suggested alternative: ‘alarm’ if (!qEnvironmentVariableIsSet("QT_WEBENGINE_DISABLE_WAYLAND_WORKAROUND") && platform.startsWith("wayland", Qt::CaseInsensitive)) ^~~~~~~~ alarm Did anyone tried compile before bump? It looks like that it causing patch qtwebengine-5.11.1-nouveau-disable-gpu.patch . I just spend cca 8 hours to compile it and found out it's not compilable.
reverting patch solved issue. Please remove (and or refactor patch).
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/proj/qt.git/commit/?id=8044dd90e226c6cf7deddf540bd08b13dc55234a commit 8044dd90e226c6cf7deddf540bd08b13dc55234a Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2018-12-18 18:36:01 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2018-12-18 18:36:01 +0000 dev-qt/qtwebengine: Fix nouveau-disable-gpu patch Closes: https://bugs.gentoo.org/673398 Package-Manager: Portage-2.3.52, Repoman-2.3.12 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> ...atch => qtwebengine-5.12.0-nouveau-disable-gpu.patch} | 16 ++++++++-------- dev-qt/qtwebengine/qtwebengine-5.12.0.ebuild | 2 +- dev-qt/qtwebengine/qtwebengine-5.12.9999.ebuild | 2 +- 3 files changed, 10 insertions(+), 10 deletions(-)
(In reply to David Heidelberg (okias) from comment #0) > I just spend cca 8 hours to compile it and found out it's not compilable. Thanks for testing, which is both purpose and risk of an overlay.
*** Bug 673452 has been marked as a duplicate of this bug. ***
(In reply to Andreas Sturmlechner from comment #3) > (In reply to David Heidelberg (okias) from comment #0) > > I just spend cca 8 hours to compile it and found out it's not compilable. > Thanks for testing, which is both purpose and risk of an overlay. I think purpose of this overlay should be testing of cutting edge QT before it goes into Portage. I get that it's not possible discover every impact of applied patch, but I don't think purpose of this overlay is to push there build untested QT ebuild. At least I learnt from Gentoo development before publishing always compile packages at least on one machine, to be sure it's sane.
Not to start a discussion here, but I'd like to share a few thoughts as one of the people working on the Qt overlay. (In reply to David Heidelberg (okias) from comment #5) > I think purpose of this overlay should be testing of cutting edge QT before > it goes into Portage. That certainly is a big part of it. The main part probably being to have anything related to be tested before getting to the official ebuild repository. > I get that it's not possible discover every impact of applied patch, but I > don't think purpose of this overlay is to push there build untested QT > ebuild. I know it can be annoying, but something like this is likely to happen again in the future too. Depending on the annoying levels, I'd suggest giving big things like this a bit of time before going for it (for example with this particular issue, I did notice it as well, before this bug report, but simply didn't quite get to doing anything about it). Sometimes the one doing the initial work simply might not have the time, or didn't notice something, and then someone else will point things out and so on and forth. Things get done. :] > At least I learnt from Gentoo development before publishing always compile > packages at least on one machine, to be sure it's sane. Anything going from the Qt overlay to the official Gentoo ebuild repository almost certainly gets this, and in which the overlay is of great help indeed. :] Considering how much the current members of the Qt project are able to contribute, I'd say we're quite lucky to have anything beyond Qt 5.9.4 (stabilised 2018-03-24). You'll certainly not see me getting upset, even if a developer outside the Qt project pushes something untested into the overlay. As I said, these are my thoughts on the matter, sane or not, and may not reflect the opinions of the others involved. Thank you!
