Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 673230 - media-libs/vulkan-layers-1.1.92.0, media-libs/vulkan-loader-1.1.92.1: BUILD_WSI_MIR_SUPPORT cmake variable not used
Summary: media-libs/vulkan-layers-1.1.92.0, media-libs/vulkan-loader-1.1.92.1: BUILD_W...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal minor
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-16 06:37 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2018-12-16 14:04 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2018-12-16 06:37:57 UTC
Ebuilds of media-libs/vulkan-layers-1.1.92.0 and media-libs/vulkan-loader-1.1.92.1 set BUILD_WSI_MIR_SUPPORT cmake variable which is no longer used.
It was used in older versions.


$ grep -r BUILD_WSI_MIR_SUPPORT vulkan-layers-1.1.82.0
vulkan-layers-1.1.82.0/BUILD.md:| BUILD_WSI_MIR_SUPPORT | Linux | `OFF` | Build the components with Mir support. |
vulkan-layers-1.1.82.0/tests/CMakeLists.txt:    if(BUILD_WSI_MIR_SUPPORT)
vulkan-layers-1.1.82.0/layers/CMakeLists.txt:    if(BUILD_WSI_MIR_SUPPORT)
vulkan-layers-1.1.82.0/CMakeLists.txt:    option(BUILD_WSI_MIR_SUPPORT "Build Mir WSI support" OFF)
vulkan-layers-1.1.82.0/CMakeLists.txt:    if(BUILD_WSI_MIR_SUPPORT)
$ grep -r BUILD_WSI_MIR_SUPPORT vulkan-layers-1.1.92.0
$ grep -r BUILD_WSI_MIR_SUPPORT vulkan-loader-1.1.82.0
vulkan-loader-1.1.82.0/BUILD.md:| BUILD_WSI_MIR_SUPPORT | Linux | `OFF` | Build the loader with the Mir entry points enabled. Without this, the Mir headers should not be needed, but the extension `VK_KHR_mir_surface` won't be available. |
vulkan-loader-1.1.82.0/tests/CMakeLists.txt:    if(BUILD_WSI_MIR_SUPPORT)
vulkan-loader-1.1.82.0/loader/CMakeLists.txt:    if(BUILD_WSI_MIR_SUPPORT)
vulkan-loader-1.1.82.0/CMakeLists.txt:    option(BUILD_WSI_MIR_SUPPORT "Build Mir WSI support" OFF)
vulkan-loader-1.1.82.0/CMakeLists.txt:    if(BUILD_WSI_MIR_SUPPORT)
$ grep -r BUILD_WSI_MIR_SUPPORT vulkan-loader-1.1.92.1
$


Warning seen during building:
"""
CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_WSI_MIR_SUPPORT
"""
Comment 1 Larry the Git Cow gentoo-dev 2018-12-16 14:04:02 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dfa54de334358b85a19818f43e0dbd3dbe393453

commit dfa54de334358b85a19818f43e0dbd3dbe393453
Author:     Nick Sarnie <sarnex@gentoo.org>
AuthorDate: 2018-12-16 14:00:45 +0000
Commit:     Nick Sarnie <sarnex@gentoo.org>
CommitDate: 2018-12-16 14:00:45 +0000

    media-libs/vulkan-layers: Remove unused cmake variable
    
    Fixes: https://bugs.gentoo.org/673230
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Nick Sarnie <sarnex@gentoo.org>

 media-libs/vulkan-layers/vulkan-layers-1.1.92.0.ebuild | 1 -
 media-libs/vulkan-layers/vulkan-layers-9999.ebuild     | 1 -
 2 files changed, 2 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=45b739107bcc41f1bdaac9c79fb118199b879084

commit 45b739107bcc41f1bdaac9c79fb118199b879084
Author:     Nick Sarnie <sarnex@gentoo.org>
AuthorDate: 2018-12-16 14:00:07 +0000
Commit:     Nick Sarnie <sarnex@gentoo.org>
CommitDate: 2018-12-16 14:00:07 +0000

    media-libs/vulkan-loader: Remove unused cmake variable
    
    Fixes: https://bugs.gentoo.org/673230
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Nick Sarnie <sarnex@gentoo.org>

 media-libs/vulkan-loader/vulkan-loader-1.1.92.1.ebuild | 1 -
 media-libs/vulkan-loader/vulkan-loader-9999.ebuild     | 1 -
 2 files changed, 2 deletions(-)