Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 673068 - net-libs/nodejs-11.4.0 USE=-ssl - ../src/node.cc:826:3: error: ‘va_start’ was not declared in this scope
Summary: net-libs/nodejs-11.4.0 USE=-ssl - ../src/node.cc:826:3: error: ‘va_start’ was...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Jeroen Roovers (RETIRED)
URL: https://github.com/nodejs/node/commit...
Whiteboard:
Keywords: UPSTREAM
Depends on:
Blocks:
 
Reported: 2018-12-13 10:03 UTC by Sven B.
Modified: 2018-12-27 21:15 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge info and build.log (emerge.log.xz,36.09 KB, application/x-xz)
2018-12-13 10:03 UTC, Sven B.
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sven B. 2018-12-13 10:03:32 UTC
Created attachment 557712 [details]
emerge info and build.log

USE="-debug -doc -icu -inspector -npm -snapshot -ssl -systemtap -test"

../src/node.cc:826:3: error: ‘va_start’ was not declared in this scope
   va_start(ap, fmt);
   ^~~~~~~~
../src/node.cc:826:3: note: suggested alternative: ‘Start’
   va_start(ap, fmt);
   ^~~~~~~~
   Start
../src/node.cc:828:3: error: ‘va_end’ was not declared in this scope
   va_end(ap);

If patched by including the missing header via userpatches: another two show up missing ‘llhttp_version’, ‘http_parser_version’;
haven't tested any further.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2018-12-13 10:50:07 UTC
(In reply to Sven B. from comment #0)
> Created attachment 557712 [details]
> emerge info and build.log
> 
> USE="-debug -doc -icu -inspector -npm -snapshot -ssl -systemtap -test"

It must have something to do with (one of or all of) these disabled features.
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2018-12-13 10:54:37 UTC
I am not sure what patch you refer to, but it does look like it should have an

#include <stdarg.h>

in there.
Comment 3 Larry the Git Cow gentoo-dev 2018-12-13 12:12:23 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ed00b6407d1bae9b69d130a5f42ffc6c7a9f4361

commit ed00b6407d1bae9b69d130a5f42ffc6c7a9f4361
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2018-12-13 12:11:59 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2018-12-13 12:12:19 +0000

    net-libs/nodejs: Include stdarg.h
    
    Bug: https://bugs.gentoo.org/673068
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 net-libs/nodejs/files/nodejs-11.4.0-stdarg_h.patch | 10 ++++++++++
 net-libs/nodejs/nodejs-11.4.0.ebuild               |  1 +
 2 files changed, 11 insertions(+)
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2018-12-13 12:13:54 UTC
I am seeing the llhttp/http_parser problem now.
Comment 5 Larry the Git Cow gentoo-dev 2018-12-13 12:44:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1efdc0143f027193a6784b6f3a594feb7fdf2a31

commit 1efdc0143f027193a6784b6f3a594feb7fdf2a31
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2018-12-13 12:44:34 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2018-12-13 12:44:47 +0000

    net-libs/nodejs: src/node_metadata.cc: Include node_internals.h
    
    Fixes: https://bugs.gentoo.org/673068
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 net-libs/nodejs/files/nodejs-11.4.0-llhttp.patch | 10 ++++++++++
 1 file changed, 10 insertions(+)
Comment 6 Sven B. 2018-12-27 16:01:16 UTC
nodejs-11.6.0;  seems like another missing include on ( -ssl )

In file included from ../src/node_http_parser_traditional.cc:5:
../src/node_http_parser_impl.h: In function ‘void node::{anonymous}::InitMaxHttpHeaderSizeOnce()’:
../src/node_http_parser_impl.h:919:3: error: ‘http_parser_set_max_header_size’ was not declared in this scope
   http_parser_set_max_header_size(max_http_header_size);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/node_http_parser_impl.h:919:3: note: suggested alternative: ‘http_parser_version’
   http_parser_set_max_header_size(max_http_header_size);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   http_parser_version
Comment 7 Jeroen Roovers (RETIRED) gentoo-dev 2018-12-27 21:15:57 UTC
(In reply to Sven B. from comment #6)
> nodejs-11.6.0;  seems like another missing include on ( -ssl )
> 
> In file included from ../src/node_http_parser_traditional.cc:5:
> ../src/node_http_parser_impl.h: In function ‘void
> node::{anonymous}::InitMaxHttpHeaderSizeOnce()’:
> ../src/node_http_parser_impl.h:919:3: error:
> ‘http_parser_set_max_header_size’ was not declared in this scope
>    http_parser_set_max_header_size(max_http_header_size);
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../src/node_http_parser_impl.h:919:3: note: suggested alternative:
> ‘http_parser_version’
>    http_parser_set_max_header_size(max_http_header_size);
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    http_parser_version

Of course it isn't. This is bug #673830 you're seeing.