Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 672842 - net-misc/igmpproxy - init script not creating pidfile
Summary: net-misc/igmpproxy - init script not creating pidfile
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Conrad Kostecki
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2018-12-09 20:03 UTC by Rob Tongue
Modified: 2018-12-18 04:21 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Tongue 2018-12-09 20:03:44 UTC
igmpproxy init script not creating pidfile, so service always appears "crashed" even though it is running.  Starting and stopping works fine, but would be nice if the status was returned properly with a working pidfile.  Apologies if the bug doesn't belong here.

Reproducible: Always

Steps to Reproduce:
1. install igmpproxy
2. configure igmpproxy so it runs properly via igmpproxy.conf
3. start igmpproxy
Actual Results:  
Service runs, but appears crashed.

Expected Results:  
Service runs, and rc-service status should show it is running, and pidfile should be created.
Comment 1 Conrad Kostecki gentoo-dev 2018-12-11 08:49:40 UTC
Thanks for the spot!
I've removed the pidfile from the init script, as IGMPProxy does not create any. And --make-pidfile won't work in that case, as IGMPProxy seems to fork and the wrond pid number is written. Without pid, it's matching the name correctly and status works for me now fine.
Comment 2 Larry the Git Cow gentoo-dev 2018-12-18 04:21:21 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=97f03506d9dd795537f2af986aab17ea2f8e5d5a

commit 97f03506d9dd795537f2af986aab17ea2f8e5d5a
Author:     Conrad Kostecki <conrad@kostecki.com>
AuthorDate: 2018-12-11 08:44:08 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2018-12-18 04:18:38 +0000

    net-misc/igmpproxy: update pidfile handling
    
    Since IGMPProxy does not create a pid file by itself,
    the daemon needs to be started in foreground, to keep
    tracking of the correct pidfile with openrc and put it
    background.
    
    Closes: https://bugs.gentoo.org/672842
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Conrad Kostecki <conrad@kostecki.com>
    Closes: https://github.com/gentoo/gentoo/pull/10610
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 net-misc/igmpproxy/files/igmpproxy.initd-r1  | 12 ++++++++++++
 net-misc/igmpproxy/igmpproxy-0.2.1-r2.ebuild | 25 +++++++++++++++++++++++++
 2 files changed, 37 insertions(+)