Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 672528 - dev-lang/lua: slotted packages have invalid lua.pc
Summary: dev-lang/lua: slotted packages have invalid lua.pc
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Rafael Martins (RETIRED)
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2018-12-04 21:21 UTC by Karel Kočí
Modified: 2018-12-15 07:16 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karel Kočí 2018-12-04 21:21:11 UTC
I see that Robin H. Johnson <robbat2@gentoo.org> added slotted versions of Lua. I tried to use it but it does not work. pkg-config scripts are misconfigured.

I found that problem is in package it self. Although there is sed that updates lua.pc to correct config its effect is not propagated. It was for some reason added after multilib_copy_source and because of that it is applied on source that is in reality not used to build package. Moving that sed before multilib_copy_source is enough to have lua slotted packages fully working.
Comment 1 Larry the Git Cow gentoo-dev 2018-12-15 07:16:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ec909d1a2be3ea5f939ee0721cb22f156fe9d05c

commit ec909d1a2be3ea5f939ee0721cb22f156fe9d05c
Author:     Karel Kočí <cynerd@email.cz>
AuthorDate: 2018-12-04 21:20:39 +0000
Commit:     Robin H. Johnson <robbat2@gentoo.org>
CommitDate: 2018-12-15 07:15:12 +0000

    dev-lang/lua: fix slotted lua
    
    Command changing pkg-config file to appropriate variant is written after
    sources are copied to multilib builds because of that it is not
    propagated to system it self.
    
    Moving it before multilib_copy_source is enough to have fully working
    slotted Lua.
    
    Bug: https://bugs.gentoo.org/672528
    Signed-off-by: Karel Kočí <cynerd@email.cz>
    (cherry picked from commit f08c38554eaeea3a73908bb0f2af6055e3a19b44)
    Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
    Fixes: https://github.com/gentoo/gentoo/pull/10571
    Fixes: https://bugs.gentoo.org/672528

 dev-lang/lua/lua-5.1.5-r102.ebuild | 144 +++++++++++++++++++++++++++++++++++++
 dev-lang/lua/lua-5.2.3-r3.ebuild   | 143 ++++++++++++++++++++++++++++++++++++
 dev-lang/lua/lua-5.3.3-r2.ebuild   | 143 ++++++++++++++++++++++++++++++++++++
 3 files changed, 430 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ec909d1a2be3ea5f939ee0721cb22f156fe9d05c

commit ec909d1a2be3ea5f939ee0721cb22f156fe9d05c
Author:     Karel Kočí <cynerd@email.cz>
AuthorDate: 2018-12-04 21:20:39 +0000
Commit:     Robin H. Johnson <robbat2@gentoo.org>
CommitDate: 2018-12-15 07:15:12 +0000

    dev-lang/lua: fix slotted lua
    
    Command changing pkg-config file to appropriate variant is written after
    sources are copied to multilib builds because of that it is not
    propagated to system it self.
    
    Moving it before multilib_copy_source is enough to have fully working
    slotted Lua.
    
    Bug: https://bugs.gentoo.org/672528
    Signed-off-by: Karel Kočí <cynerd@email.cz>
    (cherry picked from commit f08c38554eaeea3a73908bb0f2af6055e3a19b44)
    Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
    Fixes: https://github.com/gentoo/gentoo/pull/10571
    Fixes: https://bugs.gentoo.org/672528

 dev-lang/lua/lua-5.1.5-r102.ebuild | 144 +++++++++++++++++++++++++++++++++++++
 dev-lang/lua/lua-5.2.3-r3.ebuild   | 143 ++++++++++++++++++++++++++++++++++++
 dev-lang/lua/lua-5.3.3-r2.ebuild   | 143 ++++++++++++++++++++++++++++++++++++
 3 files changed, 430 insertions(+)