Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 672262 - audacious-plugins-3.9-r1 Selecting OpenGL Spectrum Analyzer crashes application
Summary: audacious-plugins-3.9-r1 Selecting OpenGL Spectrum Analyzer crashes application
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Jason A. Donenfeld
URL: https://github.com/audacious-media-pl...
Whiteboard:
Keywords: PATCH, PMASKED
Depends on:
Blocks:
 
Reported: 2018-11-29 22:55 UTC by locutus378
Modified: 2020-03-24 23:03 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
audacious-plugins-3.x OpenGL Spectrum Analyzer fix (file_672262.txt,472 bytes, patch)
2018-11-29 23:05 UTC, locutus378
Details | Diff
gl-spectrum.cc.commit.0b9c27041e918cb4369f7a4fd1e3d217a438aef1 (gl-spectrum.cc.commit.0b9c27041e918cb4369f7a4fd1e3d217a438aef1,792 bytes, patch)
2018-11-30 01:36 UTC, locutus378
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description locutus378 2018-11-29 22:55:01 UTC
All attemps to use the Open GL Spectrum Analyzer plugin on all audacious-plugins 3.x versions causes it to crash with an X BadMatch error message. Systems are using nvidia-drivers and various versions of nvidia-drivers were tested to rule out possibility of it being nvidia-driver version related.


Reproducible: Always

Steps to Reproduce:
1. Start audacious.
2. Settings->Plugins->Open GL Spectrum Analyzer, click to enable.
3. Crash!
Actual Results:  
The program 'audacious' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadMatch (invalid parameter attributes)'.


Expected Results:  
A working Open GL Spectrum analyzer window.

Problem and patch to fix it have been reported upstream to developer email address. No reply has been received after 30 days.
Comment 1 locutus378 2018-11-29 23:05:00 UTC
Created attachment 556740 [details, diff]
audacious-plugins-3.x OpenGL Spectrum Analyzer fix

This patch fixes the problem on every 3.x version of audacious-plugins that uses gl-spectrum.cc that I was able to test it against.
Comment 2 Andreas Sturmlechner gentoo-dev 2018-11-29 23:09:45 UTC
(In reply to locutus378 from comment #0)
> Problem and patch to fix it have been reported upstream to developer email
> address. No reply has been received after 30 days.
What's that mean?
Why didn't you file a bug?
Did you try 3.10?
Comment 3 locutus378 2018-11-29 23:15:42 UTC
media-plugins/audacious-plugins-3.x errata:

Video drivers: nvidia-drivers (any version), others may or not be affected.

eix audacious-plugins:
Installed versions:  3.9-r99(08:00:29 PM 10/24/2018)(aac alsa bs2b cdda cue ffmpeg flac gtk libsamplerate mp3 nls sdl sndfile vorbis wavpack -adplug -ampache -aosd -fluidsynth -gme -gnome -gtk3 -hotkeys -http -jack -lame -libav -libnotify -lirc -mms -modplug -pulseaudio -qt5 -scrobbler -sid -soxr -speedpitch)



PROBLEM DESCRIPTION:
When enabling Settings->Plugins->Open GL Spectrum Analyzer, it crashes with:

The program 'audacious' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadMatch (invalid parameter attributes)'.
  (Details: serial 245 error_code 8 request_code 153 minor_code 5)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the --sync command line
   option to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)
WARNING main.cc:320 [main_cleanup]: exit() called unexpectedly; skipping normal cleanup.


DIAGNOSIS:
glXChooseVisual correctly returns the RGBA visual with 8 bit alpha channel,
based on the attribs passed to glXChooseVisual. GLX_RGBA attrib selects a
truecolor visual. GLX_ALPHA_SIZE attrib selects a visual with >0 alpha bits.
glXMakeCurrent crashes using context from glXCreateContext from this visual.
According to the source code, the plugin doesn't use the alpha channel.


RESOLUTION:
Change attribs to select a truecolor RGBA visual with 0 bits of alpha.
Problem and patch have been reported upstream to developer email address.
No reply has been received after 30 days. Patch sent to bugs.gentoo.org.
Comment 4 locutus378 2018-11-29 23:22:07 UTC
It means it's still broken and still needs to be patched. According to https://distfiles.audacious-media-player.org/ the audacious-plugins-3.10.tar.gz last mod time is 08-Aug-2018. The date this patch was created and emailed to upstream developer is 24-Oct. Ergo, still broken and still needs to be patched. Please let me know if you need me to explain anything else to you about this.
Comment 5 Andreas Sturmlechner gentoo-dev 2018-11-29 23:50:03 UTC
Please don't misuse the importance field.

Open a proper bug report upstream, don't send mail to individual developers.
Comment 6 locutus378 2018-11-29 23:59:39 UTC
Andreas, just to be sure for you, I checked 3.10 tarball and, as I already knew, it is still broken and still needs to be patched. I also checked the git and the patch has been applied to it. The developer did get my email, they just didn't have the common courtesy to reply "Thank you for fixing that vexatious bug".
Comment 7 Andreas Sturmlechner gentoo-dev 2018-11-30 00:12:45 UTC
(In reply to locutus378 from comment #6)
> I also checked the git and the patch has been applied to it.
See, that's the kind of information we want to see here.

Please attach the patch as picked from upstream commit (including patch header) instead.
Comment 8 locutus378 2018-11-30 01:36:13 UTC
Created attachment 556744 [details, diff]
gl-spectrum.cc.commit.0b9c27041e918cb4369f7a4fd1e3d217a438aef1

https://github.com/audacious-media-player/audacious-plugins/commit/0b9c27041e918cb4369f7a4fd1e3d217a438aef1

The "without much extra info" is particularly funny, seeing as how John got the exact same diagnosis paragraph that I posted here. Not even a "thanks to locutus378 for bothering to fix my code", just a "don't hesitate to revert".

The next time it crashes, it's "emerge -C audacious-plugins audacious" instead of me wasting my precious time fixing problems for ungrateful developers.

:>
Comment 9 Andreas Sturmlechner gentoo-dev 2018-11-30 02:16:13 UTC
(In reply to locutus378 from comment #8)
> The "without much extra info" is particularly funny, seeing as how John got
> the exact same diagnosis paragraph that I posted here. Not even a "thanks to
> locutus378 for bothering to fix my code", just a "don't hesitate to revert".
Well, unfortunately not all interactions are forthcoming all the time. Hence me recommending the use of official/public channels for these types of contributions, just as you did here.

Thanks for the link!
Comment 10 Andreas Sturmlechner gentoo-dev 2020-03-22 23:37:47 UTC
3.9 is maksed and will be dropped together with freeverb3.
Comment 11 Larry the Git Cow gentoo-dev 2020-03-24 23:03:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cac0a03cf647cfc1e8058024181c0b78ebe2ce4a

commit cac0a03cf647cfc1e8058024181c0b78ebe2ce4a
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-03-24 23:01:48 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-03-24 23:01:48 +0000

    profiles: Drop media-sound/audacious-3.9, media-plugins/audacious-3.9-r3
    
    Closes: https://bugs.gentoo.org/671828
    Closes: https://bugs.gentoo.org/672262
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 profiles/package.mask | 12 ------------
 1 file changed, 12 deletions(-)