Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 672226 - dev-util/electron-2.0.10 - ../../media/ffmpeg/ffmpeg_common.cc:36:46: error: ‘FF_INPUT_BUFFER_PADDING_SIZE’ was not declared in this scope
Summary: dev-util/electron-2.0.10 - ../../media/ffmpeg/ffmpeg_common.cc:36:46: error: ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Elvis Pranskevichus
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2018-11-29 09:46 UTC by Leonid Kopylov
Modified: 2019-06-09 15:13 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,256.25 KB, application/x-xz)
2018-11-29 09:47 UTC, Leonid Kopylov
Details
FF_INPUT_BUFFER_PADDING_SIZE patch (electron-2.0.14-ffmpeg_common.cc-AV_INPUT_BUFFER_PADDING_SIZE.diff,1.90 KB, patch)
2018-11-29 10:13 UTC, Reinis Danne
Details | Diff
Increase kPaddingSize to match AV_INPUT_BUFFER_PADDING_SIZE (electron-2.0.14-decoder_buffer.h-kPaddingSize.diff,368 bytes, patch)
2018-11-29 21:44 UTC, Reinis Danne
Details | Diff
AV_CODEC_CAP_DR1 patch (electron-2.0.14-ffmpeg_audio_decoder.cc-AV_CODEC_CAP_DR1.diff,610 bytes, patch)
2018-11-29 21:45 UTC, Reinis Danne
Details | Diff
AV_CODEC_FLAG2_CHUNKS patch (electron-2.0.14-ffmpeg_video_decoder.cc-AV_CODEC_FLAG2_CHUNKS.diff,512 bytes, patch)
2018-11-29 21:47 UTC, Reinis Danne
Details | Diff
ffmpeg_video_decoder.cc CODEC_FLAG_EMU_EDGE patch (electron-2.0.14-ffmpeg_video_decoder.cc-CODEC_FLAG_EMU_EDGE.diff,471 bytes, patch)
2018-11-29 21:48 UTC, Reinis Danne
Details | Diff
ffmpeg_cdm_video_decoder.cc CODEC_FLAG_EMU_EDGE patch (electron-2.0.14-ffmpeg_cdm_video_decoder.cc-CODEC_FLAG_EMU_EDGE.diff,520 bytes, patch)
2018-11-29 21:50 UTC, Reinis Danne
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leonid Kopylov 2018-11-29 09:46:33 UTC
# emerge -pqv '=dev-util/electron-2.0.10::gentoo'
[ebuild  N    ] dev-util/electron-2.0.10  USE="cups gnome-keyring kerberos proprietary-codecs pulseaudio system-ffmpeg tcmalloc -custom-cflags -gconf -lto (-neon) -pic (-selinux) -test" L10N="he ru -am -ar -bg -bn -ca -cs -da -de -el -en-GB -es -es-419 -et -fa -fi -fil -fr -gu -hi -hr -hu -id -it -ja -kn -ko -lt -lv -ml -mr -ms -nb -nl -pl -pt-BR -pt-PT -ro -sk -sl -sr -sv -sw -ta -te -th -tr -uk -vi -zh-CN -zh-TW"

# emerge --info '=dev-util/electron-2.0.10::gentoo'
Portage 2.3.52 (python 3.6.6-final-0, default/linux/amd64/17.1/desktop/gnome/systemd, gcc-8.2.0, glibc-2.28-r2, 4.19.5-gentoo x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-4.19.5-gentoo-x86_64-Intel-R-_Core-TM-_i7-6700_CPU_@_3.40GHz-with-gentoo-2.6
KiB Mem:     8170548 total,   1950352 free
KiB Swap:    4194300 total,   4152048 free
Timestamp of repository gentoo: Thu, 29 Nov 2018 08:00:01 +0000
Head commit of repository gentoo: 6ef24d789bb0fe9b22207d13793df4720d24fd41
sh bash 4.4_p23
ld GNU ld (Gentoo 2.31.1 p3) 2.31.1
app-shells/bash:          4.4_p23::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.26.2::gentoo
dev-lang/python:          2.7.15::gentoo, 3.6.6::gentoo, 3.7.0::gentoo
dev-util/cmake:           3.13.0::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.11.6-r3::gentoo, 1.16.1-r1::gentoo
sys-devel/binutils:       2.31.1-r1::gentoo
sys-devel/gcc:            8.2.0-r4::gentoo
sys-devel/gcc-config:     2.0::gentoo
sys-devel/libtool:        2.4.6-r5::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 4.19::gentoo (virtual/os-headers)
sys-libs/glibc:           2.28-r2::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-extra-opts:
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-jobs: 1

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA google-chrome PUEL RAR Nero-EULA-US OPERA-2014 skype-4.0.0.7-copyright TeamViewer"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe -fomit-frame-pointer"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php7.2/ext-active/ /etc/php/cgi-php7.2/ext-active/ /etc/php/cli-php7.2/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=native -O2 -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://mirror.isoc.org.il/pub/gentoo/"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en he ru en_US he_IL ru_RU"
MAKEOPTS="-j5"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac accessibility acl acpi alsa amd64 anacron berkdb bluetooth branding bzip2 cairo cdda cdio cdr cli client colord crypt cryptsetup cups curl cxx dbus device-mapper doc dot dri dts dvd dvdr eds emboss encode evo examples exif experimental fam flac fontconfig fortran gd gdbm geoip gif glamor gles gnome gnome-keyring gnome-online-accounts go googledrive gpg gpm gstreamer gtk html http iconv icu idn introspection ipv6 iscsi jadetex java jpeg jpeg2k kerberos latex lcms ldap libkms libnotify libsecret libtirpc logrotate mad math mbox mdadm minizip mng mount mp3 mp4 mpeg mpx multilib multimon mysql mysqli nautilus ncurses networkmanager nls nptl nscd offensive ogg opengl openmp pam pango pcap pcre pdf pdfimport perl png policykit postgres postproc ppds pulseaudio python qrcode qt5 raw readline samba sasl sdl seccomp slp spell sqlite ssl startup-notification svg symlink sync-plugin-portage systemd tcpd threads tiff tk tools tracker truetype udev udisks unicode upower usb vala vlc vorbis wayland wifi wininst wxwidgets x264 xa xattr xcb xinerama xkb xml xv xvid zlib" ABI_X86="64 32" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon plan sheets stage words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="evdev" KERNEL="linux" L10N="en en-US he ru" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="nlpsolver scripting-beanshell wiki-publisher scripting-javascript" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-1" POSTGRES_TARGETS="postgres9_5 postgres10" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6" RUBY_TARGETS="ruby23 ruby24" USERLAND="GNU" VIDEO_CARDS="vmware" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Leonid Kopylov 2018-11-29 09:47:10 UTC
Created attachment 556656 [details]
build.log.xz
Comment 2 Reinis Danne 2018-11-29 10:13:40 UTC
Created attachment 556658 [details, diff]
FF_INPUT_BUFFER_PADDING_SIZE patch
Comment 3 Reinis Danne 2018-11-29 21:44:36 UTC
Created attachment 556730 [details, diff]
Increase kPaddingSize to match AV_INPUT_BUFFER_PADDING_SIZE
Comment 4 Reinis Danne 2018-11-29 21:45:51 UTC
Created attachment 556732 [details, diff]
AV_CODEC_CAP_DR1 patch
Comment 5 Reinis Danne 2018-11-29 21:47:03 UTC
Created attachment 556734 [details, diff]
AV_CODEC_FLAG2_CHUNKS patch
Comment 6 Reinis Danne 2018-11-29 21:48:05 UTC
Created attachment 556736 [details, diff]
ffmpeg_video_decoder.cc CODEC_FLAG_EMU_EDGE patch
Comment 7 Reinis Danne 2018-11-29 21:50:56 UTC
Created attachment 556738 [details, diff]
ffmpeg_cdm_video_decoder.cc CODEC_FLAG_EMU_EDGE patch

These last two assume that video buffers have been allocated by get_buffer2().

https://ffmpeg.org/pipermail/ffmpeg-cvslog/2014-January/073339.html
Comment 8 N. Andrew Walsh 2018-11-30 11:27:37 UTC
I just ran into this same error with electron-2.0.14. Will these patches help there as well?
Comment 9 Reinis Danne 2018-11-30 11:59:27 UTC
(In reply to N. Andrew Walsh from comment #8)
> I just ran into this same error with electron-2.0.14. Will these patches
> help there as well?

Yes. I have used them only with electron-2.0.14 and ffmpeg-4.1.
Comment 10 Kjell Claesson 2018-11-30 14:45:27 UTC
Thank you Reinis.

Works like a charm, compiled atom overlay with the patches.

//Kjell
Comment 11 Elvis Pranskevichus 2018-11-30 21:34:32 UTC
Thanks for coming up with the patches Reinis!  I'll roll these into the overlay version and post a main tree bump soon.
Comment 12 N. Andrew Walsh 2018-12-02 17:08:09 UTC
(In reply to Reinis Danne from comment #9)
> (In reply to N. Andrew Walsh from comment #8)
> > I just ran into this same error with electron-2.0.14. Will these patches
> > help there as well?
> 
> Yes. I have used them only with electron-2.0.14 and ffmpeg-4.1.

These patches resolved my issue, cured my depression, made me more appealing to my romantic partner, etc.

Thanks!
Comment 13 Ole Langbehn 2018-12-09 12:42:41 UTC
@elvis Have you rolled these patches out to any overlay? This still happens in the main tree, and also in the ebuild for electron-2.0.14 from the atom overlay.
Comment 14 Elvis Pranskevichus 2018-12-10 16:15:44 UTC
Not yet, I'll look into it this week.
Comment 15 Max Steel 2019-01-13 23:19:49 UTC
Any further Development, here?
Comment 16 Max Steel 2019-01-13 23:45:22 UTC
And i got something stuck in my head... should this patch be upstream?...
Comment 17 Leonid Kopylov 2019-01-30 18:15:50 UTC
Any news on this?
Comment 18 Elvis Pranskevichus 2019-02-02 21:41:37 UTC
I pushed the updated version with the fixes to the atom overlay.  A PR is pending to get this into the main tree.
Comment 19 Larry the Git Cow gentoo-dev 2019-03-04 01:35:54 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e2d5c56450b953372bcff4792994a9df3665c66d

commit e2d5c56450b953372bcff4792994a9df3665c66d
Author:     Elvis Pranskevichus <elvis@magic.io>
AuthorDate: 2019-02-02 21:26:46 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2019-03-04 01:35:03 +0000

    dev-util/electron: Version bump to 2.0.17
    
    Closes: https://bugs.gentoo.org/672226
    Bug: https://bugs.gentoo.org/675578
    Signed-off-by: Elvis Pranskevichus <elvis@magic.io>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11
    Closes: https://github.com/gentoo/gentoo/pull/10966
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 dev-util/electron/Manifest               |   3 +
 dev-util/electron/electron-2.0.17.ebuild | 909 +++++++++++++++++++++++++++++++
 2 files changed, 912 insertions(+)
Comment 20 Leonid Kopylov 2019-06-09 15:13:57 UTC
any news on this? i still not able to emerge this