Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 671882 - x11-libs/libfm-qt uses private Qt headers, lacks slot operator (was: x11-misc/pcmanfm-qt, media-gfx/lximage-qt: segfault after update to Qt-5.11.1)
Summary: x11-libs/libfm-qt uses private Qt headers, lacks slot operator (was: x11-misc...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal
Assignee: LxQt maintainers
URL:
Whiteboard:
Keywords: NeedPatch, PullRequest
Depends on:
Blocks:
 
Reported: 2018-11-25 17:54 UTC by Michał Dec
Modified: 2018-12-22 11:43 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info dev-qt/qtcore (qtcore_info,9.57 KB, text/plain)
2018-11-25 17:54 UTC, Michał Dec
Details
lximage-qt's segfault caught in gdb (lximage-qt in gdb,4.59 KB, text/plain)
2018-11-25 17:55 UTC, Michał Dec
Details
offending file in dev-qt/qtcore (qsharedpointer.cpp,60.40 KB, text/x-c++src)
2018-11-25 17:57 UTC, Michał Dec
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Dec 2018-11-25 17:54:38 UTC
Created attachment 556252 [details]
emerge --info dev-qt/qtcore

After updating, I've noticed that lximage-qt and pcmanfm-qt segfault.

lximage-qt will segfault when:
- you try to make a screenshot
- you attempt any interaction if it makes a screenshot without segfaulting

pcmanfm-qt will segfault when:
- you try to interact with the open window in any way

For this reason I believe that dev-qt/qtcore:5/5.11 should still be masked, and it its stead 5.9 should be unmasked.

After further poking around, I've noticed, that if I click the wallpaper on my LXQt desktop enough times, it will eventually crash the LXQt session. This is everything except stable.
Comment 1 Michał Dec 2018-11-25 17:55:48 UTC
Created attachment 556254 [details]
lximage-qt's segfault caught in gdb
Comment 2 Michał Dec 2018-11-25 17:57:36 UTC
Created attachment 556256 [details]
offending file in dev-qt/qtcore
Comment 3 Michał Dec 2018-11-25 17:59:11 UTC
(In reply to moog621 from comment #0)
> For this reason I believe that dev-qt/qtcore:5/5.11 should still be masked,
> and it its stead 5.9 should be unmasked.
I meant to say "in its stead".
Comment 4 Andreas Sturmlechner gentoo-dev 2018-11-25 18:04:42 UTC
Those should really be individual bugs against media-gfx/lximage-qt and x11-misc/pcmanfm-qt instead.
Comment 5 Chiitoo gentoo-dev 2018-11-25 22:25:40 UTC
Thanks for the report!

If you haven't yet, please try rebuilding 'x11-libs/libfm-qt' to see if that helps (this usually helps with 'x11-misc/pcmanfm-qt' issues such as this).

I haven't bumped into such an issue with 'media-gfx/lximage-qt', but I don't use it for screenshots.  Could be a similar root cause though.

I just tested on a stable-testing machine, and can't reproduce currently.
Comment 6 Michał Dec 2018-11-25 22:44:36 UTC
(In reply to Chiitoo from comment #5)
> If you haven't yet, please try rebuilding 'x11-libs/libfm-qt' to see if that
> helps (this usually helps with 'x11-misc/pcmanfm-qt' issues such as this).

Thank you so much! This fixed the problem.
Comment 7 Andreas Sturmlechner gentoo-dev 2018-11-29 23:41:44 UTC
Thanks for checking back, does not mean this bug is fixed though.


Quick grep over libfm-qt-0.13.1 sources:

> src/xdndworkaround.cpp:#include <private/qdnd_p.h>
> // Too bad that we need to use private headers of Qt :-(

Private header from dev-qt/qtgui:5, so libfm-qt should gain a slot operator there for rebuild qtgui upgrade.
Comment 8 Larry the Git Cow gentoo-dev 2018-12-22 11:43:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=15a0b7b804a24fc1e1d372caa1061b58297ff99a

commit 15a0b7b804a24fc1e1d372caa1061b58297ff99a
Author:     Jimi Huotari <chiitoo@gentoo.org>
AuthorDate: 2018-12-20 19:46:16 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-12-22 11:43:26 +0000

    x11-libs/libfm-qt: add slot operator for 'qtgui'
    
    Closes: https://bugs.gentoo.org/671882
    Signed-off-by: Jimi Huotari <chiitoo@gentoo.org>
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Closes: https://github.com/gentoo/gentoo/pull/10670
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 x11-libs/libfm-qt/libfm-qt-0.13.1-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)