Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 671522 - app-misc/pax-utils: lddtree is broken with Python 3.7
Summary: app-misc/pax-utils: lddtree is broken with Python 3.7
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sergei Trofimovich (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-19 16:50 UTC by Oleksandr Natalenko
Modified: 2019-01-14 23:07 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix (0001-lddtree.py-use-errno-properly.patch,876 bytes, patch)
2018-11-19 16:50 UTC, Oleksandr Natalenko
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oleksandr Natalenko 2018-11-19 16:50:02 UTC
Created attachment 555724 [details, diff]
Fix

If using lddtree with --copy-to-tree and Python 3.7, it fails:

===
File "/bin/lddtree", line 125, in makedirs
if e.errno != os.errno.EEXIST:
AttributeError: module 'os' has no attribute 'errno'
===

This is because "os.errno" was removed in Python 3.7 [1]. Instead, just "errno" should be used [2].

I've mailed the fix to Mike, but so far got no response. So, creating a bug to track this.

The fix is attached too.

[1] https://bugs.python.org/issue33666
[2] https://python.readthedocs.io/en/latest/library/errno.html
Comment 1 Sergei Trofimovich (RETIRED) gentoo-dev 2018-11-19 22:10:33 UTC
Thanks for the detailed bug report!
Comment 2 Larry the Git Cow gentoo-dev 2018-11-19 22:20:20 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/pax-utils.git/commit/?id=2acc5c3278354f56c70f9f48e66eb0203d5e8370

commit 2acc5c3278354f56c70f9f48e66eb0203d5e8370
Author:     Oleksandr Natalenko <oleksandr@natalenko.name>
AuthorDate: 2018-11-17 14:43:09 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2018-11-19 22:19:54 +0000

    lddtree.py: use errno properly
    
    os.errno interface is removed [1], thus should not be used. In fact, it
    is not used in other places of lddtree.py, so fix this one too, because
    it breaks --copy-to-tree on systems with Python 3.7.
    
    [1] https://bugs.python.org/issue33666
    
    Bug: https://bugs.gentoo.org/671522
    Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name>
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 lddtree.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 Larry the Git Cow gentoo-dev 2018-11-24 19:54:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0f69a565612708062ba66583780bb3fb606e503a

commit 0f69a565612708062ba66583780bb3fb606e503a
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2018-11-24 19:53:38 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2018-11-24 19:54:02 +0000

    app-misc/pax-utils: backport python-3.7 support, bug #671522
    
    Fix by Oleksandr Natalenko:
    
    lddtree.py: use errno properly
    
    os.errno interface is removed [1], thus should not be used. In fact, it
    is not used in other places of lddtree.py, so fix this one too, because
    it breaks --copy-to-tree on systems with Python 3.7.
    
    [1] https://bugs.python.org/issue33666
    
    Closes: https://bugs.gentoo.org/671522
    Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name>
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 .../files/pax-utils-1.2.3-python-3.7.patch         | 32 ++++++++++
 app-misc/pax-utils/pax-utils-1.2.3-r3.ebuild       | 74 ++++++++++++++++++++++
 2 files changed, 106 insertions(+)
Comment 4 Larry the Git Cow gentoo-dev 2019-01-14 23:07:20 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e0f669f55fce79532270330064564c65c4e6d378

commit e0f669f55fce79532270330064564c65c4e6d378
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2019-01-14 23:05:49 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2019-01-14 23:07:04 +0000

    app-misc/pax-utils: bump up to 1.2.4
    
    Two main fixes since main release:
    - Python 3.7 support
    - better fakeroot cooperation on powerpc and others
    
    Bug: https://bugs.gentoo.org/671522
    Bug: https://bugs.gentoo.org/675378
    Package-Manager: Portage-2.3.55, Repoman-2.3.12
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 app-misc/pax-utils/Manifest               |  1 +
 app-misc/pax-utils/pax-utils-1.2.4.ebuild | 70 +++++++++++++++++++++++++++++++
 2 files changed, 71 insertions(+)