Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 671466 - dev-python/toml-0.9.6: test support in ebuild is completely wrong
Summary: dev-python/toml-0.9.6: test support in ebuild is completely wrong
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Patrice Clement
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-18 19:49 UTC by Michał Górny
Modified: 2018-11-18 20:22 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-11-18 19:49:29 UTC
1. The ebuild specifies random wrong test dependencies including circular dep with dev-py/tox which isn't used at all,

2. The code runs 'setup.py test' the wrong way but it doesn't really matter,

because there are no tests actually run, e.g.:

* python2_7: running distutils-r1_run_phase python_test
running test
running egg_info
writing toml.egg-info/PKG-INFO
writing top-level names to toml.egg-info/top_level.txt
writing dependency_links to toml.egg-info/dependency_links.txt
reading manifest file 'toml.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'toml.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK


Which means it's yet another package where Patrice added random stuff and didn't test it.  Given his repeated carelessness, I'd like to ask Patrice to leave the Python team.
Comment 1 Larry the Git Cow gentoo-dev 2018-11-18 20:22:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9d4a09a8c6f9b0d10fef4a9ad793c2ea3c89365b

commit 9d4a09a8c6f9b0d10fef4a9ad793c2ea3c89365b
Author:     Patrice Clement <monsieurp@gentoo.org>
AuthorDate: 2018-11-18 20:21:28 +0000
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: 2018-11-18 20:22:43 +0000

    dev-python/toml: remove test support.
    
    Feel free to add it back if necessary.
    
    Closes: https://bugs.gentoo.org/671466
    Signed-off-by: Patrice Clement <monsieurp@gentoo.org>
    Package-Manager: Portage-2.3.49, Repoman-2.3.11

 dev-python/toml/toml-0.9.6.ebuild | 14 +++-----------
 1 file changed, 3 insertions(+), 11 deletions(-)