Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 671436 - sys-firmware/intel-microcode: The ebuild is installing to one or more unexpected paths
Summary: sys-firmware/intel-microcode: The ebuild is installing to one or more unexpec...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal QA
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2018-11-18 15:39 UTC by Pacho Ramos
Modified: 2018-12-16 23:19 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2018-11-18 15:39:09 UTC
I get;
QA: other
The ebuild is installing to one or more unexpected paths:

  /tmp

Please fix the ebuild to use correct FHS/Gentoo policy paths.


Thanks
Comment 1 Thomas Deutschmann (RETIRED) gentoo-dev 2018-11-18 16:10:51 UTC
Nothing to fix: This is a false positive.

Yes, we store files in /tmp in src_install. But this is required to allow binary package user to only install ucode(s) supported by the real system (see USE=hostonly).

Later in pkg_preinst we will make sure that "$ED/tmp" won't be merged to user's system.

Of course we could move this temporary directory somewhere else to silence the QA warning but this wouldn't be correct because this would hide the fact that we use a temporary location on purpose in the image. Maybe the QA check should offer a variable to override this check like we can do for pre compiled or stripped binaries.
Comment 2 Mike Gilbert gentoo-dev 2018-11-18 18:36:10 UTC
Leaving the ebuild as-is will result in a steady stream of duplicate bug reports.

I don't really understand the need for a temporary location at all. I suggest installing the files to ${ED}/lib/firmware in src_install, and removing them if necessary in pkg_preinst.
Comment 3 Thomas Deutschmann (RETIRED) gentoo-dev 2018-11-18 21:16:24 UTC
(In reply to Mike Gilbert from comment #2)
> I don't really understand the need for a temporary location at all. I
> suggest installing the files to ${ED}/lib/firmware in src_install, and
> removing them if necessary in pkg_preinst.

iucode_tool needs one folder to read from and one folder to write to. This cannot be the same folder.
Comment 4 Larry the Git Cow gentoo-dev 2018-12-16 23:19:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e6ade8189bb6037cf298ed70889f15cfcd0a0a00

commit e6ade8189bb6037cf298ed70889f15cfcd0a0a00
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2018-12-16 23:17:46 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2018-12-16 23:18:13 +0000

    sys-firmware/intel-microcode: bump
    
    - Updated microcodes:
    
      sig 0x00050653, pf_mask 0x97, 2018-04-20, rev 0x1000144 -> 2018-08-24, rev 0x1000146
      sig 0x00050654, pf_mask 0xb7, 2018-08-09, rev 0x2000050 -> 2018-10-08, rev 0x2000055
      sig 0x00050655, pf_mask 0xb7, 2018-04-27, rev 0x300000b -> 2018-06-15, rev 0x300000d
    
    - Ebuild changes:
    
    In addition to the updated microcodes, the package now avoids using
    a temp directory for install.
    
    Instead it creates a temp directory in pkg_preinst if necessary. This
    should only be needed when the 'hostonly' USE flag is enabled.
    
    Closes: https://github.com/gentoo/gentoo/pull/10461
    Closes: https://bugs.gentoo.org/671436
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 sys-firmware/intel-microcode/Manifest              |   1 +
 .../intel-microcode-20180807a_p20181215.ebuild     | 239 +++++++++++++++++++++
 2 files changed, 240 insertions(+)