671082 – x11-terms/alacritty-0.2.2: install icon

Bug 671082 - x11-terms/alacritty-0.2.2: install icon

Summary: x11-terms/alacritty-0.2.2: install icon

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Georgy Yakovlev

URL:	https://github.com/jwilm/alacritty/is...
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2018-11-13 15:02 UTC by haarp
Modified:	2018-11-14 10:06 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description haarp 2018-11-13 15:02:25 UTC

The archive carries the new icon in alacritty-0.2.2/assets/windows/alacritty.ico. ico is an inferior format, but should work fine.

Thanks!

Comment 1 Georgy Yakovlev archtester

2018-11-14 01:00:00 UTC

Thanks for reporting that.

I've linked upstream issue, linux svg icon is not finalized yet, but we can try use that converted ico->png for now.

Comment 2 Larry the Git Cow gentoo-dev

2018-11-14 01:03:16 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7116dd559e585e025769e9d3560923654c09ba05

commit 7116dd559e585e025769e9d3560923654c09ba05
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2018-11-14 00:19:52 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2018-11-14 01:02:43 +0000

    x11-terms/alacritty: version bump to 0.2.3
    
    Upstream fixed ouse cursor alignment issues and
    truncated last line caused by incorrect padding calculations
    Added converted windows icon, will switch to svg once it's ready.
    
    Closes: https://bugs.gentoo.org/671082
    Package-Manager: Portage-2.3.51, Repoman-2.3.12
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 x11-terms/alacritty/Manifest                       |   7 +
 x11-terms/alacritty/alacritty-0.2.3.ebuild         | 379 +++++++++++++++++++++
 ...-0.2.3-avoid-fetching-custom-windows-deps.patch |  74 ++++
 3 files changed, 460 insertions(+)

Comment 3 Georgy Yakovlev archtester

2018-11-14 01:09:58 UTC

actually it looks just fine even on 4k display =D
enjoy 0.2.3, it has an icon and a serious bug fixed.

Comment 4 haarp 2018-11-14 10:06:50 UTC

Excellent, thanks!