Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 671028 - app-misc/lcdproc-0.5.9: rekeyword ~ppc64
Summary: app-misc/lcdproc-0.5.9: rekeyword ~ppc64
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Keywording (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Conrad Kostecki
URL:
Whiteboard:
Keywords: KEYWORDREQ, PullRequest
Depends on:
Blocks:
 
Reported: 2018-11-12 22:36 UTC by Conrad Kostecki
Modified: 2020-02-06 09:43 UTC (History)
1 user (show)

See Also:
Package list:
app-misc/lcdproc-0.5.9 ~ppc64 dev-libs/serdisplib-2.01 ~ppc64 x11-libs/libdlo-0.1.2-r1 ~ppc64
Runtime testing required: No
stable-bot: sanity-check+


Attachments
build.log (graphlcd-base-0.1.9) (graphlcd-base-0.1.9:20181116-120933.log,9.95 KB, text/plain)
2018-11-16 12:14 UTC, ernsteiswuerfel
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Conrad Kostecki gentoo-dev 2018-11-12 22:36:07 UTC
I would like to readd ~ppc64 keyword for latest app-misc/lcdproc.
Comment 1 Stabilization helper bot gentoo-dev 2018-11-15 15:01:03 UTC
An automated check of this bug failed - the following atom is unknown:

app-misc/lcdproc

Please verify the atom list.
Comment 2 Stabilization helper bot gentoo-dev 2018-11-15 17:01:36 UTC
An automated check of this bug failed - repoman reported dependency errors (9 lines truncated): 

> dependency.bad app-misc/lcdproc/lcdproc-0.5.9.ebuild: DEPEND: ~ppc64(default/linux/powerpc/ppc64/17.0/64bit-userland) ['app-misc/glcdprocdriver:=', 'dev-libs/serdisplib:=']
> dependency.bad app-misc/lcdproc/lcdproc-0.5.9.ebuild: RDEPEND: ~ppc64(default/linux/powerpc/ppc64/17.0/64bit-userland) ['app-misc/glcdprocdriver:=', 'dev-libs/serdisplib:=']
> dependency.bad app-misc/lcdproc/lcdproc-0.5.9.ebuild: DEPEND: ~ppc64(default/linux/powerpc/ppc64/17.0/64bit-userland/desktop) ['app-misc/glcdprocdriver:=', 'dev-libs/serdisplib:=']
Comment 3 Stabilization helper bot gentoo-dev 2018-11-15 18:20:45 UTC
An automated check of this bug failed - repoman reported dependency errors (18 lines truncated): 

> dependency.bad app-misc/glcdprocdriver/glcdprocdriver-0.0.6.ebuild: DEPEND: ~ppc64(default/linux/powerpc/ppc64/17.0/64bit-userland) ['>=app-misc/graphlcd-base-0.1.3']
> dependency.bad app-misc/glcdprocdriver/glcdprocdriver-0.0.6.ebuild: RDEPEND: ~ppc64(default/linux/powerpc/ppc64/17.0/64bit-userland) ['>=app-misc/graphlcd-base-0.1.3']
> dependency.bad app-misc/glcdprocdriver/glcdprocdriver-0.0.6.ebuild: DEPEND: ~ppc64(default/linux/powerpc/ppc64/17.0/64bit-userland/desktop) ['>=app-misc/graphlcd-base-0.1.3']
> dependency.bad dev-libs/serdisplib/serdisplib-2.01.ebuild: DEPEND: ~ppc64(default/linux/powerpc/ppc64/17.0/64bit-userland) ['x11-libs/libdlo']
> dependency.bad dev-libs/serdisplib/serdisplib-2.01.ebuild: RDEPEND: ~ppc64(default/linux/powerpc/ppc64/17.0/64bit-userland) ['x11-libs/libdlo']
> dependency.bad dev-libs/serdisplib/serdisplib-2.01.ebuild: DEPEND: ~ppc64(default/linux/powerpc/ppc64/17.0/64bit-userland/desktop) ['x11-libs/libdlo']
Comment 4 ernsteiswuerfel archtester 2018-11-16 12:14:16 UTC
Created attachment 555302 [details]
build.log (graphlcd-base-0.1.9)

graphlcd-base-0.1.9 shows a build failure on ppc64.
Comment 5 Conrad Kostecki gentoo-dev 2018-11-16 12:20:53 UTC
(In reply to ernsteiswuerfel from comment #4)
> Created attachment 555302 [details]
> build.log (graphlcd-base-0.1.9)
> 
> graphlcd-base-0.1.9 shows a build failure on ppc64.

Could you try, if 1.0.1 works?
That's currently not in portage, but filled PR by me:
https://github.com/gentoo/gentoo/pull/10096

And for that, you need also the updated glcdprocdriver.
-> https://github.com/gentoo/gentoo/pull/10097

Thanks!
Comment 6 Conrad Kostecki gentoo-dev 2019-07-21 21:33:26 UTC
I will mask lcd_devices_glcd on ppc*, since it's not compatible anymore.
Comment 7 Larry the Git Cow gentoo-dev 2019-08-02 05:38:03 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ab777a47b2c306df7541c910a0aa265ff20ccf40

commit ab777a47b2c306df7541c910a0aa265ff20ccf40
Author:     Conrad Kostecki <conrad@kostecki.com>
AuthorDate: 2019-08-01 17:41:36 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2019-08-02 05:34:51 +0000

    profiles: mask glcd lcd driver for app-misc/lcdproc on ppc64
    
    Bug: https://bugs.gentoo.org/671028
    Signed-off-by: Conrad Kostecki <conrad@kostecki.com>
    Closes: https://github.com/gentoo/gentoo/pull/12507
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 profiles/arch/powerpc/ppc64/package.use.mask | 4 ++++
 1 file changed, 4 insertions(+)
Comment 8 Stabilization helper bot gentoo-dev 2019-08-08 09:00:26 UTC
An automated check of this bug failed - repoman reported dependency errors (7 lines truncated): 

> dependency.bad dev-libs/serdisplib/serdisplib-2.01.ebuild: DEPEND: ~ppc64(default/linux/powerpc/ppc64/17.0/64bit-userland) ['x11-libs/libdlo']
> dependency.bad dev-libs/serdisplib/serdisplib-2.01.ebuild: RDEPEND: ~ppc64(default/linux/powerpc/ppc64/17.0/64bit-userland) ['x11-libs/libdlo']
> dependency.bad dev-libs/serdisplib/serdisplib-2.01.ebuild: DEPEND: ~ppc64(default/linux/powerpc/ppc64/17.0/64bit-userland/desktop) ['x11-libs/libdlo']
Comment 9 Conrad Kostecki gentoo-dev 2019-08-08 16:27:36 UTC
@ernsteiswuerfel: With the mask of glcd, could you try, if the rest works for ~ppc64?
Comment 10 ernsteiswuerfel archtester 2019-08-08 22:48:24 UTC
Some USE-flags of =app-misc/lcdproc-0.5.9 still pull glcd in, e.g.
png? ( lcd_devices_glcd )
freetype? ( lcd_devices_glcd )
Comment 11 Conrad Kostecki gentoo-dev 2019-08-09 10:02:34 UTC
Thanks for the hint.

(In reply to ernsteiswuerfel from comment #10)
> Some USE-flags of =app-misc/lcdproc-0.5.9 still pull glcd in, e.g.
> png? ( lcd_devices_glcd )
> freetype? ( lcd_devices_glcd )

Could you test with both use flags masked for ppc/ppc64?
Comment 12 ernsteiswuerfel archtester 2019-08-11 19:00:13 UTC
With png and freetype masked now only 2 builds fail:

# grep -i fail lcdproc-671028.report 
USE='lcd_devices_acoolsdcm -lcd_devices_ddusbt -lcd_devices_directgfx -lcd_devices_displaylink lcd_devices_framebuffer -lcd_devices_glcd2usb lcd_devices_goldelox -lcd_devices_i2c lcd_devices_ks0108 -lcd_devices_l4m -lcd_devices_lc7981 -lcd_devices_lh155 lcd_devices_nokcol lcd_devices_pcd8544 -lcd_devices_remote lcd_devices_rs232 lcd_devices_sed133x -lcd_devices_sed153x -lcd_devices_sed156x -lcd_devices_ssdoled -lcd_devices_stv8105 -threads tools' failed for =dev-libs/serdisplib-2.01
USE='lcd_devices_acoolsdcm lcd_devices_ddusbt -lcd_devices_directgfx -lcd_devices_displaylink lcd_devices_framebuffer -lcd_devices_glcd2usb -lcd_devices_goldelox -lcd_devices_i2c -lcd_devices_ks0108 lcd_devices_l4m -lcd_devices_lc7981 lcd_devices_lh155 -lcd_devices_nokcol lcd_devices_pcd8544 -lcd_devices_remote lcd_devices_rs232 lcd_devices_sed133x lcd_devices_sed153x lcd_devices_sed156x lcd_devices_ssdoled -lcd_devices_stv8105 -threads tools' failed for =dev-libs/serdisplib-2.01

[...]
serdisp_specific_rs232.c: In function ‘write_byte’:
serdisp_specific_rs232.c:82:5: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result]
     write(dd->sdcd->fd, &item, 1);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
serdisp_specific_framebuffer.c:115:3: error: unknown type name ‘SDTOUCH_idev_touchdevice_t’
   SDTOUCH_idev_touchdevice_t touchdev;   /* touch device */
   ^~~~~~~~~~~~~~~~~~~~~~~~~~
serdisp_specific_framebuffer.c: In function ‘serdisp_framebuffer_getvalueptr’:
serdisp_specific_framebuffer.c:137:66: error: request for member ‘swapx’ in something not a structure or union
     return &(serdisp_framebuffer_internal_getStruct(dd)->touchdev.swapx);
Comment 13 Conrad Kostecki gentoo-dev 2019-08-17 20:47:19 UTC
Thanks!
Could you give me the full build log for that cases? I will talk to upstream.

Thanks
Conrad
Comment 14 Conrad Kostecki gentoo-dev 2019-08-17 20:56:40 UTC
Nevermind, I found the cause. Framebuffer needs USE="threads".
Comment 15 Larry the Git Cow gentoo-dev 2019-08-18 13:11:54 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4320986837a6fb1091c7c8d7e79b8d5afac211c9

commit 4320986837a6fb1091c7c8d7e79b8d5afac211c9
Author:     Conrad Kostecki <conrad@kostecki.com>
AuthorDate: 2019-08-17 21:00:55 +0000
Commit:     Aaron Bauman <bman@gentoo.org>
CommitDate: 2019-08-18 13:11:28 +0000

    powerpc/package.use.mask: mask freetype and usb on ppc/ppc64
    
    Due masked glcd driver, some use flags needs also to be masked.
    
    Bug: https://bugs.gentoo.org/671028
    Signed-off-by: Conrad Kostecki <conrad@kostecki.com>
    Closes: https://github.com/gentoo/gentoo/pull/12737
    Signed-off-by: Aaron Bauman <bman@gentoo.org>

 profiles/arch/powerpc/package.use.mask | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 16 Conrad Kostecki gentoo-dev 2019-08-18 13:17:35 UTC
@ernsteiswuerfel: Since the updated mask and fixed threads for framebuffer is commited, could you run a test again? Thanks!
Comment 17 ernsteiswuerfel archtester 2019-08-20 12:42:46 UTC
The builds with the updated package.mask work fine now. The USE='-threads' issue is not solved, those still fail, e.g.

USE='lcd_devices_acoolsdcm -lcd_devices_ddusbt lcd_devices_directgfx -lcd_devices_displaylink lcd_devices_framebuffer lcd_devices_glcd2usb -lcd_devices_goldelox lcd_devices_i2c lcd_devices_ks0108 -lcd_devices_l4m -lcd_devices_lc7981 lcd_devices_lh155 lcd_devices_nokcol -lcd_devices_pcd8544 lcd_devices_remote -lcd_devices_rs232 lcd_devices_sed133x lcd_devices_sed153x -lcd_devices_sed156x lcd_devices_ssdoled -lcd_devices_stv8105 -threads tools'

USE='threads' is not enforced at least. But I don't know if it's only tatt insisting this should be build with USE='-threads'.
Comment 18 Conrad Kostecki gentoo-dev 2019-09-17 19:12:17 UTC
Hi!

(In reply to ernsteiswuerfel from comment #17)
> The builds with the updated package.mask work fine now. The USE='-threads'
> issue is not solved, those still fail, e.g.
> 
> USE='threads' is not enforced at least. But I don't know if it's only tatt
> insisting this should be build with USE='-threads'.

Could you pleave have a look, if you are using really serdisplib/serdisplib-2.01-r1?

I can't reproduce, I get the enforcement?

- dev-libs/serdisplib-2.01-r1::serenity USE="tools -threads" ABI_X86="(64)" LCD_DEVICES="acoolsdcm directgfx framebuffer glcd2usb i2c ks0108 lh155 nokcol remote sed133x sed153x ssdoled -ddusbt -displaylink -goldelox -l4m -lc7981 -pcd8544 -rs232 -sed156x -stv8105 -t6963"

  The following REQUIRED_USE flag constraints are unsatisfied:
    lcd_devices_framebuffer? ( threads )
Comment 19 ernsteiswuerfel archtester 2019-09-23 20:42:14 UTC
(In reply to Conrad Kostecki from comment #18)
> Could you pleave have a look, if you are using really
> serdisplib/serdisplib-2.01-r1?
Ah yes, that was the problem... Sorry! As this bug still got dev-libs/serdisplib-2.01 in the Package list I missed the -r1 at re-adding the bug with tatt.

dev-libs/serdisplib-2.01-r1 works as intended.
Comment 20 Conrad Kostecki gentoo-dev 2019-09-23 20:56:14 UTC
Great, many thanks :-)
Comment 21 Larry the Git Cow gentoo-dev 2019-11-08 02:56:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=afd5dfe01c88b6862722175f2fff19b5ba27a031

commit afd5dfe01c88b6862722175f2fff19b5ba27a031
Author:     Conrad Kostecki <conrad@kostecki.com>
AuthorDate: 2019-10-04 19:24:28 +0000
Commit:     Aaron Bauman <bman@gentoo.org>
CommitDate: 2019-11-08 02:55:52 +0000

    app-misc/lcdproc: readd ~ppc64 keyword
    
    Thanks to the hard work of ernsteiswuerfel, we can finally readd the
    ~ppc64 keyword to app-misc/lcdproc, as all tests passed.
    
    Closes: https://bugs.gentoo.org/671028
    Package-Manager: Portage-2.3.76, Repoman-2.3.17
    Signed-off-by: Conrad Kostecki <conrad@kostecki.com>
    Closes: https://github.com/gentoo/gentoo/pull/13023
    Signed-off-by: Aaron Bauman <bman@gentoo.org>

 app-misc/lcdproc/lcdproc-0.5.9.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8871bb72f3c91a972edeb222c71f21ac5a275b3f

commit 8871bb72f3c91a972edeb222c71f21ac5a275b3f
Author:     Conrad Kostecki <conrad@kostecki.com>
AuthorDate: 2019-10-04 19:07:01 +0000
Commit:     Aaron Bauman <bman@gentoo.org>
CommitDate: 2019-11-08 02:55:52 +0000

    dev-libs/serdisplib: add ~ppc64 keyword
    
    Thanks to ernsteiswuerfel, all tests passed to enable ~ppc64 keyword.
    It's a dep, which will be needed for app-misc/lcdproc on ~ppc64.
    
    Bug: https://bugs.gentoo.org/671028
    Package-Manager: Portage-2.3.76, Repoman-2.3.17
    Signed-off-by: Conrad Kostecki <conrad@kostecki.com>
    Signed-off-by: Aaron Bauman <bman@gentoo.org>

 dev-libs/serdisplib/serdisplib-2.01-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4365b1ba11d1596f2baaa75fe6f5981114abba78

commit 4365b1ba11d1596f2baaa75fe6f5981114abba78
Author:     Conrad Kostecki <conrad@kostecki.com>
AuthorDate: 2019-10-04 19:05:49 +0000
Commit:     Aaron Bauman <bman@gentoo.org>
CommitDate: 2019-11-08 02:55:51 +0000

    x11-libs/libdlo: add ~ppc64 keyword
    
    Thanks for ernsteiswuerfel, all tests passed on ~ppc64, so it can be
    keyworded as a dep for app-misc/lcdproc
    
    Bug: https://bugs.gentoo.org/671028
    Package-Manager: Portage-2.3.76, Repoman-2.3.17
    Signed-off-by: Conrad Kostecki <conrad@kostecki.com>
    Signed-off-by: Aaron Bauman <bman@gentoo.org>

 x11-libs/libdlo/libdlo-0.1.2-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)