Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 670806 - app-emulation/virtualbox-5.2.22: No more need to remove GCC version check and replace ECHO_N
Summary: app-emulation/virtualbox-5.2.22: No more need to remove GCC version check and...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Low minor
Assignee: Lars Wendler (Polynomial-C) (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-10 03:07 UTC by Leonid Bloch
Modified: 2018-11-16 14:48 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Leonid Bloch 2018-11-10 03:07:01 UTC
VirtualBox 5.2.22 no longer requires "gcc 4.x...7.x", but "gcc 4.x or later". So there is no more need to disable the GCC version check.

Also, replacing "ECHO_N" from "echo -n" to "printf" is no longer needed - it's "printf by default now.
Comment 1 Tomáš Mózes 2018-11-10 04:47:19 UTC
Have you please tested with latest gcc 8?
Comment 2 Leonid Bloch 2018-11-10 06:46:46 UTC
Tested with GCC 8.1.0.
Comment 3 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2018-11-16 14:04:57 UTC
The gcc version checks - by past experience - are subject to constant changes in VirtualBox so I won't remove our current gcc version check removal code.

Thanks for letting me know that upstream finally replaced "echo -n" with "printf". I gonna remove that sed statement in all ebuild.
Comment 4 Larry the Git Cow gentoo-dev 2018-11-16 14:48:16 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b036555114a203eb62490c56edb726c2d3999e85

commit b036555114a203eb62490c56edb726c2d3999e85
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2018-11-16 14:06:28 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2018-11-16 14:48:06 +0000

    app-emulation/virtualbox: removed "echo -n" replacement code
    
    as upstream finally replaced "echo -n" with "printf" in their configure
    script.
    
    Closes: https://bugs.gentoo.org/670806
    Package-Manager: Portage-2.3.51, Repoman-2.3.12
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 app-emulation/virtualbox/virtualbox-5.2.14-r1.ebuild | 5 +----
 app-emulation/virtualbox/virtualbox-5.2.20.ebuild    | 3 ---
 app-emulation/virtualbox/virtualbox-5.2.22.ebuild    | 3 ---
 3 files changed, 1 insertion(+), 10 deletions(-)