media-video/kino-1.3.4-r1 fails to compile with ffmpeg-4.1 patch is provided Reproducible: Always Steps to Reproduce: 1. emerge kino 2. 3. Actual Results: fails compilation with the new ffmpeg-4.1 (new constant definitions)
Created attachment 554506 [details, diff] fixes compilation of kino with ffmpeg-4.1 renames CODEC... into AV_CODEC...
Thanks, is this patch from upstream or already submitted to upstream?
(In reply to Andreas Sturmlechner from comment #2) > Thanks, is this patch from upstream or already submitted to upstream? kino project is dead upstream, but it is still useful. So upstream doesn't take new patches. We keep it alive in portage :-) The patch is similar to previous one for ffmpeg-3. Most of the name changeing for ffmpeg happened between 2 and 3 versions, but this seems to be another one that was not required for ffmpeg-3. I didn't check for more... Similar patch was also employed in the gst-plugins-libav
Tested the patch, I can confirm it applies cleanly and kino builds with ffmpeg 4.1 now. Added a PR: https://github.com/gentoo/gentoo/pull/10397
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9e7a311df544bb3ac6d2753b549f1d2732f50cac commit 9e7a311df544bb3ac6d2753b549f1d2732f50cac Author: Craig Andrews <candrews@gentoo.org> AuthorDate: 2018-11-12 03:59:26 +0000 Commit: Craig Andrews <candrews@gentoo.org> CommitDate: 2018-11-15 15:08:32 +0000 media-video/kino: ffmpeg 4 compatible Closes: https://bugs.gentoo.org/670660 Package-Manager: Portage-2.3.51, Repoman-2.3.12 Signed-off-by: Craig Andrews <candrews@gentoo.org> media-video/kino/files/kino-1.3.4-ffmpeg4.patch | 13 +++++++++++++ media-video/kino/kino-1.3.4-r1.ebuild | 3 ++- 2 files changed, 15 insertions(+), 1 deletion(-)
