Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 670270 - www-client/midori should not have IUSE=jit as it is not used directly
Summary: www-client/midori should not have IUSE=jit as it is not used directly
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: XFCE Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-04 13:50 UTC by Jeroen Roovers (RETIRED)
Modified: 2018-12-02 16:15 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeroen Roovers (RETIRED) gentoo-dev 2018-11-04 13:50:49 UTC
USE=jit for www-client/midori is exclusively used to set or unset the same USE flag on net-libs/webkit-gtk. This triggers all kinds of nastiness (pointlessly rebuilding midori when you toggle it, for instance) and is probably some kind of standards violation.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-11-04 15:23:24 UTC
Did you verify that the rebuild is indeed pointless and not actually necessary upon switching USE=jit?
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2018-11-04 15:52:15 UTC
(In reply to Michał Górny from comment #1)
> Did you verify that the rebuild is indeed pointless and not actually
> necessary upon switching USE=jit?

I did. USE=jit in net-libs/webkit-gtk sets some preprocessor defines in the ebuild and otherwise shouldn't affect ABI/API output (like header changes and such, but of course that might be mistaken). www-client/midori sources do not mention [Jj][Ii][Tt].
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-11-04 15:58:18 UTC
That's not what I was asking.  I was asking if you have tried rebuilding webkit-gtk upon installing midori in both directions, and have confirmed that midori works fine in both cases.
Comment 4 Larry the Git Cow gentoo-dev 2018-12-02 16:15:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=51e1a1112b3bca5bef16f7d23b7f78c1f92c41eb

commit 51e1a1112b3bca5bef16f7d23b7f78c1f92c41eb
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2018-12-02 16:13:45 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-12-02 16:15:01 +0000

    www-client/midori: Bump to 7.0
    
    Closes: https://bugs.gentoo.org/670192
    Closes: https://bugs.gentoo.org/670270
    Closes: https://bugs.gentoo.org/670354
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 www-client/midori/Manifest          |  1 +
 www-client/midori/midori-7.0.ebuild | 62 +++++++++++++++++++++++++++++++++++++
 2 files changed, 63 insertions(+)