Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 669926 - dev-python/ipython-5.8.0 should depend on dev-python/prompt_toolkit-1
Summary: dev-python/ipython-5.8.0 should depend on dev-python/prompt_toolkit-1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-29 16:44 UTC by Bernd Feige
Modified: 2018-11-20 13:47 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bernd Feige 2018-10-29 16:44:50 UTC
Currently unmasked dev-python/prompt_toolkit-2.0.6 breaks ipython hard:

Traceback (most recent call last):
  File "/usr/lib/python-exec/python3.6/ipython", line 4, in <module>
    from IPython import start_ipython
  File "/usr/lib64/python3.6/site-packages/IPython/__init__.py", line 49, in <module>
    from .terminal.embed import embed
  File "/usr/lib64/python3.6/site-packages/IPython/terminal/embed.py", line 18, in <module>
    from IPython.terminal.interactiveshell import TerminalInteractiveShell
  File "/usr/lib64/python3.6/site-packages/IPython/terminal/interactiveshell.py", line 20, in <module>
    from prompt_toolkit.shortcuts import create_prompt_application, create_eventloop, create_prompt_layout, create_output
ImportError: cannot import name 'create_prompt_application'

cf. https://github.com/ipython/ipython/pull/11177
also see the fix in Fedora: https://github.com/ipython/ipython/issues/11341
Comment 1 François Bissey 2018-10-30 07:57:49 UTC
I see this too. As reported in fedora ipython-5 as a line
'prompt_toolkit>=1.0.4,<2.0.0'
in setup.py and it is unlikely to change apparently.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-10-30 10:48:28 UTC
Mooonsieeeeurrpppp!!11111
Comment 3 Larry the Git Cow gentoo-dev 2018-11-06 20:05:44 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1f22b2eec0723c5359ec20c03bccf9fdc0d8510f

commit 1f22b2eec0723c5359ec20c03bccf9fdc0d8510f
Author:     Louis Sautier <sbraz@gentoo.org>
AuthorDate: 2018-11-06 19:56:07 +0000
Commit:     Louis Sautier <sbraz@gentoo.org>
CommitDate: 2018-11-06 20:03:50 +0000

    dev-python/ipython: enforce dependency on < prompt_toolkit-2
    
    Closes: https://bugs.gentoo.org/669926
    Signed-off-by: Louis Sautier <sbraz@gentoo.org>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11

 dev-python/ipython/ipython-5.4.1-r1.ebuild | 3 ++-
 dev-python/ipython/ipython-5.8.0.ebuild    | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)
Comment 4 Larry the Git Cow gentoo-dev 2018-11-11 12:29:19 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cc3e562c9c4519d755aa30da3e895dbdc7742dfa

commit cc3e562c9c4519d755aa30da3e895dbdc7742dfa
Author:     Louis Sautier <sbraz@gentoo.org>
AuthorDate: 2018-11-11 12:27:48 +0000
Commit:     Louis Sautier <sbraz@gentoo.org>
CommitDate: 2018-11-11 12:28:24 +0000

    dev-python/ipython: add missing revbump
    
    I didn't revbump in 1f22b2eec0723c5359ec20c03bccf9fdc0d8510f.
    
    Bug: https://bugs.gentoo.org/669926
    Package-Manager: Portage-2.3.51, Repoman-2.3.12
    RepoMan-Options: --force
    Signed-off-by: Louis Sautier <sbraz@gentoo.org>

 dev-python/ipython/{ipython-5.4.1-r1.ebuild => ipython-5.4.1-r2.ebuild} | 0
 dev-python/ipython/{ipython-5.8.0.ebuild => ipython-5.8.0-r1.ebuild}    | 0
 2 files changed, 0 insertions(+), 0 deletions(-)
Comment 5 matoro archtester 2018-11-16 16:02:13 UTC
Can this also please get applied to the dev-python/ipython-6 branch (latest testing)?  >=dev-python/prompt_toolkit-2 is not supported until >=dev-python/ipython-7 .  Thank you!!
Comment 6 Larry the Git Cow gentoo-dev 2018-11-20 13:47:21 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=20828f1f2f34eac38b4806f7db9adb6ecad70399

commit 20828f1f2f34eac38b4806f7db9adb6ecad70399
Author:     Louis Sautier <sbraz@gentoo.org>
AuthorDate: 2018-11-20 13:43:51 +0000
Commit:     Louis Sautier <sbraz@gentoo.org>
CommitDate: 2018-11-20 13:43:51 +0000

    dev-python/ipython: also enforce prompt_toolkit-2 dep. for 6.1.0
    
    Bug: https://bugs.gentoo.org/669926
    Package-Manager: Portage-2.3.51, Repoman-2.3.12
    Signed-off-by: Louis Sautier <sbraz@gentoo.org>

 .../ipython/{ipython-6.1.0-r1.ebuild => ipython-6.1.0-r2.ebuild}       | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)