Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 669256 - dev-libs/wlroots (new package) and dev-libs/sway-1.0 (new version)
Summary: dev-libs/wlroots (new package) and dev-libs/sway-1.0 (new version)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mykyta Holubakha
URL: https://github.com/gentoo/gentoo/pull...
Whiteboard:
Keywords: PullRequest
: 670292 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-10-21 22:46 UTC by Niccolò Scatena
Modified: 2018-11-08 22:12 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log for wlroots-0.1 (wlroots-0.1-build.log,148.09 KB, text/plain)
2018-10-21 22:46 UTC, Niccolò Scatena
Details
build.log for sway-1.0_beta1 (sway-1.0_beta1-build.log,208.79 KB, text/plain)
2018-10-22 19:44 UTC, Niccolò Scatena
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Niccolò Scatena 2018-10-21 22:46:40 UTC
Created attachment 552210 [details]
build.log for wlroots-0.1

wlroots [1] is a library used to build a Wayland compositor. It is part of the swaywm project [2] and is required for >=sway-1.0. Sway is an i3-compatible Wayland compositor, actually present in the gentoo repo at version 0.15.2.
wlroots-0.1 and Sway-1.0_beta1 relesed on Oct 21. See [3] and [4].

I'm going to make a PR on Gentoo Github with wlroots-0.1/9999 and another for sway-1.0_beta1/9999. I tested both wlroots and Sway with all possible use flag combinations and they works well for me. I've been using Sway on my system for a week. I attach here the build log for either wlroots and Sway.
I'll add myself as proxy-maintainer for wlroots; and also for Sway (restricted to >=1.0) in a separate commit. If Mykyta Holubakha (actual maintainer) prefer instead to maintain the package alone, I will easily revert the commit.


[1] https://github.com/swaywm/wlroots
[2] https://swaywm.org/
[3] https://github.com/swaywm/wlroots/releases
[4] https://github.com/swaywm/sway/releases
Comment 1 Niccolò Scatena 2018-10-21 23:16:30 UTC
Well... That's strange.
I'm trying to add a new commit to the PR (for wlroots-9999) but the github web interface doesn't shows the commit (after successful `git push`). Instead, I tried to clone again the fork locally from github and it contains the new commit (meaning github has received it - it's just not showing up).
I can't even comment to the PR, it says "You can't comment at this time.".
Comment 2 Niccolò Scatena 2018-10-21 23:38:23 UTC
DO NOT MERGE: buggy PR
It doesn't update. It doesn't let me comment. It doesn't let me close it. It doesn't delete my local fork. It doesn't let me do anything, actually.

I will recreate a new one as soon as github will let me restart from zero. Maybe this happened because I noticed now that I forgot to create a new branch and pushed from master.
Comment 3 thomasg 2018-10-22 01:23:12 UTC
Ironically, I also wrote a ebuild for wlroots at the same time as you did (though yours is more complete), which I pushed to my github repo to prepare a PR.

I'm having various github troubles as well, the commit doesn't even show up, even though when I pull, its there.
Looks to me as if something's severely going wrong at github in general.
Comment 4 Niccolò Scatena 2018-10-22 12:35:32 UTC
Ok, seems working now.

New PR: https://github.com/gentoo/gentoo/pull/10199
Comment 5 Niccolò Scatena 2018-10-22 19:44:12 UTC
Created attachment 552446 [details]
build.log for sway-1.0_beta1
Comment 6 Larry the Git Cow gentoo-dev 2018-10-30 10:33:58 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f691b4642a268fe36aaa30ba0427289a0e16121d

commit f691b4642a268fe36aaa30ba0427289a0e16121d
Author:     Niccolò Scatena <speedjack95@gmail.com>
AuthorDate: 2018-10-22 12:24:04 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-10-30 10:32:25 +0000

    dev-libs/wlroots: new package (version 0.1)
    
    wlroots is a library used to build a Wayland compositor. It is part of
    the swaywm project and is required for >=sway-1.0. Sway is an
    i3-compatible Wayland compositor.
    
    Closes: https://bugs.gentoo.org/669256
    Signed-off-by: Niccolò Scatena <speedjack95@gmail.com>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-libs/wlroots/Manifest           |  1 +
 dev-libs/wlroots/metadata.xml       | 40 ++++++++++++++++
 dev-libs/wlroots/wlroots-0.1.ebuild | 96 +++++++++++++++++++++++++++++++++++++
 3 files changed, 137 insertions(+)
Comment 7 Harri Nieminen (Moiman) 2018-11-04 19:34:36 UTC
*** Bug 670292 has been marked as a duplicate of this bug. ***
Comment 8 michael@smith-li.com 2018-11-04 22:11:23 UTC
Is there another bugzilla bug for tracking the merge of PR 10201? This bug is marked closed (presumably because of PR 10199), but the other PR is still open.
Comment 9 Niccolò Scatena 2018-11-04 22:38:01 UTC
No, there isn't a dedicated bug for PR 10201. I've created this bug maily for wlroots (that is a new pkg) and I've just linked to this bug from Sway PR (that is only a version bump).
Anyway, Sway should get merged in the next days. It's taking some time because it ended up in the middle of a lot of other PRs and therefore lost visibility.

I'll mark this bug as open again (to prevent other duplicates). I'll close it manually when Sway will be merged.
Comment 10 Larry the Git Cow gentoo-dev 2018-11-08 22:12:45 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=91396769767b5d2f56f3bc6cf53e1b78b0f7145c

commit 91396769767b5d2f56f3bc6cf53e1b78b0f7145c
Author:     Niccolò Scatena <speedjack95@gmail.com>
AuthorDate: 2018-10-22 15:45:17 +0000
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: 2018-11-08 22:12:18 +0000

    dev-libs/sway: version bump to 1.0_beta1.
    
    This commit adds the first Sway 1.0 beta release based on wlroots
    (should be merged first). Release by upstream on Oct 21.
    
    Closes: https://bugs.gentoo.org/669256
    Signed-off-by: Niccolò Scatena <speedjack95@gmail.com>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11
    Closes: https://github.com/gentoo/gentoo/pull/10201
    Signed-off-by: Patrice Clement <monsieurp@gentoo.org>

 dev-libs/sway/Manifest              |  1 +
 dev-libs/sway/metadata.xml          | 30 +++++++-----
 dev-libs/sway/sway-1.0_beta1.ebuild | 95 +++++++++++++++++++++++++++++++++++++
 3 files changed, 115 insertions(+), 11 deletions(-)