Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 669206 - app-arch/freeze-2.5.0-r1 : removal (was: freeze.h:20:33: error: FILE {aka struct _IO_FILE } has no member named _cnt)
Summary: app-arch/freeze-2.5.0-r1 : removal (was: freeze.h:20:33: error: FILE {aka str...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Antivirus Team
URL:
Whiteboard: stabilize amavisd-new-2.11.1-r3 after...
Keywords: PMASKED
Depends on:
Blocks: glibc-2.28
  Show dependency tree
 
Reported: 2018-10-21 14:29 UTC by Toralf Förster
Modified: 2019-03-29 10:10 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,15.73 KB, text/plain)
2018-10-21 14:29 UTC, Toralf Förster
Details
app-arch:freeze-2.5.0-r1:20181021-142122.log (app-arch:freeze-2.5.0-r1:20181021-142122.log,14.21 KB, text/plain)
2018-10-21 14:29 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,99.98 KB, text/plain)
2018-10-21 14:29 UTC, Toralf Förster
Details
environment (environment,72.48 KB, text/plain)
2018-10-21 14:29 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,11.79 KB, application/x-bzip)
2018-10-21 14:29 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,20.01 KB, application/x-bzip)
2018-10-21 14:29 UTC, Toralf Förster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2018-10-21 14:29:43 UTC
freeze.c:689:7: note: include ‘<stdlib.h>’ or provide a declaration of ‘exit’
In file included from freeze.c:1:
freeze.h:20:33: error: ‘FILE’ {aka ‘struct _IO_FILE’} has no member named ‘_cnt’
 #  define putc(x, p)      (--(p)->_cnt < 0 ? _flsbuf((unsigned char) (x), (p)) : (int) (*(p)->_ptr++ = (unsigned char) (x)))
                                 ^~
freeze.c:710:2: note: in expansion of macro ‘putc’

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.0-systemd_libressl_20181019-202112

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-7.3.1
 [2] x86_64-pc-linux-gnu-8.2.0 *

Available Python interpreters, in order of preference:
  [1]   python3.7
  [2]   python3.6
  [3]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby23 (with Rubygems)
  [2]   ruby25 (with Rubygems) *



emerge -qpvO app-arch/freeze
[ebuild  N    ] app-arch/freeze-2.5.0-r1
Comment 1 Toralf Förster gentoo-dev 2018-10-21 14:29:45 UTC
Created attachment 552112 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2018-10-21 14:29:48 UTC
Created attachment 552114 [details]
app-arch:freeze-2.5.0-r1:20181021-142122.log
Comment 3 Toralf Förster gentoo-dev 2018-10-21 14:29:51 UTC
Created attachment 552116 [details]
emerge-history.txt
Comment 4 Toralf Förster gentoo-dev 2018-10-21 14:29:54 UTC
Created attachment 552118 [details]
environment
Comment 5 Toralf Förster gentoo-dev 2018-10-21 14:29:57 UTC
Created attachment 552120 [details]
etc.portage.tbz2
Comment 6 Toralf Förster gentoo-dev 2018-10-21 14:29:59 UTC
Created attachment 552122 [details]
temp.tbz2
Comment 7 Andreas K. Hüttel archtester gentoo-dev 2018-10-21 14:43:29 UTC
Things changed around getc and putc, so this may be glibc-2.28 related. 

From the release notes:
>* The stdio functions 'getc' and 'putc' are no longer defined as macros.
>  This was never required by the C standard, and the macros just expanded
>  to call alternative names for the same functions.  If you hoped getc and
>  putc would provide performance improvements over fgetc and fputc, instead
>  investigate using (f)getc_unlocked and (f)putc_unlocked, and, if
>  necessary, flockfile and funlockfile.
Comment 8 Larry the Git Cow gentoo-dev 2019-01-05 11:33:43 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b8352d7d051806d3a3df3c6b00ec47af166b7f01

commit b8352d7d051806d3a3df3c6b00ec47af166b7f01
Author:     Andreas K. Hüttel <dilfridge@gentoo.org>
AuthorDate: 2019-01-05 11:33:01 +0000
Commit:     Andreas K. Hüttel <dilfridge@gentoo.org>
CommitDate: 2019-01-05 11:33:27 +0000

    app-arch/freeze: Assigning package to amavisd-new maintainers
    
    (since that is the only reverse dependency of it)
    
    Bug: https://bugs.gentoo.org/669206
    Package-Manager: Portage-2.3.54, Repoman-2.3.12
    Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>

 app-arch/freeze/metadata.xml | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)
Comment 9 Larry the Git Cow gentoo-dev 2019-01-05 16:13:11 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=185658bff21832b12c76e6e74fe9a7d1c6ea71cf

commit 185658bff21832b12c76e6e74fe9a7d1c6ea71cf
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2019-01-05 16:11:31 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2019-01-05 16:12:01 +0000

    mail-filter/amavisd-new: new revision sans the app-arch/freeze dependency.
    
    The app-arch/freeze package fails to build with a modern compiler and
    glibc. It's probably time to lay this package to rest. The last
    upstream release is from circa 1999. Fedora has some patches against
    it, but an email from the author (in the Fedora RPM) suggests that
    even he thinks the package is dead.
    
    While it's fun to see a long list of supported file types in amavisd,
    I've never actually seen one of these archives in real life. The
    recent build failures are due to some code quality issues; so even if
    it's possible to patch them, one has to ask: do we want to be feeding
    this unmaintained program untrusted input from the network? With all
    things considered, its removal is for the best.
    
    Bug: https://bugs.gentoo.org/669206
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11

 .../{amavisd-new-2.11.1-r2.ebuild => amavisd-new-2.11.1-r3.ebuild}     | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Comment 10 Michael Orlitzky gentoo-dev 2019-01-05 16:16:03 UTC
To satisfy my own curiosity I made the build failure go away, but a million other scary code quality issues remain. I don't think this is worth saving. Feel free to mask when that new revision of amavisd-new is stable (and don't hesitate to call for stabilization if I forget).
Comment 11 Larry the Git Cow gentoo-dev 2019-02-24 01:41:56 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7adcc87c864b6b017eb87e8b1eb28760cb81b255

commit 7adcc87c864b6b017eb87e8b1eb28760cb81b255
Author:     Andreas K. Hüttel <dilfridge@gentoo.org>
AuthorDate: 2019-02-24 01:41:01 +0000
Commit:     Andreas K. Hüttel <dilfridge@gentoo.org>
CommitDate: 2019-02-24 01:41:01 +0000

    package.mask: mask app-arch/freeze for removal
    
    Bug: https://bugs.gentoo.org/669206
    Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>

 profiles/package.mask | 5 +++++
 1 file changed, 5 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ca14d145f771fb8c26f40a260550484c3cfef85e

commit ca14d145f771fb8c26f40a260550484c3cfef85e
Author:     Andreas K. Hüttel <dilfridge@gentoo.org>
AuthorDate: 2019-02-24 01:39:22 +0000
Commit:     Andreas K. Hüttel <dilfridge@gentoo.org>
CommitDate: 2019-02-24 01:39:22 +0000

    mail-filter/amavisd-new: Remove old
    
    Bug: https://bugs.gentoo.org/669206
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>

 mail-filter/amavisd-new/Manifest                   |   1 -
 .../amavisd-new/amavisd-new-2.11.0-r3.ebuild       | 180 ---------------------
 2 files changed, 181 deletions(-)
Comment 12 Larry the Git Cow gentoo-dev 2019-03-29 10:10:24 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c791dd30761dd791e078f0418504d4f644708503

commit c791dd30761dd791e078f0418504d4f644708503
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-03-29 10:09:45 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-03-29 10:10:15 +0000

    app-arch/freeze: Remove last-rited pkg
    
    Closes: https://bugs.gentoo.org/669206
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 app-arch/freeze/Manifest                        |  1 -
 app-arch/freeze/files/freeze-2.5.0-gentoo.patch | 55 -------------------------
 app-arch/freeze/freeze-2.5.0-r1.ebuild          | 44 --------------------
 app-arch/freeze/metadata.xml                    | 12 ------
 profiles/package.mask                           |  5 ---
 5 files changed, 117 deletions(-)