Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 669148 - media-libs/libmp4v2 with clang - src/mp4util.h:36:51: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
Summary: media-libs/libmp4v2 with clang - src/mp4util.h:36:51: error: invalid suffix o...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-20 21:53 UTC by David Carlos Manuelda
Modified: 2018-11-04 21:54 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Carlos Manuelda 2018-10-20 21:53:18 UTC 
When compiling libmp4v2 with clang (I've fixed this issue before), I encountered:

src/mp4util.h:36:51: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
            throw new Exception("assert failure: "LIBMPV42_STRINGIFY((expr)), __FILE__, __LINE__, __FUNCTION__ ); \

This bug was proposed by me and fixed upstream via this commit from my PR: https://github.com/sergiomb2/libmp4v2/commit/edc4f0ad8f37bb8aeae4e3ea34766dc6cdbb2f15?diff=unified

I suggest a repackage or to apply the second part of the diff, which is missing in gentoo, all the rest compiles good.

Thanks,

David.
Comment 1 David Carlos Manuelda 2018-10-20 21:59:38 UTC 
Sorry, my mistake in testing, seems that the whole patch is not applied in media-libs/libmp4v2-2.0.0-r1.

The patch can be found and applied in: https://github.com/sergiomb2/libmp4v2/commit/edc4f0ad8f37bb8aeae4e3ea34766dc6cdbb2f15.patch
Comment 2 Larry the Git Cow gentoo-dev 2018-11-04 21:54:07 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d3d96d6889dadd57403a98f1d3469308ca658373

commit d3d96d6889dadd57403a98f1d3469308ca658373
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-11-04 21:50:31 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-11-04 21:53:23 +0000

    media-libs/libmp4v2: Fix build with clang
    
    Thanks-to: David Carlos Manuelda <StormByte@gmail.com>
    Closes: https://bugs.gentoo.org/669148
    Package-Manager: Portage-2.3.51, Repoman-2.3.12
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../libmp4v2/files/libmp4v2-2.0.0-clang.patch      | 36 ++++++++++++++++++++++
 .../files/libmp4v2-2.0.0-mp4tags-corruption.patch  |  2 +-
 media-libs/libmp4v2/libmp4v2-2.0.0-r1.ebuild       |  7 +++--
 3 files changed, 42 insertions(+), 3 deletions(-)