The "_modules" helper function in /usr/share/bash-completion/bash-completion does a crude recursive ls of the module directory, recursing into both the ./source and ./build symlinks if present (and ./build/source for out-of-tree builds), and then includes all .o files from the build tree in the results. This makes the terminal non-responsive for several minutes on my machine, and the output is pretty much useless for commands like modprobe. I hacked together a more correct version in https://forums.gentoo.org/viewtopic-t-1087832.html#8273102, pasted here for your convenience: _modules() { COMPREPLY=( $( compgen -W "$(shopt -s globstar failglob printf '%s\n' /lib/modules/"${1:?}"/!(source|build)/**/*.@(o|ko|ko.gz|ko.xz) | \ sed -e 's@^.*/\(.*\)\.k\?o\(\.[gx]z\)\?@\1@' )" -- "$cur" ) ) } There's already an open bug upstream for the slowness, https://github.com/scop/bash-completion/issues/136 However, given they haven't bothered to ack it in 15 months, maybe it'd be appropriate for the ebuild to apply this fix, as it's more likely to affect Gentoo users than binary distros.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=24feb6d0810d596a6bcac874bec5b901389ba1d4 commit 24feb6d0810d596a6bcac874bec5b901389ba1d4 Author: Arthur Zamarin <arthurzam@gentoo.org> AuthorDate: 2024-05-03 10:40:49 +0000 Commit: Arthur Zamarin <arthurzam@gentoo.org> CommitDate: 2024-05-03 10:48:42 +0000 app-shells/bash-completion: add 2.13.0 - add pytest-xdist for tests, for parallel testing - automatically extend symlinks for all supported python targets - fix CHANGES file rename - disable some more tests we don't really care about Closes: https://bugs.gentoo.org/886159 Closes: https://bugs.gentoo.org/622892 Closes: https://bugs.gentoo.org/836360 Closes: https://bugs.gentoo.org/734120 Closes: https://bugs.gentoo.org/669128 Bug: https://bugs.gentoo.org/865511 Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org> app-shells/bash-completion/Manifest | 1 + .../bash-completion/bash-completion-2.13.0.ebuild | 173 +++++++++++++++++++++ 2 files changed, 174 insertions(+)
Is this actually fixed? The upstream bug hasn't been touched at all and I don't see any commits in the last 6 years that meaningfully change the problem code.
Created attachment 892454 [details, diff] fix _comp_compgen_kernel_modules() for app-shells/bash-completion-2.13.0-r1 The original workaround broke with this update so I've attached a minimal patch to fix it. But I wasn't satisfied with just that, so here's a pure-bash alternative: ``` # shellcheck disable=SC2231,SC2295 _comp_compgen_kernel_modules() { local _modpath=/lib/modules/$1 local _exts=".@(o|ko?(.gz|.xz|.zst))" _comp_compgen_split -- "$( shopt -s globstar nullglob for _fn in "$_modpath"/!(source|build)/**/*$_exts; do _bn=${_fn##*/} echo "${_bn%%$_exts}" done )" } ```
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fc6a4f1238d28b66c13266c78493809e55b0ccb1 commit fc6a4f1238d28b66c13266c78493809e55b0ccb1 Author: Arthur Zamarin <arthurzam@gentoo.org> AuthorDate: 2024-05-10 09:02:48 +0000 Commit: Arthur Zamarin <arthurzam@gentoo.org> CommitDate: 2024-05-10 09:04:19 +0000 app-shells/bash-completion: add 2.14.0 - Also apply fix to optimize kernel modules search completion Closes: https://bugs.gentoo.org/669128 Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org> app-shells/bash-completion/Manifest | 1 + .../bash-completion/bash-completion-2.14.0.ebuild | 178 +++++++++++++++++++++ ...completion-2.14.0-optimize-kernel-modules.patch | 13 ++ 3 files changed, 192 insertions(+)
