hb_font_funcs_set_glyph_func(funcs, HarfBuzzGetGlyph, nullptr, nullptr); ^ /usr/include/harfbuzz/hb-deprecated.h:53:11: note: 'hb_font_funcs_set_glyph_func' has been explicitly marked deprecated here HB_EXTERN HB_DEPRECATED_FOR(hb_font_funcs_set_nominal_glyph_func or hb_font_funcs_set_variation_glyph_func) void ^ /usr/include/harfbuzz/hb-common.h:79:30: note: expanded from macro 'HB_DEPRECATED_FOR' #define HB_DEPRECATED_FOR(f) HB_DEPRECATED ^ /usr/include/harfbuzz/hb-common.h:67:38: note: expanded from macro 'HB_DEPRECATED' #define HB_DEPRECATED __attribute__((__deprecated__)) ^ ../../third_party/blink/renderer/platform/fonts/shaping/harfbuzz_face.cc:320:5: error: no matching function for call to 'hb_font_funcs_set_glyph_h_advances_func' hb_font_funcs_set_glyph_h_advances_func( ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/harfbuzz/hb-font.h:307:1: note: candidate function not viable: no known conversion from 'void (hb_font_t *, void *, unsigned int, hb_codepoint_t *, unsigned int, hb_position_t *, unsigned int, void *)' (aka 'void (hb_font_t *, void *, unsigned int, unsigned int *, unsigned int, int *, unsigned int, void *)') to 'hb_font_get_glyph_h_advances_func_t' (aka 'void (*)(hb_font_t *, void *, unsigned int, const unsigned int *, unsigned int, int *, unsigned int, void *)') for 2nd argument hb_font_funcs_set_glyph_h_advances_func (hb_font_funcs_t *ffuncs, ^ 1 warning and 1 error generated. [...] ninja: build stopped: subcommand failed. * ERROR: www-client/chromium-70.0.3538.67::gentoo failed (compile phase): * ninja -v -j8 -l0 -C out/Release v8_context_snapshot_generator failed Portage 2.3.51 (python 2.7.15-final-0, default/linux/amd64/17.0, gcc-8.2.0, glibc-2.27-r6, 4.18.12-gentoo x86_64) ================================================================= System uname: Linux-4.18.12-gentoo-x86_64-AMD_FX-tm-8350_Eight-Core_Processor-with-gentoo-2.6 KiB Mem: 16439132 total, 3743864 free KiB Swap: 0 total, 0 free sh bash 4.4_p23 ld GNU ld (Gentoo 2.30 p3) 2.30.0 app-shells/bash: 4.4_p23::gentoo dev-java/java-config: 2.2.0-r4::gentoo dev-lang/perl: 5.26.2::gentoo dev-lang/python: 2.7.15::gentoo, 3.5.5-r1::gentoo, 3.6.6::gentoo dev-util/cmake: 3.12.3::gentoo dev-util/pkgconfig: 0.29.2::gentoo sys-apps/baselayout: 2.6-r1::gentoo sys-apps/openrc: 0.38.2::gentoo sys-apps/sandbox: 2.13::gentoo sys-devel/autoconf: 2.13::gentoo, 2.69-r4::gentoo sys-devel/automake: 1.15.1-r2::gentoo, 1.16.1-r1::gentoo sys-devel/binutils: 2.30-r3::gentoo, 2.31.1-r1::gentoo sys-devel/gcc: 7.3.0-r3::gentoo, 8.2.0-r3::gentoo sys-devel/gcc-config: 2.0::gentoo sys-devel/libtool: 2.4.6-r5::gentoo sys-devel/make: 4.2.1-r4::gentoo sys-kernel/linux-headers: 4.18::gentoo (virtual/os-headers) sys-libs/glibc: 2.27-r6::gentoo Repositories: gentoo location: /home/me/code/gentoo sync-type: rsync sync-uri: rsync://rsync.gentoo.org/gentoo-portage priority: -1000 sync-rsync-verify-jobs: 1 sync-rsync-verify-metamanifest: no sync-rsync-extra-opts: sync-rsync-verify-max-age: 24 adjust location: /home/me/code/adjust/gentoo-overlay masters: gentoo priority: 0 ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="* -@EULA" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-O2 -pipe -march=native" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo" CXXFLAGS="-O2 -pipe -march=native" DISTDIR="/chroot/distfiles" ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="http://distfiles.gentoo.org" INSTALL_MASK="/etc/X11/xinit/xinitrc.d/80-dbus /usr/bin/dbus-launch" LANG="en_US.utf8" LDFLAGS="-Wl,-O1 -Wl,--as-needed" MAKEOPTS="-j8" PKGDIR="/usr/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" USE="X acl alsa amd64 apng berkdb bzip2 cli crypt cups cxx dri ffmpeg fortran gdbm glamor gmp gpo iconv icu ipv6 lapack libtirpc minizip multilib ncurses nls nptl opencl opengl openmp pam pcre readline seccomp sqlite ssl tcpd truetype udev unicode vdpau xattr xvmc zlib" ABI_X86="64 32" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon plan sheets stage words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx f16c fma3 fma4 mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3 xop" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-1" POSTGRES_TARGETS="postgres9_5 postgres10" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6" RUBY_TARGETS="ruby25" USERLAND="GNU" VIDEO_CARDS="radeon r600 radeonsi amdgpu" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Probably this harfbuzz commit broke it. https://github.com/harfbuzz/harfbuzz/commit/bee93e269711a3eda4e7d762b730522564fe6e87
(In reply to Mike Gilbert from comment #1) > Probably this harfbuzz commit broke it. > > https://github.com/harfbuzz/harfbuzz/commit/bee93e269711a3eda4e7d762b730522564fe6e87 Get vs. set? The given commit modifies the get functions, while the missing match is a set function.
(In reply to Duncan from comment #2) > > Get vs. set? The given commit modifies the get functions, while the missing > match is a set function. Ahh... Get inside the set. (I'll shutup now.)
Created attachment 552026 [details, diff] Patch to enable chromium with harfbuzz 2.0
Created attachment 552028 [details, diff] ebuild patch to enable harfbuzz 2.0 on chromium
(In reply to Alexandre Ferreira from comment #4) > Created attachment 552026 [details, diff] [details, diff] > Patch to enable chromium with harfbuzz 2.0 Build succeeds with this patch and resulting binary is functional.
This should be fixed in harfbuzz-2.0.1, latest harfbuzz is 2.0.2 too.
(In reply to Joonas Niilola from comment #7) > This should be fixed in harfbuzz-2.0.1, latest harfbuzz is 2.0.2 too. 2.0.2 fails the same.
commit 71d9fb289115bab6ca06290756bd40725bd82e34 Author: Lars Wendler <polynomial-c@gentoo.org> AuthorDate: Sun Oct 21 13:18:07 2018 Commit: Lars Wendler <polynomial-c@gentoo.org> CommitDate: Sun Oct 21 13:18:07 2018 media-libs/harfbuzz: Bump to version 2.0.2 Signed-off-by: Lars Wendler <polynomial-c@gentoo.org> Package-Manager: Portage-2.3.51, Repoman-2.3.11
Comment on attachment 552026 [details, diff] Patch to enable chromium with harfbuzz 2.0 Thanks for the patch. Unfortunately, it introduces several pointless formatting changes and is not suitable for submission upstream. 1. Converts spaces to tabs before "void* font_data". 2. Changes "unsigned" to "unsigned int". These are equivalent expressions in C++. 3. Moves the asterisk in pointer declarations from left to right.
Created attachment 552096 [details, diff] Fix harfbuzz 2.0 build failure Here's a cleaned-up patch. I am testing it now.
Hmm... so this patch fixes the issue with >=harfbuzz-2, but it breaks with <harfbuzz-2. I want to avoid conditional patching, so I will probably revbump the stable ebuild and apply the patch there.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=71fefc9233564d56103ad143ff8e768d18bcf89b commit 71fefc9233564d56103ad143ff8e768d18bcf89b Author: Mike Gilbert <floppym@gentoo.org> AuthorDate: 2018-10-21 15:16:26 +0000 Commit: Mike Gilbert <floppym@gentoo.org> CommitDate: 2018-10-21 15:17:02 +0000 www-client/chromium: fix build with harfbuzz-2 Bug: https://bugs.gentoo.org/669034 Package-Manager: Portage-2.3.51_p1, Repoman-2.3.11_p26 Signed-off-by: Mike Gilbert <floppym@gentoo.org> .../chromium/chromium-70.0.3538.67-r1.ebuild | 701 +++++++++++++++++++++ www-client/chromium/chromium-70.0.3538.67.ebuild | 3 +- .../chromium/files/chromium-harfbuzz-r0.patch | 80 +++ 3 files changed, 783 insertions(+), 1 deletion(-)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3ebb567656052386de62e5edefad9487ce5f3b32 commit 3ebb567656052386de62e5edefad9487ce5f3b32 Author: Mike Gilbert <floppym@gentoo.org> AuthorDate: 2018-10-22 00:19:41 +0000 Commit: Mike Gilbert <floppym@gentoo.org> CommitDate: 2018-10-22 00:19:41 +0000 www-client/chromium: dev channel bump (71.0.3578.10) Closes: https://bugs.gentoo.org/669034 Package-Manager: Portage-2.3.51_p1, Repoman-2.3.11_p26 Signed-off-by: Mike Gilbert <floppym@gentoo.org> www-client/chromium/Manifest | 2 +- ...{chromium-71.0.3559.6.ebuild => chromium-71.0.3578.10.ebuild} | 9 ++++++--- 2 files changed, 7 insertions(+), 4 deletions(-)
