Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 668756 - dev-games/openscenegraph-qt-3.5.5[-examples] - Consider making dev-qt/qtwebkit dependency conditional
Summary: dev-games/openscenegraph-qt-3.5.5[-examples] - Consider making dev-qt/qtwebki...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Maciej Mrozowski
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-15 21:59 UTC by eroen
Modified: 2018-12-23 21:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description eroen 2018-10-15 21:59:36 UTC
While the osgQt examples use qtwebkit, the library itself does not. However, one of the installed headers (for use by consumers, not the library itself), 'QWebViewImage' does use qtwebkit. It is my understanding that any consumers of this header would need to link to the qtwebkit library on their own, as the osgQt pkg-config files don't list that.[1]

I suggest qtwebkit an optional runtime dependency, controlled by a 'webkit' use flag. This flag could then be depended upon by any consumers that use the 'QWebViewImage' header.

If deemed necessary, the 'QWebViewImage' header could be deleted from the installed image.

The motivation for the change is the large amount of resources required to build qtwebkit and its dependencies. Afaiu qtwebkit is also deprecated in favour of qtwebengine. In Gentoo, there exists at least one consumer (games-engines/openmw-0.44.0) of osgQt that does not use the 'QWebViewImage' header.

1: https://github.com/openscenegraph/osgQt/blob/3.5.5/packaging/pkgconfig/openscenegraph-osgQt.pc.in
Comment 1 Larry the Git Cow gentoo-dev 2018-12-23 21:42:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7d3c4949d5523c270366ec441fbd4297e31f44be

commit 7d3c4949d5523c270366ec441fbd4297e31f44be
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-12-23 20:04:17 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-12-23 21:42:29 +0000

    dev-games/openscenegraph-qt: 3.5.7 version bump, add USE webkit
    
    Closes: https://bugs.gentoo.org/668756
    
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-games/openscenegraph-qt/Manifest               |  1 +
 .../openscenegraph-qt-3.5.7.ebuild                 | 48 ++++++++++++++++++++++
 2 files changed, 49 insertions(+)