Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 668286 - dev-util/spirv-tools-2018.5: does not install (almost) any files
Summary: dev-util/spirv-tools-2018.5: does not install (almost) any files
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-11 10:16 UTC by Michał Górny
Modified: 2018-10-13 17:47 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
dev-util:spirv-tools-2018.5:20181011-092143.log (dev-util:spirv-tools-2018.5:20181011-092143.log,469.51 KB, text/plain)
2018-10-11 10:16 UTC, Michał Górny 		Details
emerge-info.txt (emerge-info.txt,10.74 KB, text/plain)
2018-10-11 10:17 UTC, Michał Górny 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-10-11 10:16:46 UTC 
Created attachment 550562 [details]
dev-util:spirv-tools-2018.5:20181011-092143.log

Given how much time it wastes on compiling stuff, the end result is somewhat surprising:

./
./usr/
./usr/share/
./usr/share/doc/
./usr/share/doc/spirv-tools-2018.5/
./usr/share/doc/spirv-tools-2018.5/CHANGES.lz
./usr/share/doc/spirv-tools-2018.5/README.md.lz
./usr/include/
./usr/include/spirv-tools/
./usr/include/spirv-tools/spirv-tools-commit.h
>>> Done.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-10-11 10:17:18 UTC 
Created attachment 550564 [details]
emerge-info.txt
Comment 2 Nick Sarnie gentoo-dev 2018-10-11 23:47:36 UTC 
Hi Michal,

The issue is due to ninja being used for CMake Makefile generation. I expect it will fail with all spirv/vulkan packages since they all use a very similar build system configuration.

Should I be setting CMAKE_MAKEFILE_GENERATOR=emake for all of those packages?

Thanks,
Sarnex
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-10-13 17:39:59 UTC 
I suspect this is because the ebuild is calling 'default' instead of 'cmake-utils_src_install'.
Comment 4 Nick Sarnie gentoo-dev 2018-10-13 17:44:05 UTC 
Good catch, that was the fix. Will submit shortly.

Thanks,
Sarnex
Comment 5 Larry the Git Cow gentoo-dev 2018-10-13 17:47:55 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d939d55db5f1a22324469d29bb6d056767bf0083

commit d939d55db5f1a22324469d29bb6d056767bf0083
Author:     Nick Sarnie <sarnex@gentoo.org>
AuthorDate: 2018-10-13 17:45:44 +0000
Commit:     Nick Sarnie <sarnex@gentoo.org>
CommitDate: 2018-10-13 17:47:15 +0000

    dev-util/spirv-tools: Fix install when using ninja
    
    Fix suggestion by mgorny
    
    I also confirmed that no other vulkan/spirv packages have this mistake
    
    Fixes: https://bugs.gentoo.org/668286
    Signed-off-by: Nick Sarnie <sarnex@gentoo.org>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11

 dev-util/spirv-tools/spirv-tools-2018.4.ebuild | 2 +-
 dev-util/spirv-tools/spirv-tools-2018.5.ebuild | 2 +-
 dev-util/spirv-tools/spirv-tools-9999.ebuild   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)