Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 668164 - portage.dbapi.porttree.portagetree.portroot, portage.dbapi.porttree.portagetree.getname(): Suggested deletion
Summary: portage.dbapi.porttree.portagetree.portroot, portage.dbapi.porttree.portagetr...
Status: CONFIRMED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All All
: Normal trivial
Assignee: Portage team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2018-10-09 13:40 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2019-01-20 06:57 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch (portage.patch,1.95 KB, patch)
2018-10-09 13:42 UTC, Arfrever Frehtes Taifersar Arahesis
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2018-10-09 13:40:37 UTC
portage.dbapi.porttree.portagetree.portroot uses deprecated PORTDIR and is used only by 1 function:
portage.dbapi.porttree.portagetree.getname()


portage.dbapi.porttree.portagetree.getname() is not used anywhere and has been deprecated already at the time of CVS -> Subversion migration over 13 years ago (Git commit d9fc4acc572c6647a4f27b838d35d27d805d190e).


I suggest to delete both.
Comment 1 Arfrever Frehtes Taifersar Arahesis 2018-10-09 13:42:28 UTC
Created attachment 550244 [details, diff]
Patch
Comment 2 Larry the Git Cow gentoo-dev 2019-01-20 06:55:51 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=bbe00f515b80be3d6e279e4033f1cbc776a7fe27

commit bbe00f515b80be3d6e279e4033f1cbc776a7fe27
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2019-01-20 06:39:39 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2019-01-20 06:53:34 +0000

    portagetree: getname and portroot DeprecationWarning
    
    Bug: https://bugs.gentoo.org/668164
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 lib/portage/dbapi/porttree.py | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)
Comment 3 Zac Medico gentoo-dev 2019-01-20 06:57:29 UTC
(In reply to Arfrever Frehtes Taifersar Arahesis from comment #1)
> Created attachment 550244 [details, diff] [details, diff]
> Patch

Looks good, but I'd prefer to have a DeprecationWarning for at least a short time.