Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 667984 - Pip3line (new package)
Summary: Pip3line (new package)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Default Assignee for New Packages
URL: https://github.com/metrodango/pip3line
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2018-10-07 18:58 UTC by Gabriel Caudrelier
Modified: 2018-11-29 20:50 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild template (pip3line-TEMPLATE.ebuild,1.96 KB, text/plain)
2018-10-07 18:58 UTC, Gabriel Caudrelier
Details
metadata file (metadata.xml,478 bytes, text/xml)
2018-10-07 18:58 UTC, Gabriel Caudrelier
Details
template ebuild - updated (pip3line-TEMPLATE.ebuild,1.76 KB, text/plain)
2018-10-13 15:13 UTC, Gabriel Caudrelier
Details
metadata file - updated (metadata.xml,581 bytes, text/xml)
2018-10-13 15:14 UTC, Gabriel Caudrelier
Details
Ebuild template (pip3line-TEMPLATE.ebuild,1.69 KB, text/plain)
2018-10-14 21:22 UTC, Gabriel Caudrelier
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel Caudrelier 2018-10-07 18:58:35 UTC
Created attachment 549686 [details]
ebuild template

Hi,

Please find the template file to publish Pip3line into the Gentoo tree.

Pip3line is a Swiss Army knife for raw bytes manipulation & interception.

It first allows to apply various transformation to byte array input, in a customizable way.


It also has a more 'basic' hexeditor functionality as well as a packet analyser. The latter allowing to setup various clients/servers/proxies used for protocol analysis.

I think app-misc/pip3line should be a good place.

The attached is a template for ebuild.

thanks
Comment 1 Gabriel Caudrelier 2018-10-07 18:58:57 UTC
Created attachment 549688 [details]
metadata file
Comment 2 Jonas Stein gentoo-dev 2018-10-13 10:44:21 UTC
please test the ebuild with repoman -d -x full
You find many hints in the links on 
https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers
Comment 4 Gabriel Caudrelier 2018-10-13 15:13:10 UTC
Created attachment 550968 [details]
template ebuild - updated

new version passing QA from repoman -d -x full

I am not sure about the "leading spaces" issues though, but hey whatever makes repoman happy.
Comment 5 Gabriel Caudrelier 2018-10-13 15:14:14 UTC
Created attachment 550970 [details]
metadata file - updated

Metadata file passing QA from repoman -d -x full
Comment 6 Gabriel Caudrelier 2018-10-13 15:23:04 UTC
And I am happy to be the maintainer (or "proxy maintainer")
Comment 7 Jonas Stein gentoo-dev 2018-10-14 01:01:04 UTC
Thank you for your contribution. I had a short look on the ebuild. 
Here a few ideas:

* We always try to use the latest EAPI, please bump to EAPI=7
* Please be more specific in the DESCRIPTION. The objective description may be <=80 characters long.
* A bot can look for additional mistakes, if you upload a PR via github
* why do you inherit eutils?
* look for missing "||die"
* you should not pull source in the functions

I do not understand what this package does. 
"Raw bytes manipulation utility, able to apply well known and less well known transformations." Could be a hexeditor, but anything else too...
Comment 8 Gabriel Caudrelier 2018-10-14 21:21:11 UTC
Thanks for you answer.

I would like to point out that I mostly copy pasted this ebuild from ones already present in the official portage tree so I was only assuming they were correct already.

>> * We always try to use the latest EAPI, please bump to EAPI=7

The documentation only goes to 6, the seventh is not mentioned:

https://devmanual.gentoo.org/ebuild-writing/eapi/index.html

Also when I try to switch to 7 I get this error message from ebuild:

* ERROR: app-misc/pip3line-9999::local failed (depend phase):
 *   EAPI=7 is not supported
 * 
 * Call stack:
 *              ebuild.sh, line 635:  Called source '/usr/local/portage/app-misc/pip3line/pip3line-9999.ebuild'
 *   pip3line-9999.ebuild, line   6:  Called inherit 'cmake-utils' 'eutils'
 *              ebuild.sh, line 326:  Called __qa_source '/usr/portage/eclass/cmake-utils.eclass'
 *              ebuild.sh, line 111:  Called source '/usr/portage/eclass/cmake-utils.eclass'
 *     cmake-utils.eclass, line 109:  Called die
 * The specific snippet of code:
 *      *) die "EAPI=${EAPI:-0} is not supported" ;;
 * 
 * If you need support, post the output of `emerge --info '=app-misc/pip3line-9999::local'`,
 * the complete build log and the output of `emerge -pqv '=app-misc/pip3line-9999::local'`.
 * Working directory: '/usr/lib64/python3.6/site-packages'

And I don't have any solution for that.

>> * Please be more specific in the DESCRIPTION. The objective description may be <=80 characters long.

Description was updated to 77 characters.

>> * A bot can look for additional mistakes, if you upload a PR via github

I have no idea what you are asking me to do. What bot ? what's a PR ? 

>> * why do you inherit eutils?

A remnant of the copy paste, it is removed now.

>> * look for missing "||die"

Added them to the command

>> * you should not pull source in the functions

Noted, but where should I do that then ? src_prepare ? pkg_setup ? src_unpack ?
Comment 9 Gabriel Caudrelier 2018-10-14 21:22:07 UTC
Created attachment 551288 [details]
Ebuild template
Comment 10 Gabriel Caudrelier 2018-10-21 14:19:13 UTC
any updates ?
Comment 11 Jonas Stein gentoo-dev 2018-10-21 20:57:25 UTC
PR = pull request (I collected some of these here: https://wiki.gentoo.org/wiki/Abbreviations)

This and more is described in the links on
https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers

all sources should go to SRC_URI.

We can not discuss it here. But you can discuss it on IRC #gentoo-dev-help or #gentoo-proxy-maint
Comment 12 Gabriel Caudrelier 2018-11-17 01:14:42 UTC
Now that the QA process seems done and that I have complied with all objections and changes requests, what's the next step ?
Comment 13 Larry the Git Cow gentoo-dev 2018-11-29 20:48:55 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e0ecbeb23685caa949b18000e6e4f188cc710375

commit e0ecbeb23685caa949b18000e6e4f188cc710375
Author:     Gabriel Caudrelier <gabriel.caudrelier@gmail.com>
AuthorDate: 2018-10-30 02:33:54 +0000
Commit:     Virgil Dupras <vdupras@gentoo.org>
CommitDate: 2018-11-29 20:48:34 +0000

    app-misc/pip3line: Add new package
    
    Signed-off-by: Gabriel Caudrelier <gabriel.caudrelier@gmail.com>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11
    Bug: https://bugs.gentoo.org/667984
    Closes: https://github.com/gentoo/gentoo/pull/10336
    Signed-off-by: Virgil Dupras <vdupras@gentoo.org>

 app-misc/pip3line/Manifest              |  1 +
 app-misc/pip3line/metadata.xml          | 17 +++++++
 app-misc/pip3line/pip3line-3.5.4.ebuild | 87 +++++++++++++++++++++++++++++++++
 app-misc/pip3line/pip3line-9999.ebuild  | 87 +++++++++++++++++++++++++++++++++
 4 files changed, 192 insertions(+)
Comment 14 Virgil Dupras (RETIRED) gentoo-dev 2018-11-29 20:50:50 UTC
Pushed. I opened a new proxied maintainer bug for you Gabriel: bug 672258