Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 667604 - sys-apps/portage: bin/install-qa-check.d/08gentoo-paths is unstable due to missing whitelist support, move it to gentoo/metadata/install-qa-check.d until stable
Summary: sys-apps/portage: bin/install-qa-check.d/08gentoo-paths is unstable due to mi...
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Ebuild Support (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 666956
  Show dependency tree
 
Reported: 2018-10-02 19:17 UTC by Zac Medico
Modified: 2018-12-08 23:14 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zac Medico gentoo-dev 2018-10-02 19:17:22 UTC
In bug 667378 I proposed a QA_INSTALL_PATHS variable, but @mgorny wants to hold off on that in order to gather some data on what needs to be added to the global whitelist. Therefore, let's move it to gentoo/metadata/install-qa-check.d until it's stable.
Comment 1 Zac Medico gentoo-dev 2018-10-03 16:38:06 UTC
Until this QA check has adjustable whitelist support, we can consider it an unstable work in progress. Therefore, I'd like for the QA team to move it gentoo/metadata/install-qa-check.d/08gentoo-paths until it has matured. It's safe to commit it to the gentoo repository now, and it will become active when portage's internal copy is removed.
Comment 2 Larry the Git Cow gentoo-dev 2018-10-06 01:15:20 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=dd605b1aa574fc035d3319d954be1ca0d2cdde19

commit dd605b1aa574fc035d3319d954be1ca0d2cdde19
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2018-10-06 01:11:02 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2018-10-06 01:14:14 +0000

    Revert "install-qa-checks.d: Add a check for Gentoo path policies (FHS-y)"
    
    This reverts commit d5f97eaa464736a454c8ad410f4acd4fccdf2324.
    Until this QA check has adjustable whitelist support, we can consider
    it an unstable work in progress. Therefore, I'd like for the QA team
    to move it gentoo/metadata/install-qa-check.d/08gentoo-paths until
    it has matured. It's safe to commit it to the gentoo repository now,
    and it will become active when portage's internal copy is removed.
    
    Bug: https://bugs.gentoo.org/667604
    Closes: https://bugs.gentoo.org/667378
    Closes: https://github.com/gentoo/portage/pull/373
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 bin/install-qa-check.d/08gentoo-paths | 77 -----------------------------------
 1 file changed, 77 deletions(-)
Comment 3 Larry the Git Cow gentoo-dev 2018-10-06 08:35:42 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=67ffc42815419f5b33698f5739de321f6a6edd4a

commit 67ffc42815419f5b33698f5739de321f6a6edd4a
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2018-10-06 08:30:50 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-10-06 08:35:33 +0000

    install-qa-check.d: Move 08gentoo-paths check outta Portage
    
    Signed-off-by: Michał Górny <mgorny@gentoo.org>
    Bug: https://bugs.gentoo.org/show_bug.cgi?id=667604

 metadata/install-qa-check.d/08gentoo-paths | 77 ++++++++++++++++++++++++++++++
 1 file changed, 77 insertions(+)
Comment 4 Sergei Trofimovich (RETIRED) gentoo-dev 2018-10-09 08:49:14 UTC
While at it can we amend a few things?

1. add a link to expected policies

2. clarify the handling of collisions like:

cross-aarch64-unknown-linux-gnu:ghc-9999:20181002-133451.log-
cross-aarch64-unknown-linux-gnu:ghc-9999:20181002-133451.log- * The ebuild is installing to one or more unexpected paths:
cross-aarch64-unknown-linux-gnu:ghc-9999:20181002-133451.log- * 
cross-aarch64-unknown-linux-gnu:ghc-9999:20181002-133451.log- *   /usr/share/doc/aarch64-unknown-linux-gnu-ghc-9999
cross-aarch64-unknown-linux-gnu:ghc-9999:20181002-133451.log- * 
cross-aarch64-unknown-linux-gnu:ghc-9999:20181002-133451.log: * Please fix the ebuild to use correct FHS/Gentoo policy paths.
--
cross-aarch64_be-unknown-linux-gnu:ghc-9999:20180928-093547.log-
cross-aarch64_be-unknown-linux-gnu:ghc-9999:20180928-093547.log- * The ebuild is installing to one or more unexpected paths:
cross-aarch64_be-unknown-linux-gnu:ghc-9999:20180928-093547.log- * 
cross-aarch64_be-unknown-linux-gnu:ghc-9999:20180928-093547.log- *   /usr/share/doc/aarch64_be-unknown-linux-gnu-ghc-9999
cross-aarch64_be-unknown-linux-gnu:ghc-9999:20180928-093547.log- * 
cross-aarch64_be-unknown-linux-gnu:ghc-9999:20180928-093547.log: * Please fix the ebuild to use correct FHS/Gentoo policy paths. 
...
<18 more complains>