Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 667258 - dev-libs/botan-1.10.17 does not create the pkgconfig files correctly
Summary: dev-libs/botan-1.10.17 does not create the pkgconfig files correctly
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jack Lloyd
URL:
Whiteboard:
Keywords:
: 667296 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-09-28 19:37 UTC by Alexandre Ferreira
Modified: 2018-09-30 18:50 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to the ebuild to fix the problem (botan-1.10.17-fix-pkgconfig.patch,978 bytes, patch)
2018-09-28 19:38 UTC, Alexandre Ferreira
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Ferreira 2018-09-28 19:37:31 UTC
the ebuild for botan-1.10.17 incorrectly uses the ED variable and that prevents the botan-config and botan.pc files to be installed. This prevents botan to be used by other packages.

Reproducible: Always

Steps to Reproduce:
1.emerge botan-1.10.17
2.
3.
Actual Results:  
File /usr/lib/pkgconfig/botan.pc does not exists

Expected Results:  
# ls -l /usr/lib/pkgconfig/botan*
-rw-r--r-- 1 root root 289 Sep 28 14:15 /usr/lib/pkgconfig/botan-1.10.pc
lrwxrwxrwx 1 root root  13 Sep 28 14:15 /usr/lib/pkgconfig/botan.pc -> botan-1.10.pc
Comment 1 Alexandre Ferreira 2018-09-28 19:38:12 UTC
Created attachment 548140 [details, diff]
Patch to the ebuild to fix the problem
Comment 2 Mikhail Kurinnoi 2018-09-29 09:38:57 UTC
Works for me, thanks!
Tested with dev-qt/qt-creator-4.6.2 emerge, that was broken after dev-libs/botan update to 1.10.17.
Comment 3 Francesco Riosa 2018-09-30 13:32:47 UTC
see also bug #661646
Comment 4 jorgicio 2018-09-30 16:11:05 UTC
I confirm the problem and it's the botan itself. In the portage directories, it creates two similar-named directories, image and imageusr. So the problem is in the ebuild syntax.

Building by hand (with the command ebuild) and copying the imageusr content into image/usr may be used as a workaround before using the "merge" option.
Comment 5 Francesco Riosa 2018-09-30 17:33:57 UTC
do not use 'ebuild ... merge' lightly, it's better to with the fixed ebuild provided by  David Hallas in bug #661646
Comment 6 Mike Gilbert gentoo-dev 2018-09-30 17:34:52 UTC
Looks like alonbl missed the change for ED when porting the ebuild to EAPI 7.
Comment 7 Alon Bar-Lev (RETIRED) gentoo-dev 2018-09-30 17:50:19 UTC
(In reply to Mike Gilbert from comment #6)
> Looks like alonbl missed the change for ED when porting the ebuild to EAPI 7.

Correct, sorry.
Thanks Alexandre!
Comment 8 Larry the Git Cow gentoo-dev 2018-09-30 17:55:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0728f77261bb2d645f755996ede8c0119e39ebc1

commit 0728f77261bb2d645f755996ede8c0119e39ebc1
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2018-09-30 17:54:37 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2018-09-30 17:55:09 +0000

    dev-libs/botan: fixup ED references for EAPI 7
    
    Closes: https://bugs.gentoo.org/667258
    Package-Manager: Portage-2.3.50_p10, Repoman-2.3.11_p17
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 .../botan/{botan-1.10.17.ebuild => botan-1.10.17-r1.ebuild}    | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
Comment 9 Larry the Git Cow gentoo-dev 2018-09-30 17:56:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=21aa3c860a217eccdad3bf6e0708d5c009d6d203

commit 21aa3c860a217eccdad3bf6e0708d5c009d6d203
Author:     Alon Bar-Lev <alonbl@gentoo.org>
AuthorDate: 2018-09-30 17:53:56 +0000
Commit:     Alon Bar-Lev <alonbl@gentoo.org>
CommitDate: 2018-09-30 17:55:47 +0000

    dev-libs/botan: fix EAPI=7 ED reference
    
    Thanks: Alexandre Ferreira
    Closes: https://bugs.gentoo.org/667258
    Package-Manager: Portage-2.3.49, Repoman-2.3.10
    RepoMan-Options: --force
    Signed-off-by: Alon Bar-Lev <alonbl@gentoo.org>

 dev-libs/botan/botan-1.10.17-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 10 Alon Bar-Lev (RETIRED) gentoo-dev 2018-09-30 17:57:20 UTC
(In reply to Mike Gilbert from comment #6)
> Looks like alonbl missed the change for ED when porting the ebuild to EAPI 7.

next time please wait a bit until commit. you missed one place.
Comment 11 Mike Gilbert gentoo-dev 2018-09-30 18:03:47 UTC
(In reply to Alon Bar-Lev from comment #10)

Nope, I didn't miss it. That was omitted intentionally.

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7b63c672f99bc6b936fce1c3c6dfa5f42afd5329
Comment 12 Alon Bar-Lev (RETIRED) gentoo-dev 2018-09-30 18:10:23 UTC
(In reply to Mike Gilbert from comment #11)
> (In reply to Alon Bar-Lev from comment #10)
> 
> Nope, I didn't miss it. That was omitted intentionally.
> 
> https://gitweb.gentoo.org/repo/gentoo.git/commit/
> ?id=7b63c672f99bc6b936fce1c3c6dfa5f42afd5329

OK, thanks.
I went over all packages to make sure this was not missed.
Comment 13 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-09-30 18:14:46 UTC
If you don't mind reusing the bug, python_get_sitedir includes EPREFIX, so ED is incorrect there.
Comment 14 Alon Bar-Lev (RETIRED) gentoo-dev 2018-09-30 18:19:56 UTC
(In reply to Michał Górny from comment #13)
> If you don't mind reusing the bug, python_get_sitedir includes EPREFIX, so
> ED is incorrect there.

Oh... it was never correct.
It be ${D} right?
Comment 15 Davide Pesavento (RETIRED) gentoo-dev 2018-09-30 18:22:00 UTC
*** Bug 667296 has been marked as a duplicate of this bug. ***
Comment 16 Larry the Git Cow gentoo-dev 2018-09-30 18:50:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=97bdb195dcfa49615b3cd27313a260514e0303c8

commit 97bdb195dcfa49615b3cd27313a260514e0303c8
Author:     Alon Bar-Lev <alonbl@gentoo.org>
AuthorDate: 2018-09-30 18:48:52 +0000
Commit:     Alon Bar-Lev <alonbl@gentoo.org>
CommitDate: 2018-09-30 18:49:47 +0000

    dev-libs/botan: {ED}->{ED} when used with python_get_sitedir
    
    python_get_sitedir includes EPREFIX, so ED is incorrect there.
    
    Closes: https://bugs.gentoo.org/667258
    Thanks: mgorny
    Package-Manager: Portage-2.3.49, Repoman-2.3.10
    Signed-off-by: Alon Bar-Lev <alonbl@gentoo.org>

 dev-libs/botan/{botan-1.10.17-r1.ebuild => botan-1.10.17-r2.ebuild} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)