Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 666988 - sys-apps/etckeeper: problematic ~ppc64 keyword
Summary: sys-apps/etckeeper: problematic ~ppc64 keyword
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Luke-Jr
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-24 15:07 UTC by Benda Xu
Modified: 2018-10-03 05:15 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,2.21 KB, text/plain)
2018-09-25 20:51 UTC, Luke-Jr
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Benda Xu gentoo-dev 2018-09-24 15:07:42 UTC
Hi Luke,

Your commit d11e8e20cb5b0ced09310c50958b4f019a0ac1cb introduced ~ppc64 keyword for etckeeper-1.18.6, but at that time etckeeper-1.18.7 was in tree.

Besides, etckeeper depends on dev-util/bats which has not been keyworded as ~ppc64.

Please remember to run 'repoman -d full' before commit.  ppc64 is a dev profile, the repoman checks are only enabled when you specify '-d'.

Could you please fix your commit?

Yours,
Benda
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-09-24 15:20:26 UTC
Blame the committer.
Comment 2 Larry the Git Cow gentoo-dev 2018-09-24 18:48:45 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d4b3ef5ee99f42ca311e12587ba3ccd31a284278

commit d4b3ef5ee99f42ca311e12587ba3ccd31a284278
Author:     Mikle Kolyada <zlogene@gentoo.org>
AuthorDate: 2018-09-24 18:48:11 +0000
Commit:     Mikle Kolyada <zlogene@gentoo.org>
CommitDate: 2018-09-24 18:48:34 +0000

    sys-apps/etckeeper: remove ppc64 keyword
    
    Bug: https://bugs.gentoo.org/666988
    Package-Manager: Portage-2.3.49, Repoman-2.3.10

 sys-apps/etckeeper/etckeeper-1.18.6.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2018-09-24 18:50:08 UTC
(In reply to Benda Xu from comment #0)

> Please remember to run 'repoman -d full' before commit.  ppc64 is a dev
> profile, the repoman checks are only enabled when you specify '-d'.
>

The irony is that it is _not_ a dev profile, it is stable.

But still it would be nice to see an explanation from the commiter
Comment 4 Luke-Jr 2018-09-25 03:25:05 UTC
Note 1.18.6 didn't depend on dev-util/bats.

repoman doesn't seem to consider the lack of keyword on the latest version to be an error, just a warning.

For some reason, repoman still complains about the bats dependency on the new version even after adding ~ppc64 to its keywords. I assume this is related to not having the git checkout in my portage path, but it makes repoman's output on this matter semi-useless. :/

Anyway, https://github.com/gentoo/gentoo/pull/9971
Comment 5 Michael 'veremitz' Everitt 2018-09-25 03:46:58 UTC
As present maintainer of etckeeper, I'd like to see some build logs please?
Comment 6 Luke-Jr 2018-09-25 20:51:24 UTC
Created attachment 547944 [details]
build.log

Not much in the build log, but here it is...
Comment 7 Benda Xu gentoo-dev 2018-10-01 03:52:41 UTC
Thank you veremitz and Luke.  Good luck with keywording ppc64.
Comment 8 Larry the Git Cow gentoo-dev 2018-10-03 05:15:17 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8ec49e72437655870c55706f283c213405a3ff6b

commit 8ec49e72437655870c55706f283c213405a3ff6b
Author:     Luke Dashjr <luke-jr+git@utopios.org>
AuthorDate: 2018-09-25 02:21:25 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2018-10-03 05:12:44 +0000

    sys-apps/etckeeper: Restore ~ppc64 keyword
    
    Closes: https://bugs.gentoo.org/666988
    Closes: https://github.com/gentoo/gentoo/pull/9971
    Signed-off-by: Luke Dashjr <luke-jr+git@utopios.org>
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 sys-apps/etckeeper/etckeeper-1.18.6-r1.ebuild | 2 +-
 sys-apps/etckeeper/etckeeper-1.18.6.ebuild    | 2 +-
 sys-apps/etckeeper/etckeeper-1.18.7.ebuild    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)