Created attachment 547550 [details] Build log showing error with +gstreamer and -opengl Hello, as the emerge --info output below shows, I've been trying to compile webkit-gtk-2.20.5 with +gstreamer, but without any OpenGL flags. The emerge fails (amongst others) with the error: /var/tmp/portage/net-libs/webkit-gtk-2.20.5/work/webkitgtk-2.20.5/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:498:46: error: no member named 'sharingGLContext' in 'WebCore::PlatformDisplay' GLContext* webkitContext = sharedDisplay.sharingGLContext(); Due to the nature of the source code, I added +opengl to the package's use flags. Consequently, the package emerged cleanly. To further confirm my suspicions, I also tried building with the following flags: -gstreamer -opengl -instrospection(this is only required because of -gstreamer) Again, the package builds cleanly, so it seems the gstreamer flag requires +opengl, which should be reflected in the ebuild. Best Regards, Michael Meier emerge --info output: Portage 2.3.48 (python 2.7.15-final-0, default/linux/amd64/17.0, gcc-8.2.0, glibc-2.27-r6, 4.18.9-gentoo x86_64) ================================================================= System Settings ================================================================= System uname: Linux-4.18.9-gentoo-x86_64-AMD_Ryzen_7_1700X_Eight-Core_Processor-with-gentoo-2.6 KiB Mem: 16445968 total, 11506072 free KiB Swap: 2047996 total, 2047996 free Timestamp of repository gentoo: Sat, 22 Sep 2018 08:30:01 +0000 Head commit of repository gentoo: 7073891c434fa15c7219d2212e38ee5387b971aa Head commit of repository meiers_repo: e05c19ea8c14797f19fdd41e6481528987ed24bd sh bash 4.4_p23 ld GNU ld (Gentoo 2.31.1 p3) 2.31.1 app-shells/bash: 4.4_p23::gentoo dev-java/java-config: 2.2.0-r4::gentoo dev-lang/perl: 5.26.2::gentoo dev-lang/python: 2.7.15::gentoo, 3.6.6::gentoo dev-util/cmake: 3.12.2::gentoo dev-util/pkgconfig: 0.29.2::gentoo sys-apps/baselayout: 2.6-r1::gentoo sys-apps/openrc: 0.38.2::gentoo sys-apps/sandbox: 2.13::gentoo sys-devel/autoconf: 2.13::gentoo, 2.69-r4::gentoo sys-devel/automake: 1.16.1-r1::gentoo sys-devel/binutils: 2.31.1-r1::gentoo sys-devel/gcc: 8.2.0-r2::gentoo sys-devel/gcc-config: 2.0::gentoo sys-devel/libtool: 2.4.6-r5::gentoo sys-devel/make: 4.2.1-r4::gentoo sys-kernel/linux-headers: 4.17::gentoo (virtual/os-headers) sys-libs/glibc: 2.27-r6::gentoo Repositories: gentoo location: /usr/portage sync-type: rsync sync-uri: rsync://rsync.gentoo.org/gentoo-portage priority: -1000 sync-rsync-verify-jobs: 1 sync-rsync-verify-metamanifest: yes sync-rsync-extra-opts: sync-rsync-verify-max-age: 24 portage_test location: /usr/local/portage_test masters: gentoo priority: -999 meiers_repo location: /usr/local/portage sync-type: git sync-uri: https://git.theben.cloudns.pro/mmeier/gentoo_overlay.git sync-user: portage:portage masters: gentoo crossdev location: /usr/local/portage-crossdev masters: gentoo priority: 10 brother-overlay location: /var/lib/layman/brother-overlay sync-type: laymansync sync-uri: https://github.com/stefan-langenmaier/brother-overlay.git masters: gentoo priority: 50 ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="* -@EULA PUEL NVIDIA-CUDA" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-O2 -pipe -march=znver1" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c" CXXFLAGS="-O2 -pipe -march=znver1" DISTDIR="/usr/portage/distfiles" ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="rsync://mirror.eu.oneandone.net/gentoo/ http://mirror.eu.oneandone.net/linux/distributions/gentoo/gentoo/ ftp://ftp.wh2.tu-dresden.de/pub/mirrors/gentoo rsync://mirror.netcologne.de/gentoo/ http://mirror.netcologne.de/gentoo/ ftp://mirror.netcologne.de/gentoo/ http://linux.rz.ruhr-uni-bochum.de/download/gentoo-mirror/ ftp://ftp.halifax.rwth-aachen.de/gentoo/ http://ftp.halifax.rwth-aachen.de/gentoo/ rsync://ftp.halifax.rwth-aachen.de/gentoo/ ftp://sunsite.informatik.rwth-aachen.de/pub/Linux/gentoo ftp://ftp.uni-erlangen.de/pub/mirrors/gentoo http://ftp.uni-erlangen.de/pub/mirrors/gentoo rsync://ftp-stud.hs-esslingen.de/gentoo/ ftp://ftp-stud.hs-esslingen.de/pub/Mirrors/gentoo/ http://ftp-stud.hs-esslingen.de/pub/Mirrors/gentoo/" LANG="de_DE.utf8" LDFLAGS="-Wl,-O1 -Wl,--as-needed" LINGUAS="de en" MAKEOPTS="-j9" PKGDIR="/usr/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" USE="X aac acl acpi alsa amd64 bash-completion berkdb branding bzip2 cairo cdr clang cli consolekit crypt cups cxx dbus dri ffmpeg fontconfig fortran fuse gdbm gif git gnome-keyring gtk iconv inotify ipv6 jpeg libnotify libtirpc linguas_de linguas_en lm_sensors matroska mime modules mp3 mp4 mpeg multilib ncurses networkmanager nls nptl ogg opengl openmp pam pcre pdf png policykit postscript pulseaudio readline scanner seccomp smp sound spell ssl svg syslog tcpd threads truetype udev udisks unicode vaapi vdpau vorbis xattr xfce xinerama xscreensaver zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon plan sheets stage words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" L10N="de en" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-0" POSTGRES_TARGETS="postgres9_5 postgres10" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6 python3_6" RUBY_TARGETS="ruby23 ruby25" USERLAND="GNU" VIDEO_CARDS="nvidia" XFCE_PLUGINS="clock" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS ================================================================= Package Settings ================================================================= net-libs/webkit-gtk-2.18.6::gentoo was built with the following: USE="X gnome-keyring gstreamer introspection jit libnotify spell (-aqua) -coverage -doc -egl -geolocation -gles2 -nsplugin -opengl -test -wayland -webgl" ABI_X86="(64)" CFLAGS="-O2 -pipe -march=znver1 -fno-strict-aliasing" CXXFLAGS="-O2 -pipe -march=znver1 -fno-strict-aliasing" LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--no-keep-memory"
Might be fixed with 2.22.1; hoping to bump to 2.22.2 soon.
Actually, knowing a bit how they use gstreamer, that's unlikely, but there's some sort of build fix with video disabled. Maybe it means introspection doesn't break without gstreamer anymore, and we can decouple that instead. Would look into it as working on the bump.
I didn't have the CPU time for checking these things together with the 2.22.2 bump (plus 2.22 has security fixes that we were overdue to add). Feel free to help testing these things with 2.22.2: * Remove "introspection? ( gstreamer )" from REQUIRED_USE and try if USE="introspection -gstreamer" still fails to build * Try if USE="gstreamer -opengl -gles2" still fails to build as per this bug report
Created attachment 550276 [details] Failed Build log with USE="introspection -gstreamer"
Hello Mart, I've tried the webkit-gtk-2.22.2.ebuild with the same aforementioned useflags, namely "+gstreamer -opengl -gles2" and get the exact same error. I've also tried the "introspection -gstreamer" combination, and it lead to the build error you see in the "Faild Build log with USE="introspection -gstreamer"" attachment. For what it's worth, I've also tried the gstreamer without opengl with Clang instead of GCC, and got the same error.
(In reply to Michael Meier from comment #5) > I've tried the webkit-gtk-2.22.2.ebuild with the same aforementioned > useflags, namely "+gstreamer -opengl -gles2" and get the exact same error. > > I've also tried the "introspection -gstreamer" combination, and it lead to > the build error you see in the "Faild Build log with USE="introspection > -gstreamer"" attachment. That's an issue in the older version with USE="-opengl -gles2", which without this failure would simply make all consumers of webkit-gtk fail link instead. All should be good with 2.22.5 then, please open a new bug if not. Please note that building without USE=opengl (or USE=gles2 for some embedded use cases) is NOT suggested whatsoever. You lose async scrolling and more, which will make things feel unnecessarily slower. Even the embedded use cases WebKitWPE library hard requires GL (full opengl or gles2), just webkit-gtk remains to support building without GL for some very very specific embedded cases where the platform really doesn't have any GL whatsoever; I am 99.99% sure that's not the case for you. For avoiding GL on the web, you can disable USE=webgl instead, but USE=opengl itself affects the library and its performance and apparent smoothness directly as well.
Maybe a bit late, but I've got the same build error on 2.22.4, worked around it by enabling +opengl. When emerging 2.22.5 with -opengl again I get a different build error, which goes away when enabling +opengl. This was the relevant part of the build log: In file included from /var/tmp/portage/net-libs/webkit-gtk-2.22.5/work/webkitgtk-2.22.5/Source/WebCore/platform/glib/EventHandlerGLib.cpp:38:0: /var/tmp/portage/net-libs/webkit-gtk-2.22.5/work/webkitgtk-2.22.5/Source/WebCore/platform/PlatformWheelEvent.h:216:60: error: no 'bool WebCore::PlatformWheelEvent::isEndOfNonMomentumScroll() const' member function declared in class 'WebCore::PlatformWheelEvent' inline bool PlatformWheelEvent::isEndOfNonMomentumScroll() const ^~~~~ /var/tmp/portage/net-libs/webkit-gtk-2.22.5/work/webkitgtk-2.22.5/Source/WebCore/platform/PlatformWheelEvent.h:221:67: error: no 'bool WebCore::PlatformWheelEvent::isTransitioningToMomentumScroll() const' member function declared in class 'WebCore::PlatformWheelEvent' inline bool PlatformWheelEvent::isTransitioningToMomentumScroll() const and these are my USE flags: -egl -geolocation -opengl -webgl -jit -libnotify Does this warrant a different/new bug?
(In reply to Simon from comment #7) > In file included from > /var/tmp/portage/net-libs/webkit-gtk-2.22.5/work/webkitgtk-2.22.5/Source/ > WebCore/platform/glib/EventHandlerGLib.cpp:38:0: > /var/tmp/portage/net-libs/webkit-gtk-2.22.5/work/webkitgtk-2.22.5/Source/ > WebCore/platform/PlatformWheelEvent.h:216:60: error: no 'bool > WebCore::PlatformWheelEvent::isEndOfNonMomentumScroll() const' member > function declared in class 'WebCore::PlatformWheelEvent' > inline bool PlatformWheelEvent::isEndOfNonMomentumScroll() const > ^~~~~ > /var/tmp/portage/net-libs/webkit-gtk-2.22.5/work/webkitgtk-2.22.5/Source/ > WebCore/platform/PlatformWheelEvent.h:221:67: error: no 'bool > WebCore::PlatformWheelEvent::isTransitioningToMomentumScroll() const' member > function declared in class 'WebCore::PlatformWheelEvent' > inline bool PlatformWheelEvent::isTransitioningToMomentumScroll() const > > and these are my USE flags: -egl -geolocation -opengl -webgl -jit -libnotify > > Does this warrant a different/new bug? Yes - upstream mainly. For downstream I'm inclined to remove the choice completely, as almost no-one should be disabling opengl, unless building something specific (for which you'd otherwise use OpenEmbedded or something like that) - yet they do, despite the strong warnings I added, as evidenced here...
Upstream bug report for this for 2.22.5 is https://bugs.webkit.org/show_bug.cgi?id=193380
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=423de9362ed2b23efd5129e22b5bf0e13b2648b8 commit 423de9362ed2b23efd5129e22b5bf0e13b2648b8 Author: Mart Raudsepp <leio@gentoo.org> AuthorDate: 2019-01-17 19:33:50 +0000 Commit: Mart Raudsepp <leio@gentoo.org> CommitDate: 2019-01-17 19:35:42 +0000 net-libs/webkit-gtk: require GL non-GL builds are only meant for some rare use case needs in the embedded world. But they are still broken a bit, so just disallow them for now again. Saves time for those that are for some reason still trying to disable GL fully. Bug: https://bugs.gentoo.org/666806 Package-Manager: Portage-2.3.52, Repoman-2.3.12 Signed-off-by: Mart Raudsepp <leio@gentoo.org> net-libs/webkit-gtk/webkit-gtk-2.22.5.ebuild | 2 ++ 1 file changed, 2 insertions(+)
