Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 666752 - =dev-qt/qtwebkit-5.212.0_pre20180120 breaks with USE="-hyphen"
Summary: =dev-qt/qtwebkit-5.212.0_pre20180120 breaks with USE="-hyphen"
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2018-09-22 11:10 UTC by David Flogeras
Modified: 2018-10-19 20:23 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
qtwebkit-honor-hyphen-useflag.patch (qtwebkit-honor-hyphen-useflag.patch,476 bytes, patch)
2018-09-29 15:13 UTC, Alexander Sergeyev
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Flogeras 2018-09-22 11:10:29 UTC
When building without hyphen cmake failed in configuration with:

CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:137 
(message):
  Could NOT find Hyphen (missing: HYPHEN_INCLUDE_DIR HYPHEN_LIBRARIES)
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:377 (_FPHSA_FAILU
RE_MESSAGE)
  Source/cmake/FindHyphen.cmake:37 (find_package_handle_standard_args)
  Source/cmake/OptionsQt.cmake:790 (find_package)
  Source/cmake/WebKitCommon.cmake:50 (include)
  CMakeLists.txt:137 (include)


emerge --info is:

Portage 2.3.40 (python 3.6.5-final-0, default/linux/amd64/17.0/desktop/plasma, gcc-7.3.0, glibc-2.26-r7, 4.14.65-gentoo x86_64)
=================================================================
System uname: Linux-4.14.65-gentoo-x86_64-Intel-R-_Core-TM-_i7-4770_CPU_@_3.40GHz-with-gentoo-2.4.1
KiB Mem:    16336340 total,   1865184 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Thu, 20 Sep 2018 22:45:01 +0000
Head commit of repository gentoo: 7496166e944bd279599649e6c8e70050e5c3fdac
sh bash 4.4_p12
ld GNU ld (Gentoo 2.30 p2) 2.30.0
app-shells/bash:          4.4_p12::gentoo
dev-lang/perl:            5.24.3-r1::gentoo
dev-lang/python:          2.7.15::gentoo, 3.6.5::gentoo
dev-util/cmake:           3.9.6::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.4.1-r2::gentoo
sys-apps/openrc:          0.34.11::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.15.1-r2::gentoo
sys-devel/binutils:       2.30-r2::gentoo
sys-devel/gcc:            7.3.0-r3::gentoo
sys-devel/gcc-config:     1.8-r1::gentoo
sys-devel/libtool:        2.4.6-r3::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 4.13::gentoo (virtual/os-headers)
sys-libs/glibc:           2.26-r7::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-max-age: 24
    sync-rsync-extra-opts: 

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -march=atom -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -march=atom -pipe"
DISTDIR="/usr/portage/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs buildpkg config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://mirror.its.dal.ca/gentoo"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en"
MAKEOPTS="-j8"
PKGDIR="/usr/portage/packages"
PORTAGE_BINHOST="http://localhost:8080"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi activities alsa amd64 berkdb bluetooth branding bzip2 cairo cdda cli consolekit crypt cxx dbus declarative dri dts dvdr emboss encode exif fam flac gdbm gif glamor gpm gtk iconv jpeg kde kipi kwallet lcms libnotify libtirpc mad mng modules mozbranding mp3 mp4 mpeg multilib ncurses nls nptl ogg opengl openmp pam pango pcre pdf phonon plasma png policykit ppds qml qt5 readline sdl seccomp spell ssl startup-notification svg tcpd threads tiff truetype udev udisks unicode upower usb vorbis widgets wxwidgets x264 xattr xcb xcomposite xinerama xml xv xvid zlib" ABI_X86="64" ALSA_CARDS="hda_intel" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon plan sheets stage words" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2 sse3 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="pc" INPUT_DEVICES="keyboard mouse evdev synaptics" KERNEL="linux" L10N="en" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-0" POSTGRES_TARGETS="postgres9_5 postgres10" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6" RUBY_TARGETS="ruby23" USERLAND="GNU" VIDEO_CARDS="intel i915" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS


Reproducible: Always
Comment 1 Paul Thompson 2018-09-27 04:25:58 UTC
I also see this. Most people will not, unless they no not have hyphen installed, and happen to notice a new USE flag defaulting to on, and decide to turn it off.

qtwebkit _will_ merge with USE="-hyphen" _if_ the hyphen package is already installed. So maybe:

a) the ebuild needs to communicate to the underlying build system not to look for hyphen or attempt to use it.

b) hyphen is not an optional dep, and the USE token should be removed and the hyphen package made a hard dep.
Comment 2 Alexander Sergeyev 2018-09-29 15:12:18 UTC
> a) the ebuild needs to communicate to the underlying build system not to
> look for hyphen or attempt to use it. 
> b) hyphen is not an optional dep, and the USE token should be removed and
> the hyphen package made a hard dep.

Looks like it's the (a) option. I've attached the patch to pass the corresponding flag to cmake.
Comment 3 Alexander Sergeyev 2018-09-29 15:13:07 UTC
Created attachment 548236 [details, diff]
qtwebkit-honor-hyphen-useflag.patch
Comment 4 David Flogeras 2018-10-03 09:31:03 UTC
(In reply to Alexander Sergeyev from comment #3)
> Created attachment 548236 [details, diff] [details, diff]
> qtwebkit-honor-hyphen-useflag.patch

The above patch worked perfectly for my systems, thanks Alexander!
Comment 5 ta2002 2018-10-15 18:48:19 UTC
(In reply to Alexander Sergeyev from comment #3)
> Created attachment 548236 [details, diff] [details, diff]
> qtwebkit-honor-hyphen-useflag.patch

Thanks from me, too. Don't want to install dev-libs/hyphen (or any of the additional dependencies that hyphen drags in).
Comment 6 Larry the Git Cow gentoo-dev 2018-10-19 20:23:42 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1d579b1e892f271ef03140255d03d59b8369e877

commit 1d579b1e892f271ef03140255d03d59b8369e877
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-10-19 19:54:04 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-10-19 20:23:29 +0000

    dev-qt/qtwebkit: Fix build with !hyphen
    
    Closes: https://bugs.gentoo.org/666752
    Reported-by: David Flogeras <dflogeras2@gmail.com>
    Thanks-to: Alexander Sergeyev <sergeev917@gmail.com>
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11

 dev-qt/qtwebkit/qtwebkit-5.212.0_pre20180120.ebuild | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)