Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 666639 - media-gfx/xsane-0.999-r2 fails to find gimp plug-ins directory with media-gfx/gimp-9999 (gimptool-2.99)
Summary: media-gfx/xsane-0.999-r2 fails to find gimp plug-ins directory with media-gfx...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Printing Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-20 16:46 UTC by Miroslav Šulc
Modified: 2019-02-07 13:31 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Miroslav Šulc gentoo-dev 2018-09-20 16:46:00 UTC
it fails because in gimp-9999 the gimptool executable is now named gimptool-2.99 which is not handled by this fragment of the ebuild:

        if use gimp; then
                local plugindir
                if [ -x "${EPREFIX}"/usr/bin/gimptool ]; then
                        plugindir="$(gimptool --gimpplugindir)/plug-ins"
                elif [ -x "${EPREFIX}"/usr/bin/gimptool-2.0 ]; then
                        plugindir="$(gimptool-2.0 --gimpplugindir)/plug-ins"
                else
                    	die "Can't find GIMP plugin directory."
                fi
                dodir "${plugindir#${EPREFIX}}"
                dosym /usr/bin/xsane "${plugindir#${EPREFIX}}"/xsane
        fi

it would be better changed to something like this:

        if use gimp; then
                local plugindir
                local gimptool=$(ls "${EPREFIX}"/usr/bin/gimptool* | head -n1)
                if [ -n "${gimptool}" ]; then
                        plugindir="$(${gimptool} --gimpplugindir)/plug-ins"
                else
                    	die "Can't find GIMP plugin directory."
                fi
                dodir "${plugindir#${EPREFIX}}"
                dosym /usr/bin/xsane "${plugindir#${EPREFIX}}"/xsane
        fi
Comment 1 Larry the Git Cow gentoo-dev 2019-02-07 13:31:38 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3e06dd4dbcd2bb33f3d75f20c64ea64f105b3afe

commit 3e06dd4dbcd2bb33f3d75f20c64ea64f105b3afe
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2019-02-07 13:31:04 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2019-02-07 13:31:27 +0000

    media-gfx/xsane-0.999-r2: fixed gimptool handling
    
    Closes: https://bugs.gentoo.org/666639
    Package-Manager: Portage-2.3.59, Repoman-2.3.12
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 media-gfx/xsane/xsane-0.999-r2.ebuild | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)