Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 666414 - x11-wm/awesome: touches stuff for Portage implementation details
Summary: x11-wm/awesome: touches stuff for Portage implementation details
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-17 15:27 UTC by Michał Górny
Modified: 2021-01-18 10:21 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-09-17 15:27:26 UTC
# This directory contains SVG images which we don't want to compress
  use doc && touch "${ED}"/usr/share/doc/${PF}/doc/images.ecompress.skip

Do I have to explain that any non-Portage package manager will just compress the images and install this useless file?
Comment 1 Ștefan Talpalaru 2019-09-22 18:05:07 UTC
(In reply to Michał Górny from comment #0)
> Do I have to explain that any non-Portage package manager will just compress
> the images and install this useless file?

No. You need to explain why that no longer works since your modifications to ecompress: https://archives.gentoo.org/gentoo-portage-dev/message/7f06411bbc90d19f423d99dbcaef8713

And also why is there no way for ebuilds to opt out of this path- and extension-based automated file compression.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-09-22 18:24:19 UTC
(In reply to Ștefan Talpalaru from comment #1)
> And also why is there no way for ebuilds to opt out of this path- and
> extension-based automated file compression.

Yes, there is.  And it's documented.
Comment 3 Ștefan Talpalaru 2019-09-22 18:31:40 UTC
You're confusing user settings with ebuild settings. Go ahead and fix the "awesome" ebuilds to no longer compress SVG files, regardless of the user's PORTAGE_COMPRESS and PORTAGE_COMPRESS_EXCLUDE_SUFFIXES. You'll see what I mean.

I ran into this problem with a file called "EULA" that a hardcoded binary path forces into "/usr/share/doc/". The only way I found to avoid the ecompress plague was to rename it into "EULA.png" and make an "EULA" symlink to it. So much for sane tooling design...
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-09-22 18:35:35 UTC
I am not.  Furthermore, I am not going to reply to insults and provocations.  Your comments are off topic here, so please cease them.
Comment 5 Ulrich Müller gentoo-dev 2019-09-23 04:19:05 UTC
(In reply to Ștefan Talpalaru from comment #1)
> And also why is there no way for ebuilds to opt out of this path- and
> extension-based automated file compression.

Please read the manual again:
https://devmanual.gentoo.org/ebuild-writing/eapi/index.html#eapi=4 ("Helpers", last bullet point),
https://projects.gentoo.org/pms/7/pms.html#x1-13100012.3.11


(In reply to Ștefan Talpalaru from comment #3)
> I ran into this problem with a file called "EULA" that a hardcoded binary
> path forces into "/usr/share/doc/". The only way I found to avoid the
> ecompress plague was to rename it into "EULA.png" and make an "EULA" symlink
> to it.

Where? I don't see any EULA or EULA.png in the ebuild.

> So much for sane tooling design...

Nope.
Comment 6 Ștefan Talpalaru 2019-09-23 05:00:33 UTC
Thanks. "docompress -x <dir>" disables the compression as advertised in that devmanual page about differences between EAPIs.
Comment 7 Larry the Git Cow gentoo-dev 2021-01-18 10:21:31 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=90c82aa2005112d1a9e55cc67db43f7c49d2e4ba

commit 90c82aa2005112d1a9e55cc67db43f7c49d2e4ba
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2021-01-18 10:20:23 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2021-01-18 10:21:22 +0000

    x11-wm/awesome: use 'docompress -x' to handle doc non-compression
    
    Closes: https://bugs.gentoo.org/666414
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 x11-wm/awesome/awesome-4.2-r3.ebuild   | 2 +-
 x11-wm/awesome/awesome-4.3-r100.ebuild | 2 +-
 x11-wm/awesome/awesome-4.3-r2.ebuild   | 2 +-
 x11-wm/awesome/awesome-9999.ebuild     | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)