Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 666314 - dev-haskell/tar-0.5.1.0 version bump
Summary: dev-haskell/tar-0.5.1.0 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Haskell Language team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-15 21:52 UTC by Martin DiViaio
Modified: 2018-09-18 19:23 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin DiViaio 2018-09-15 21:52:27 UTC
Version 0.5.1.0 is now considered stable according to Hackage at https://hackage.haskell.org/package/tar-0.5.1.0 .

Updating this package is a requirement if using ghc version 8.4.3 since the current version of dev-haskell/tar in both ::gentoo and ::haskell (0.5.0.3) fails to compile. (This is a known issue to upstream and it was fixed back in February under https://github.com/haskell/tar/issues/28 .)



Reproducible: Always
Comment 1 Sergei Trofimovich (RETIRED) gentoo-dev 2018-09-16 22:48:46 UTC
Sounds good!
Comment 2 Larry the Git Cow gentoo-dev 2018-09-16 22:49:03 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e19c2094386f4d09d004b54aa0fefcb59f5c9b01

commit e19c2094386f4d09d004b54aa0fefcb59f5c9b01
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2018-09-16 22:48:38 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2018-09-16 22:48:56 +0000

    dev-haskell/tar: bump up to 0.5.1.0, bug #666314
    
    Reported-by: Martin DiViaio
    Closes: https://bugs.gentoo.org/666314
    Package-Manager: Portage-2.3.49, Repoman-2.3.10

 dev-haskell/tar/Manifest           |  1 +
 dev-haskell/tar/tar-0.5.1.0.ebuild | 42 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 43 insertions(+)
Comment 3 PhobosK 2018-09-18 17:08:41 UTC
There is a problem with this commit of the version bump to dev-haskell/tar-0.5.1.0

The DESCRIPTION line ends with an escaped back slash:

DESCRIPTION="Reading, writing and manipulating \\"

Which leads the 'esync' command from app-portage/esearch-1.3-r2 to fail with the message:

esync -v
 * Importing old portage tree
Traceback (most recent call last):
  File "/usr/lib/python-exec/python3.4/esync", line 5, in <module>
    main()
  File "/usr/lib64/python3.4/site-packages/esearch/sync.py", line 304, in main
    success = sync(config)
  File "/usr/lib64/python3.4/site-packages/esearch/sync.py", line 197, in sync
    tree_old = gettree("old", config)
  File "/usr/lib64/python3.4/site-packages/esearch/sync.py", line 132, in gettree
    from esyncoldtree import db
  File "/tmp/esyncoldtree.py", line 3835
    ('tar', 'dev-haskell/tar', False, '0.5.1.0', '0.5.0.3', '38 kB', 'http://hackage.haskell.org/package/tar', 'Reading, writing and manipulating \', 'BSD'),
                                                                                    ^
SyntaxError: invalid syntax



According to this ebuild the file was generated by hackport 0.5.4.9999


So I am not sure where this bug should be fixed... Here or in esearch or in hackport... but I think here the description line ending in an escaped backslash is not a proper one...
Comment 4 Sergei Trofimovich (RETIRED) gentoo-dev 2018-09-18 19:15:00 UTC
(In reply to PhobosK from comment #3)
> There is a problem with this commit of the version bump to
> dev-haskell/tar-0.5.1.0
> 
> The DESCRIPTION line ends with an escaped back slash:
> 
> DESCRIPTION="Reading, writing and manipulating \\"

Yeah. While being valid bash I can see why it's problematic to tools handling backslash. I'll make simpler form of DESCRIPTION.

> Which leads the 'esync' command from app-portage/esearch-1.3-r2 to fail with
> the message:
> 
> esync -v
>  * Importing old portage tree
> Traceback (most recent call last):
>   File "/usr/lib/python-exec/python3.4/esync", line 5, in <module>
>     main()
>   File "/usr/lib64/python3.4/site-packages/esearch/sync.py", line 304, in
> main
>     success = sync(config)
>   File "/usr/lib64/python3.4/site-packages/esearch/sync.py", line 197, in
> sync
>     tree_old = gettree("old", config)
>   File "/usr/lib64/python3.4/site-packages/esearch/sync.py", line 132, in
> gettree
>     from esyncoldtree import db
>   File "/tmp/esyncoldtree.py", line 3835
>     ('tar', 'dev-haskell/tar', False, '0.5.1.0', '0.5.0.3', '38 kB',
> 'http://hackage.haskell.org/package/tar', 'Reading, writing and manipulating
> \', 'BSD'),
>                                                                             
> ^
> SyntaxError: invalid syntax
> 
> 
> 
> According to this ebuild the file was generated by hackport 0.5.4.9999
> 
> 
> So I am not sure where this bug should be fixed... Here or in esearch or in
> hackport... but I think here the description line ending in an escaped
> backslash is not a proper one...

I think both have a bug:
- hackport used to generate nicer DESCRIPTION before (or was it manually cleaned?):
    DESCRIPTION="Reading, writing and manipulating \".tar\" archive files"
- esync/portage should handle trailing backslash in metadata stricter (or stop allowing backslashes)
Comment 5 Larry the Git Cow gentoo-dev 2018-09-18 19:18:51 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8dc3fd83f52077dba601e4750d2f037a5551a7dc

commit 8dc3fd83f52077dba601e4750d2f037a5551a7dc
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2018-09-18 19:18:38 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2018-09-18 19:18:44 +0000

    dev-haskell/tar: fix quoting in DESCRIPTION
    
    (While syntactically valid) truncated DESCRIPTION
        DESCRIPTION="Reading, writing and manipulating \\"
    managed to confuse esync parser: https://bugs.gentoo.org/666314#c3
    
    Fix DESCRIPTION and avoid backslash quoting.
    
    Reported-by: PhobosK
    Bug: https://bugs.gentoo.org/666314
    Package-Manager: Portage-2.3.49, Repoman-2.3.10

 dev-haskell/tar/tar-0.4.0.1.ebuild | 4 ++--
 dev-haskell/tar/tar-0.4.2.1.ebuild | 4 ++--
 dev-haskell/tar/tar-0.5.0.3.ebuild | 4 ++--
 dev-haskell/tar/tar-0.5.1.0.ebuild | 2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)
Comment 6 Sergei Trofimovich (RETIRED) gentoo-dev 2018-09-18 19:23:36 UTC
> I think both have a bug:
> - hackport used to generate nicer DESCRIPTION before (or was it manually
> cleaned?):
>     DESCRIPTION="Reading, writing and manipulating \".tar\" archive files"

Filed hackport bug as: https://github.com/gentoo-haskell/hackport/issues/36

> - esync/portage should handle trailing backslash in metadata stricter (or
> stop allowing backslashes)

Feel free to relay it to app-portage/esearch maintainer: tools-portage@, CC-ed here as well for signal boost)