Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 665518 - =kde-frameworks/kfilemetadata-5.46.0 fails to build on stable amd64 systems with USE="ffmpeg libav"
Summary: =kde-frameworks/kfilemetadata-5.46.0 fails to build on stable amd64 systems w...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on: 617508
Blocks:
  Show dependency tree
 
Reported: 2018-09-08 21:42 UTC by Francisco Blas Izquierdo Riera
Modified: 2018-09-30 08:45 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (build.log,199.53 KB, text/x-log)
2018-09-08 21:42 UTC, Francisco Blas Izquierdo Riera (RETIRED)
Details
Reverse the commit breaking libav builds (fixlibav.patch,5.80 KB, patch)
2018-09-08 21:44 UTC, Francisco Blas Izquierdo Riera (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Francisco Blas Izquierdo Riera (RETIRED) gentoo-dev 2018-09-08 21:42:51 UTC
Created attachment 546290 [details]
Build log

kde-frameworks/kfilemetadata introduced a patch to remove use of the deprecated AVCodecContext structure on the following commit: https://phabricator.kde.org/R286:037208a787e0c2412ab616ff1573c323a2346d2d

The problem is that our current stable version of libav doesn't support the new AVCodecParameters and as a result emerging the package results in the following error:
/var/tmp/portage/kde-frameworks/kfilemetadata-5.46.0/work/kfilemetadata-5.46.0/src/extractors/ffmpegextractor.cpp: In member function ‘virtual void KFileMetaData::FFmpegExtractor::extract(KFileMetaData::ExtractionResult*)’:
/var/tmp/portage/kde-frameworks/kfilemetadata-5.46.0/work/kfilemetadata-5.46.0/src/extractors/ffmpegextractor.cpp:97:15: error: ‘AVCodecParameters’ does not name a type; did you mean ‘AVCodecParser’?
         const AVCodecParameters* codec = stream->codecpar;
               ^~~~~~~~~~~~~~~~~
               AVCodecParser
/var/tmp/portage/kde-frameworks/kfilemetadata-5.46.0/work/kfilemetadata-5.46.0/src/extractors/ffmpegextractor.cpp:99:13: error: ‘codec’ was not declared in this scope
         if (codec->codec_type == AVMEDIA_TYPE_AUDIO || codec->codec_type == AVMEDIA_TYPE_VIDEO) {
             ^~~~~
/var/tmp/portage/kde-frameworks/kfilemetadata-5.46.0/work/kfilemetadata-5.46.0/src/extractors/ffmpegextractor.cpp:99:13: note: suggested alternative: ‘dec’
         if (codec->codec_type == AVMEDIA_TYPE_AUDIO || codec->codec_type == AVMEDIA_TYPE_VIDEO) {
             ^~~~~
             dec
Comment 1 Francisco Blas Izquierdo Riera (RETIRED) gentoo-dev 2018-09-08 21:44:25 UTC
Created attachment 546292 [details, diff]
Reverse the commit breaking libav builds

The attached patch reverses the commit and allows kfilemetadata to compile correctly on my system. I suspect it should only be applied when USE="libav" is used.
Comment 2 Andreas Sturmlechner gentoo-dev 2018-09-08 23:47:46 UTC
Would that be fixed by libav-12?
Comment 3 Larry the Git Cow gentoo-dev 2018-09-21 15:54:02 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e23bcd25cf6cff793271837a5e88665d3e0ce91d

commit e23bcd25cf6cff793271837a5e88665d3e0ce91d
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-09-21 15:43:44 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-09-21 15:53:33 +0000

    kde-frameworks/kfilemetadata: Raise min media-video/libav to 12.2
    
    Closes: https://bugs.gentoo.org/665518
    Package-Manager: Portage-2.3.49, Repoman-2.3.10

 kde-frameworks/kfilemetadata/kfilemetadata-5.46.0.ebuild | 2 +-
 kde-frameworks/kfilemetadata/kfilemetadata-5.50.0.ebuild | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 4 Larry the Git Cow gentoo-dev 2018-09-30 08:45:02 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=db1193bfb8a7c12afb4d1b0c8d24dcc2ed8d0921

commit db1193bfb8a7c12afb4d1b0c8d24dcc2ed8d0921
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-09-21 15:43:44 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-09-30 08:42:26 +0000

    kde-frameworks/kfilemetadata: Raise min media-video/libav to 12.2
    
    Closes: https://bugs.gentoo.org/665518
    Package-Manager: Portage-2.3.49, Repoman-2.3.10

 kde-frameworks/kfilemetadata/kfilemetadata-9999.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)