Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 665352 - www-client/firefox-62.0: WARN Add-on langpack-*@firefox.mozilla.org is not correctly signed
Summary: www-client/firefox-62.0: WARN Add-on langpack-*@firefox.mozilla.org is not co...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-06 11:45 UTC by François Valenduc
Modified: 2018-09-10 07:03 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
screenshot of the list of extensions (Screenshot_20180906_134219.png,108.76 KB, image/png)
2018-09-06 11:45 UTC, François Valenduc
Details

Note You need to log in before you can comment on or make changes to this bug.
Description François Valenduc 2018-09-06 11:45:22 UTC
Created attachment 546054 [details]
screenshot of the list of extensions

After upgrading to firefox 62, it seems that wrong language file are installed, and the french localisation doesn't work anymore. However, it works if I installit manually from the firefox website
Comment 1 Thomas Deutschmann (RETIRED) gentoo-dev 2018-09-06 12:16:06 UTC
Language files are coming from https://archive.mozilla.org/pub/firefox/releases/62.0/linux-i686/xpi/. At the moment I don't know what's wrong with the files.
Comment 3 Larry the Git Cow gentoo-dev 2018-09-07 17:15:58 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=52716463ca346792b17cb994b9cf77639def040d

commit 52716463ca346792b17cb994b9cf77639def040d
Author:     Ian Stakenvicius <axs@gentoo.org>
AuthorDate: 2018-09-07 17:11:43 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2018-09-07 17:15:31 +0000

    www-client/firefox: install language packs as XPI file
    
    Unpacked extensions are no longer supported. [Link 1]
    
    Link 1: https://blog.mozilla.org/addons/2018/02/22/removing-support-unpacked-extensions/
    Closes: https://bugs.gentoo.org/665352
    Package-Manager: Portage-2.3.49, Repoman-2.3.10

 eclass/mozextension.eclass                | 30 ++++++++++++++++++++++++++++++
 eclass/mozlinguas-v2.eclass               | 14 ++++++++++++--
 www-client/firefox/firefox-62.0-r1.ebuild |  2 +-
 3 files changed, 43 insertions(+), 3 deletions(-)
Comment 4 Fab 2018-09-07 18:59:49 UTC
It seems that firefox-bin is also affected.
Maybe it should also be revbumped.

And, as a side note (and maybe I'm missing something), if xpi files are now installed without being unpacked, what is the purpose of :
>
> src_unpack() {
>    unpack ${A}
>
>    # Unpack language packs
>    mozlinguas_src_unpack
>}

Thanks.
Comment 5 Ian Stakenvicius (RETIRED) gentoo-dev 2018-09-08 00:21:02 UTC
(In reply to Fab from comment #4)
> It seems that firefox-bin is also affected.
> Maybe it should also be revbumped.
> 
> And, as a side note (and maybe I'm missing something), if xpi files are now
> installed without being unpacked, what is the purpose of :
> >
> > src_unpack() {
> >    unpack ${A}
> >
> >    # Unpack language packs
> >    mozlinguas_src_unpack
> >}
> 
> Thanks.

In order to properly ensure XPIs are installed with the correct EMID, said EMID needs to be read from the manifest.  XPI management isn't limited to langpacks, it's common to extensions as well.

At this point, this solution is the path of least resistance.  Mozilla team is hoping that there will be a way to build locales directly soon in a way that they are fully integrated into the base installation, however that will not be ready any time soon (assuming it is possible at all) and so this (unpacking, reading the EMID, and then installing the XPI with said EMID) is an interim workaround.