Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 665220 - dev-ruby/net-ssh-5.0.2: version bump
Summary: dev-ruby/net-ssh-5.0.2: version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Ruby Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 667012
  Show dependency tree
 
Reported: 2018-09-04 12:22 UTC by Tomáš Mózes
Modified: 2018-09-25 18:46 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
bump patch (0001-dev-ruby-net-ssh-version-bump-to-5.0.2.patch,2.81 KB, patch)
2018-09-25 06:23 UTC, Georgy Yakovlev
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomáš Mózes 2018-09-04 12:22:42 UTC
Needed by newer vagrant.

A copy from 4.2.0 seems to do the trick.
Comment 1 Tomáš Mózes 2018-09-04 12:23:00 UTC
Thank you :)
Comment 2 Hans de Graaff gentoo-dev Security 2018-09-05 04:47:41 UTC
Do all tests pass? I see test failures:

F

Failure:
Authentication::TestSession#test_uses_some_default_keys_if_none_are_provided [/var/tmp/portage/dev-ruby/net-ssh-5.0.2/work/ruby23/net-ssh-5.0.2/test/authentication/test_session.rb:113]:
--- expected
+++ actual
@@ -1,10 +1,11 @@
+# encoding: ASCII-8BIT
 "-----BEGIN PUBLIC KEY-----
-MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAxbz0rp+Z7MklMtSkfiRf
-ceOeTOhOgkGqonCL1B0MRzSjA3yfonvEobQNYv7uyQ+ZMGT9RL7AlUSUxeWF00A/
-O6kuwfs4JlPS/FMPy/B2V0UmoteTp40LmclZHpKZs9yKmgkfa5j8Jjvd/VvV1r/D
-bkHjZetIe07pSnP3EOAG7sjyV7yrHPvkgG5h/Vn2U19vTsvYIENcj5OCLF7eUSJZ
-/6m4qem+wZ4/9cau5E2t57oS8bTd5k00Jn0E+qRVionLVLtHXKnr0nWlGPinL+Uh
-KBMhLA6Olm5Y8W77sYcUSvlJMy4GmpIvnWFKQE5vim4zKt3dBF256QPmRCWPTQ+s
-xwIDAQAB
+MIIBIDANBgkqhkiG9w0BAQEFAAOCAQ0AMIIBCAKCAQEA4dRFGfQqjS+k6SI5SX21
+8vZjVUlaANnl3PtaYdHEh1bPeLWlqSIZSL6n6ejaLCmtv/MTh7HpKkY0CvG9yRl5
+r+zT9OW+8asgGUZXqpGeG8FT4MSXfzp2tJrOBcBUDS5/+43Kn13OhvqcarWVZ9fG
+IHtwmlisM7tQ2zpiNxdmlp09EwiJzChn6/f7Xye+DgPNe2lVyBJ3GrWmE2ZJFFfz
+DIoHBln3mqaQmoHfT0Lk971wSDlfewgIt2XtRmnNFIT5sKr9lfb+m5zcU1tGizQx
+yZGy6LOg3GJmXQxJOrTnKlsVhInUJ0Ao74HajYAa/+7emkaCsZxAo88wftR3Ufpd
+RQIBIw==
 -----END PUBLIC KEY-----
 "
Comment 3 Tomáš Mózes 2018-09-05 07:06:18 UTC
>>> Test phase: dev-ruby/net-ssh-5.0.2
 * Running test phase for ruby23 ...
Run options: --seed 9378

# Running:

.......................................................Mocha deprecation warning at /var/tmp/portage/dev-ruby/net-ssh-5.0.2/work/ruby23/net-ssh-5.0.2/test/connection/test_session.rb:314:in `test_channel_close_packet_should_be_routed_to_corresponding_channel_and_channel_should_be_closed_and_removed': Passing a block is deprecated. Use Object#tap or define stubs/expectations with an explicit receiver instead.
.........................................................................................................................................................................................................................................................................................................................................../var/tmp/portage/dev-ruby/net-ssh-5.0.2/work/ruby23/net-ssh-5.0.2/lib/net/ssh/transport/openssl.rb:160: warning: instance variable @group not initialized
./var/tmp/portage/dev-ruby/net-ssh-5.0.2/work/ruby23/net-ssh-5.0.2/lib/net/ssh/transport/openssl.rb:160: warning: instance variable @group not initialized
...../var/tmp/portage/dev-ruby/net-ssh-5.0.2/work/ruby23/net-ssh-5.0.2/lib/net/ssh/transport/openssl.rb:160: warning: instance variable @group not initialized
./var/tmp/portage/dev-ruby/net-ssh-5.0.2/work/ruby23/net-ssh-5.0.2/lib/net/ssh/transport/openssl.rb:160: warning: instance variable @group not initialized
......../var/tmp/portage/dev-ruby/net-ssh-5.0.2/work/ruby23/net-ssh-5.0.2/lib/net/ssh/transport/openssl.rb:160: warning: instance variable @group not initialized
.........../var/tmp/portage/dev-ruby/net-ssh-5.0.2/work/ruby23/net-ssh-5.0.2/lib/net/ssh/transport/openssl.rb:160: warning: instance variable @group not initialized
......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

Finished in 3.373253s, 460.6829 runs/s, 1542.7246 assertions/s.

1554 runs, 5204 assertions, 0 failures, 0 errors, 0 skips
 * Running test phase for ruby24 ...
Run options: --seed 62

# Running:

..........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................Mocha deprecation warning at /var/tmp/portage/dev-ruby/net-ssh-5.0.2/work/ruby24/net-ssh-5.0.2/test/connection/test_session.rb:314:in `test_channel_close_packet_should_be_routed_to_corresponding_channel_and_channel_should_be_closed_and_removed': Passing a block is deprecated. Use Object#tap or define stubs/expectations with an explicit receiver instead.
........

Finished in 3.284664s, 473.1078 runs/s, 1584.3327 assertions/s.

1554 runs, 5204 assertions, 0 failures, 0 errors, 0 skips
 * Running test phase for ruby25 ...
Run options: --seed 6115

# Running:

..........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................Mocha deprecation warning at /var/tmp/portage/dev-ruby/net-ssh-5.0.2/work/ruby25/net-ssh-5.0.2/test/connection/test_session.rb:314:in `test_channel_close_packet_should_be_routed_to_corresponding_channel_and_channel_should_be_closed_and_removed': Passing a block is deprecated. Use Object#tap or define stubs/expectations with an explicit receiver instead.
........................................................................................................................................................................................................................................................................................................................................

Finished in 3.339343s, 465.3609 runs/s, 1558.3902 assertions/s.

1554 runs, 5204 assertions, 0 failures, 0 errors, 0 skips
>>> Completed testing dev-ruby/net-ssh-5.0.2
Comment 4 Georgy Yakovlev archtester gentoo-dev 2018-09-25 06:23:43 UTC
Created attachment 547852 [details, diff]
bump patch

ssh agent socket is to blame.
with provided patch/ebuild all tests pass, but I only tested latest ruby.
Comment 5 Georgy Yakovlev archtester gentoo-dev 2018-09-25 06:43:27 UTC
also it seems upstream removed sodium and everything migrated to dev-ruby/ed25519 which is kinda optional.
provided ebuild depends on dev-ruby/ed25519 but it's possible to use NET_SSH_NO_ED25519=true to disable the usage, not sure if it's needed.

dev-ruby/ed25519 is only keyworded on ~amd64 tho.
Comment 6 Tomáš Mózes 2018-09-25 06:55:26 UTC
Tests pass on ~amd64 on ruby23/24/25, thanks you Georgy.
Comment 7 Hans de Graaff gentoo-dev Security 2018-09-25 17:44:42 UTC
(In reply to Georgy Yakovlev from comment #4)

> ssh agent socket is to blame.
> with provided patch/ebuild all tests pass, but I only tested latest ruby.

Good find! Thanks.
Comment 8 Larry the Git Cow gentoo-dev 2018-09-25 18:05:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=506ab926668706571918240f88b187f60d1b19da

commit 506ab926668706571918240f88b187f60d1b19da
Author:     Hans de Graaff <graaff@gentoo.org>
AuthorDate: 2018-09-25 18:04:59 +0000
Commit:     Hans de Graaff <graaff@gentoo.org>
CommitDate: 2018-09-25 18:04:59 +0000

    dev-ruby/net-ssh: add 5.0.2
    
    Thanks to gyakovlel for tracking down the cause of test failures in bug 665220
    
    Drop arm, ppc, ppc64, x86 keywords due to new dependency on ed25519, bug 667070
    
    Closes: https://bugs.gentoo.org/665220
    Package-Manager: Portage-2.3.49, Repoman-2.3.10

 dev-ruby/net-ssh/Manifest             |  1 +
 dev-ruby/net-ssh/metadata.xml         |  1 +
 dev-ruby/net-ssh/net-ssh-5.0.2.ebuild | 38 +++++++++++++++++++++++++++++++++++
 3 files changed, 40 insertions(+)
Comment 9 Tomáš Mózes 2018-09-25 18:46:51 UTC
Thanks