Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 665158 - games-server/steamcmd-1.0: Should not have default variables set in openrc config
Summary: games-server/steamcmd-1.0: Should not have default variables set in openrc co...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal minor (vote)
Assignee: Conrad Kostecki
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-03 12:41 UTC by tastytea
Modified: 2018-09-10 13:23 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tastytea 2018-09-03 12:41:00 UTC
I installed a game server that needed no options, so I commented STEAMCMD_OPTS out. I expected the variable to be empty, instead it was set to options for Half Life. If I set the variable to "", the openrc service won't start.

Please comment the variables in /etc/conf.d/steamcmd out and make it possible to have an empty STEAMCMD_OPTS.

Reproducible: Always

Steps to Reproduce:
1. Install a game server that need no options (Starbound)
2. Create /etc/conf.d/steamcmd.foo
3. Comment STEAMCMD_OPTS out
4. Start openrc service script
Actual Results:  
Openrc used the commandline options from /etc/conf.d/steamcmd, the server crashed.

Expected Results:  
Empty STEAMCMD_OPTS.

Workaround: Set STEAMCMD_OPTS=" "
Comment 1 Conrad Kostecki gentoo-dev 2018-09-04 21:40:03 UTC
(In reply to tastytea from comment #0)
> Please comment the variables in /etc/conf.d/steamcmd out and make it
> possible to have an empty STEAMCMD_OPTS.

Thanks for the report! Agreed. Will comment them out.
Comment 2 Larry the Git Cow gentoo-dev 2018-09-10 13:23:38 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=adddad6312b1de41a1570d2529cf71fdb68d25fb

commit adddad6312b1de41a1570d2529cf71fdb68d25fb
Author:     Conrad Kostecki <conrad@kostecki.com>
AuthorDate: 2018-09-04 21:23:54 +0000
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: 2018-09-10 13:23:28 +0000

    games-server/steamcmd: don't set default values for conf.d.
    
    Also bump to EAPI=7.
    
    Closes: https://bugs.gentoo.org/665158
    Package-Manager: Portage-2.3.48, Repoman-2.3.10
    Closes: https://github.com/gentoo/gentoo/pull/9781

 games-server/steamcmd/files/steamcmd.confd-r1 | 15 ++++++++
 games-server/steamcmd/files/steamcmd.initd-r1 | 32 +++++++++++++++++
 games-server/steamcmd/steamcmd-1.0-r1.ebuild  | 51 +++++++++++++++++++++++++++
 3 files changed, 98 insertions(+)