Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 665148 - dev-python/paho-mqtt-1.4.0 version bump
Summary: dev-python/paho-mqtt-1.4.0 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Rage <oxr463>
URL: https://gitlab.com/lramage94/gentoo/i...
Whiteboard:
Keywords: EBUILD, PATCH
Depends on:
Blocks:
 
Reported: 2018-09-03 09:27 UTC by Neil Bothwick
Modified: 2018-10-18 11:33 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
dev-python/paho-mqtt: bump version to 1.4.0 (0001-dev-python-paho-mqtt-bump-version-to-1.4.0.patch,3.89 KB, patch)
2018-09-22 19:29 UTC, Rage <oxr463>
Details | Diff
dev-python/paho-mqtt: bump version to 1.4.0 (0001-dev-python-paho-mqtt-bump-version-to-1.4.0.patch,4.51 KB, patch)
2018-09-28 19:12 UTC, Rage <oxr463>
Details | Diff
dev-python/paho-mqtt: bump version to 1.4.0 (0001-dev-python-paho-mqtt-bump-version-to-1.4.0.patch,4.51 KB, patch)
2018-10-17 12:47 UTC, Rage <oxr463>
Details | Diff
dev-python/paho-mqtt: bump version to 1.4.0 (0001-dev-python-paho-mqtt-bump-version-to-1.4.0.patch,3.34 KB, patch)
2018-10-17 22:35 UTC, Rage <oxr463>
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Neil Bothwick 2018-09-03 09:27:25 UTC
Version 1.4.0 has been released, renaming the ebuild and associated patch file works here.
Comment 1 Rage <oxr463> 2018-09-22 19:29:29 UTC
Created attachment 547532 [details, diff]
dev-python/paho-mqtt: bump version to 1.4.0
Comment 2 Rage <oxr463> 2018-09-28 19:12:46 UTC
Created attachment 548136 [details, diff]
dev-python/paho-mqtt: bump version to 1.4.0
Comment 3 Virgil Dupras (RETIRED) gentoo-dev 2018-10-11 19:03:55 UTC
Lucas: thanks for the bump, but I see that the patch you add is exactly the same as the previous one. It's not uncommon, in ebuilds, to reuse patches from previous versions until they cease applying cleanly. Instead of referring to it with ${P}, you could use ${PN}-1.3. It makes a cleaner filesdir.
Comment 4 Virgil Dupras (RETIRED) gentoo-dev 2018-10-12 03:01:57 UTC
Oh, here a funny event. Just as I'm talking about this patch naming convention, here's an example of why we generally do this at bug 668410 :)
Comment 5 Rage <oxr463> 2018-10-17 12:47:40 UTC
Created attachment 551654 [details, diff]
dev-python/paho-mqtt: bump version to 1.4.0

Here is a new patch with the suggested change
Comment 6 Virgil Dupras (RETIRED) gentoo-dev 2018-10-17 13:27:45 UTC
I don't see how your new patch took my suggestions into account: you still have two files in "files" with the exact same content.
Comment 7 Rage <oxr463> 2018-10-17 22:35:12 UTC
Created attachment 551762 [details, diff]
dev-python/paho-mqtt: bump version to 1.4.0

Oops! I accidentally uploaded the old version.
Comment 8 Virgil Dupras (RETIRED) gentoo-dev 2018-10-18 11:31:31 UTC
I'm merging. Areas of enhancements for the next bump:

1. EAPI 7
2. py37?
3. get rid of the pytest-runner dep and call pytest directly.
4. use PATCHES variable instead of eapply.
Comment 9 Larry the Git Cow gentoo-dev 2018-10-18 11:33:31 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3282dc2a83ca47c061c8a9f3176e595837171922

commit 3282dc2a83ca47c061c8a9f3176e595837171922
Author:     Lucas Ramage <ramage.lucas@protonmail.com>
AuthorDate: 2018-09-22 19:27:03 +0000
Commit:     Virgil Dupras <vdupras@gentoo.org>
CommitDate: 2018-10-18 11:33:18 +0000

    dev-python/paho-mqtt: bump version to 1.4.0
    
    Signed-off-by: Lucas Ramage <ramage.lucas@protonmail.com>
    Closes: https://bugs.gentoo.org/665148
    Package-Manager: Portage-2.3.24, Repoman-2.3.6
    Signed-off-by: Virgil Dupras <vdupras@gentoo.org>

 dev-python/paho-mqtt/Manifest               |  1 +
 dev-python/paho-mqtt/metadata.xml           |  2 +-
 dev-python/paho-mqtt/paho-mqtt-1.4.0.ebuild | 37 +++++++++++++++++++++++++++++
 3 files changed, 39 insertions(+), 1 deletion(-)