Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 664998 - x11-libs/gtk+-2.24.32 breaks mate-extra/mate-screensaver-1.12.0-r1
Summary: x11-libs/gtk+-2.24.32 breaks mate-extra/mate-screensaver-1.12.0-r1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-31 21:25 UTC by Carl Michal
Modified: 2018-10-22 22:59 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge.info,6.00 KB, application/x-info)
2018-08-31 21:25 UTC, Carl Michal
Details
build.log for gtk+-2.24.32 (build.log.xz,55.38 KB, application/x-xz)
2018-09-01 08:19 UTC, Carl Michal
Details
upstream patch for this issue (0012-activate-window-on-keyboard-grabs.patch,3.41 KB, patch)
2018-09-07 15:51 UTC, Carl Michal
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carl Michal 2018-08-31 21:25:39 UTC
Created attachment 545674 [details]
emerge --info

After a recent emerge -uD world, mate-screesaver no longer worked properly. It would lock the screen, but didn't grab the keyboard focus, so you couldn't type a password in to unlock. This has been seen elsewhere, see:
https://github.com/mate-desktop/mate-screensaver/issues/156

I tracked this back to an updated version of gtk+. With gtk+-2.24.31-r1, it works as expected, but with gtk+-2.24.32 mate-screensaver doesn't get focus and can't be unlocked.

I have mate-1.12, but on that link above, the same problem has been seen with 1.16
Comment 1 Jonas Stein gentoo-dev 2018-09-01 06:19:00 UTC
Thank you for the report. Please recompile and 
*attach* the logfiles and 
paste the emerge info as described on
https://wiki.gentoo.org/wiki/Attach_the_logs_to_the_bug_ticket
The logs must be part of the ticket, but not on external websites.
Write the full package name in the summary of the ticket.
Please reopen this ticket (Status:unconfirmed) afterwards.
Comment 2 Carl Michal 2018-09-01 08:19:09 UTC
Created attachment 545704 [details]
build.log for gtk+-2.24.32
Comment 3 Carl Michal 2018-09-01 08:27:25 UTC
emerge --info =x11-libs/gtk+-2.24.32

Portage 2.3.40 (python 3.6.5-final-0, default/linux/amd64/17.0/desktop, gcc-7.3.0, glibc-2.26-r7, 4.12.5-gentoo x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-4.12.5-gentoo-x86_64-Intel-R-_Core-TM-_i7-3770_CPU_@_3.40GHz-with-gentoo-2.4.1
KiB Mem:     7845072 total,   3779204 free
KiB Swap:    2097148 total,   2081704 free
Timestamp of repository gentoo: Tue, 28 Aug 2018 17:00:01 +0000
Head commit of repository gentoo: e79b34070c2735c24de828be78b4d86d86695df8
sh bash 4.4_p12
ld GNU ld (Gentoo 2.30 p2) 2.30.0
app-shells/bash:          4.4_p12::gentoo
dev-java/java-config:     2.2.0-r4::gentogto
dev-lang/perl:            5.24.3-r1::gentoo
dev-lang/python:          2.7.14-r1::gentoo, 3.6.5::gentoo
dev-util/cmake:           3.9.6::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.4.1-r2::gentoo
sys-apps/openrc:          0.34.11::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.11.6-r3::gentoo, 1.13.4-r2::gentoo, 1.15.1-r2::gentoo
sys-devel/binutils:       2.30-r2::gentoo
sys-devel/gcc:            5.4.0-r3::gentoo, 7.3.0-r3::gentoo
sys-devel/gcc-config:     1.8-r1::gentoo
sys-devel/libtool:        2.4.6-r3::gentoo
sys-devel/make:           4.2.1-r3::gentoo
sys-kernel/linux-headers: 4.13::gentoo (virtual/os-headers)
sys-libs/glibc:           2.26-r7::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-metamanifest: yes
    sync-rsync-extra-opts: 
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-jobs: 1

x-portage
    location: /usr/local/portage
    masters: gentoo
    priority: 0

perl-experimental
    location: /var/lib/layman/perl-experimental
    masters: gentoo
    priority: 50

science
    location: /var/lib/layman/science
    masters: gentoo
    priority: 50

x11
    location: /var/lib/layman/x11
    masters: gentoo
    priority: 50

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native -fomit-frame-pointer"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe -march=native -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_CA.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en"
MAKEOPTS="-j8"
PKGDIR="/var/tmp/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi alsa amd64 berkdb bluetooth branding bzip2 cairo cdda cdr classic cli consolekit crypt cups cxx dbus dri dts dvd dvdr emboss encode exif fam flac fortran gallium gdbm gif glamor gpm gtk iconv icu ipv6 jpeg lcms ldap libnotify libtirpc mad mmx mng modules mp3 mp4 mpeg mpeg4 multilib ncurses nls nptl ogg opengl openmp openssl pam pango pcre pdf pm-utils png policykit ppds pulseaudio qt5 readline sdl seccomp spell sse sse2 ssl ssse3 startup-notification svg tcpd tiff truetype udev udisks unicode upower usb vaapi vdpau vorbis vpx wxwidgets x264 xattr xcb xinerama xml xv xvid zlib" ABI_X86="64 32" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon plan sheets stage words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="keyboard mouse evdev wacom" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-0" POSTGRES_TARGETS="postgres9_5 postgres10" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6" RUBY_TARGETS="ruby23" USERLAND="GNU" VIDEO_CARDS="intel i965" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

x11-libs/gtk+-2.24.32::gentoo was built with the following:
USE="cups introspection xinerama (-aqua) -examples -test -vim-syntax" ABI_X86="32 (64) (-x32)"
CFLAGS="-O2 -pipe -march=native"
CXXFLAGS="-O2 -pipe -march=native"
Comment 4 Carl Michal 2018-09-01 17:37:57 UTC
I think I've got to the bottom of this.

In the gtk+-2.24.32 ebuild, the source is modified with gtk+-2.24.32-patchset
Within that patchset, the final patch is:
0011-gdk-do-not-deactivate-surface-on-keyboard-grabs.patch

That seems to be the source of this problem.

I built gtk+-2.24.32 from the gnome git repo, and it doesn't have the problem. When I apply all of the patches in that patchset except for 0011, then there is still no problem. But then when that patch is applied, the problem arises.
Comment 5 Carl Michal 2018-09-01 20:21:37 UTC
Some more information. It looks like this problem was recognized with that 0011 patch, see the last comment here:

https://gitlab.gnome.org/GNOME/gtk/merge_requests/120
Comment 6 Mart Raudsepp gentoo-dev 2018-09-01 23:06:59 UTC
Thanks. Yeah, -r1 has a bunch of stuff from upstream 2-24 branch that happened to be there at the time. Just updating that patchset to have all the newer patches in that branch will do here, right?
If yes, I can try to get to that within 1-3 days.

That said, MATE should just use gtk3 and there should be no trouble. In fact it does, but in ~arch version that's long overdue for stabling. MATE project needs help. I can help soon with a stabilization list of MATE 1.18 from our GNOME scripts, but that just gets stable to 1.18 - other things are still in need of help badly for MATE in Gentoo.
Comment 7 Carl Michal 2018-09-02 00:08:49 UTC
It does look like there is a later patch to fix this in gtk+, though it looked to me like it was only fixed in gtk+3 - I couldn't find a fix in gtk+2. I must admit to not looking too hard though. Just leaving the 0011 patch out of the current patchset makes things work for me.
Comment 8 Fred 2018-09-03 09:08:52 UTC
I can also confirm that with gtk+-2.24.32 I can't enter my password into mate-screensaver-1.16.1's unlock dialogue and that with gtk+-2.24.31-r1 I can. I believe this will affect anyone running mate with GTK2. When I temporarily upgraded to mate-1.20, which is GTK3 based, I didn't have this issue.
Comment 9 Carl Michal 2018-09-07 15:51:28 UTC
Created attachment 546184 [details, diff]
upstream patch for this issue

In the mate bug here
https://github.com/mate-desktop/mate-screensaver/issues/156#issuecomment-419426518

the author of the problematic patch pointed to the correct fix for this problem, it is commit:

853f786727a954d10ed78405adc18e0772ccd1cb

Attached here. Any chance this could be added as an -r1?

I have applied this and verified it does solve the problem.
Comment 10 Mart Raudsepp gentoo-dev 2018-09-07 18:56:12 UTC
I'll get to it soon. But I think my time is better spent helping push MATE 1.18 to stable first :)
Comment 11 Larry the Git Cow gentoo-dev 2018-09-09 00:13:19 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9f6c0642bd0b58aadaf7bc18a0864ce097eaf13e

commit 9f6c0642bd0b58aadaf7bc18a0864ce097eaf13e
Author:     Mart Raudsepp <leio@gentoo.org>
AuthorDate: 2018-09-09 00:11:08 +0000
Commit:     Mart Raudsepp <leio@gentoo.org>
CommitDate: 2018-09-09 00:11:52 +0000

    x11-libs/gtk+: Update 2.24.32 patchset from upstream branch
    
    Closes: https://bugs.gentoo.org/664998
    Package-Manager: Portage-2.3.49, Repoman-2.3.10

 x11-libs/gtk+/Manifest               |   1 +
 x11-libs/gtk+/gtk+-2.24.32-r1.ebuild | 306 +++++++++++++++++++++++++++++++++++
 2 files changed, 307 insertions(+)