Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 664266 - =net-dialup/openl2tp-1.8 ebuild fails to correctly configure
Summary: =net-dialup/openl2tp-1.8 ebuild fails to correctly configure
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Andrew Savchenko
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-22 15:22 UTC by Jaco Kroon
Modified: 2018-08-23 05:13 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
updated openl2tp-1.8.ebuild (openl2tp-1.8.ebuild,3.67 KB, text/plain)
2018-08-22 15:22 UTC, Jaco Kroon
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jaco Kroon 2018-08-22 15:22:13 UTC
Created attachment 544466 [details]
updated openl2tp-1.8.ebuild

the ebuild relies on global variables being passed from one phase of the build to the next, this doesn't actually happen.

I've added echo statements at the start of compile and install phases, and end for configure of each phase function:

echo "myconf (${EBUILD_PHASE})="${myconf[*]}"

This is the output generated indicating that these parameters are in fact NOT carried over:

myconf (configure)=L2TP_FEATURE_RPC_MANAGEMENT=n
myconf (compile)=
myconf (install)=

I'm assuming the PPP_SUBDIR variable that is explicitly unset in same also won't pull through.  As such I propose to replace the current ebuild with the attached (which uses sed to modify the Makefile as required), however, this variable is already not used any more.

I can write an alternate version that still passes the configuration options as parameters but would require going through the USE flags twice.

You may also want to fix the sleepinng spelling mistake in the init script for stop().
Comment 1 Larry the Git Cow gentoo-dev 2018-08-23 02:29:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=583870dcd2fb795e6fafb83f47a9bc5e96f175ea

commit 583870dcd2fb795e6fafb83f47a9bc5e96f175ea
Author:     Andrew Savchenko <bircoph@gentoo.org>
AuthorDate: 2018-08-23 02:26:07 +0000
Commit:     Andrew Savchenko <bircoph@gentoo.org>
CommitDate: 2018-08-23 02:29:31 +0000

    net-dialup/openl2tp: configure openl2tpd correctly
    
    - Pass configuration data properly to the emake.
    - Update to EAPI 7.
    
    Thanks Jako Kroon [jaco uls.co.za] for noticing the problem.
    
    Closes: https://bugs.gentoo.org/664266
    Signed-off-by: Andrew Savchenko <bircoph@gentoo.org>
    Package-Manager: Portage-2.3.48, Repoman-2.3.10

 net-dialup/openl2tp/openl2tp-1.8-r1.ebuild | 126 +++++++++++++++++++++++++++++
 1 file changed, 126 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=70e863ab94747fbfc26fb470203d7d08164f105f

commit 70e863ab94747fbfc26fb470203d7d08164f105f
Author:     Andrew Savchenko <bircoph@gentoo.org>
AuthorDate: 2018-08-23 02:22:13 +0000
Commit:     Andrew Savchenko <bircoph@gentoo.org>
CommitDate: 2018-08-23 02:29:30 +0000

    net-dialup/openl2tp: fix spelling
    
    Fix spelling in the init script.
    
    Bug: https://bugs.gentoo.org/664266
    Signed-off-by: Andrew Savchenko <bircoph@gentoo.org>
    Package-Manager: Portage-2.3.48, Repoman-2.3.10

 net-dialup/openl2tp/files/openl2tpd.initd | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 2 Andrew Savchenko gentoo-dev 2018-08-23 02:33:10 UTC
Thanks for noticing these problems. Looks like I missed a moment when portage became strict on filtering environment variables.

However, I selected an approach different to your proposal: make options are being passed using temporary file in ${T}. This way it should be easier to update in future.
Comment 3 Jaco Kroon 2018-08-23 05:13:53 UTC
Also good.  Thanks for the quick fix.