Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 664096 - x11-drivers/xf86-input-tslib: Last rites
Summary: x11-drivers/xf86-input-tslib: Last rites
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords: PMASKED
Depends on:
Blocks:
 
Reported: 2018-08-20 08:43 UTC by Pär Karlsson
Modified: 2018-12-02 07:53 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log from x11-drivers/xf86-input-tslib-1.2.0_rc1 (build.log.xz,3.36 KB, application/x-xz)
2018-08-20 08:43 UTC, Pär Karlsson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pär Karlsson 2018-08-20 08:43:36 UTC
Created attachment 544084 [details]
build.log from x11-drivers/xf86-input-tslib-1.2.0_rc1

The x11-drivers/xf86-input-tslib-1.2.0_rc1 package fails to build.

Portage 2.3.40 (python 3.6.5-final-0, default/linux/amd64/17.0/desktop/gnome/systemd, gcc-7.3.0, glibc-2.26-r7, 4.14.65-gentoo x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-4.14.65-gentoo-x86_64-Intel-R-_Core-TM-_i7-7700HQ_CPU_@_2.80GHz-with-gentoo-2.4.1
KiB Mem:    16275956 total,   6558072 free
KiB Swap:   16383996 total,  16383996 free
Timestamp of repository gentoo: Mon, 20 Aug 2018 07:30:01 +0000
Head commit of repository gentoo: 8ec1bfd17abdb15b8a61d9624c12a6d9dab086d4
sh bash 4.4_p12
ld GNU ld (Gentoo 2.30 p2) 2.30.0
app-shells/bash:          4.4_p12::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.24.3-r1::gentoo
dev-lang/python:          2.7.14-r1::gentoo, 3.6.5::gentoo
dev-util/cmake:           3.9.6::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.4.1-r2::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.11.6-r3::gentoo, 1.15.1-r2::gentoo
sys-devel/binutils:       2.30-r2::gentoo
sys-devel/gcc:            7.3.0-r3::gentoo
sys-devel/gcc-config:     1.8-r1::gentoo
sys-devel/libtool:        2.4.6-r3::gentoo
sys-devel/make:           4.2.1-r3::gentoo
sys-kernel/linux-headers: 4.13::gentoo (virtual/os-headers)
sys-libs/glibc:           2.26-r7::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-metamanifest: yes
    sync-rsync-extra-opts: 

eclipse
    location: /var/lib/layman/eclipse
    sync-type: laymansync
    sync-uri: https://github.com/gentoo/eclipse-overlay.git
    masters: gentoo
    priority: 50

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.6/ext-active/ /etc/php/apache2-php7.1/ext-active/ /etc/php/cgi-php5.6/ext-active/ /etc/php/cgi-php7.1/ext-active/ /etc/php/cli-php5.6/ext-active/ /etc/php/cli-php7.1/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe"
DISTDIR="/usr/portage/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news nostrip parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://mirror.mdfnet.se/gentoo"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j8"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac aalib acl acpi alsa amd64 audit bash-completion berkdb bluetooth branding bzip2 cairo caps cdda cdr clamav cli colord crypt cscope ctype cups curl cvs cxx dbi dbus djvu dri dts dvb dvd dvdr eds emacs emboss encode enscript evo exif expat fam fastcgi ffmpeg fftw flac fontconfig fortran freetds ftp gcj gd gdbm geoip geolocation ggi gif gimp git glamor glut gmp gnome gnome-keyring gnome-online-accounts gnuplot gphoto2 gpm gps graphviz gstreamer gtk guile gzip hdf5 hscolour iconv icu idn imagemagick imap inifile inotify introspection ios ipv6 jack java javascript jbig jit jpeg jpeg2k kerberos ladspa lapack lash latex lcms ldap libass libcaca libnotify libsamplerate libsecret libtirpc lm_sensors lua lzma lzo mad maildir matroska mime mmap mms mng modplug modules mono mozilla mp3 mp4 mpeg mpi mplayer mssql mtp multilib musepack musicbrainz mysql mysqli nautilus ncurses networkmanager nls nptl ocaml ocamlopt odbc offensive ofx ogg openal openexr opengl openmp oracle pam pango pcntl pcre pdf perl php pie plotutils png policykit posix postgres postscript ppds profile pulseaudio python qt5 quicktime radius raw rdp readline recode rss ruby samba sasl sctp sdl seamonkey seccomp session sharedmem shorten simplexml smartcard smp snmp soap sockets sound source sox speex spell sqlite ssl startup-notification subversion svg systemd tcmalloc tcpd theora threads tidy tiff timidity tracker truetype udev udisks unicode upnp upnp-av upower usb v4l vaapi vala vdpau vim-syntax vnc vorbis wavpack wayland wddx webp wifi wmf wxwidgets x264 xattr xcb xcomposite xface xft xine xinerama xml xmlrpc xmp xmpp xpm xscreensaver xv xvid zeroconf zlib" ABI_X86="32 64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon plan sheets stage words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2 aes avx avx2 f16c fma3 pclmul popcnt sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="elographics evdev wacom keyboard mouse libinput synaptics tslib" KERNEL="linux" L10N="en en-AU en-GB en-US sv" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="nlpsolver scripting-beanshell scripting-javascript wiki-publisher" LLVM_TARGETS="AMDGPU BPF NVPTX AArch64 ARM Hexagon Lanai MSP430 Mips PowerPC Sparc SystemZ XCore" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-0" POSTGRES_TARGETS="postgres9_5 postgres10" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6" QEMU_SOFTMMU_TARGETS="x86_64 aarch64 alpha arm cris i386 lm32 m68k microblaze microblazeel mips mips64 mips64el mipsel moxie nios2 or1k ppc ppc64 ppcemb s390x sh4 sh4eb sparc sparc64 tricore unicore32 xtensa xtensaeb" QEMU_USER_TARGETS="aarch64 alpha arm armeb cris hppa i386 m68k microblaze microblazeel mips mips64 mips64el mipsel mipsn32 mipsn32el nios2 or1k ppc ppc64 ppc64abi32 ppc64le s390x sh4 sh4eb sparc sparc32plus sparc64 tilegx x86_64" RUBY_TARGETS="ruby23" USERLAND="GNU" VIDEO_CARDS="i915 i965 intel nvidia v4l virgl" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

x11-drivers/xf86-input-tslib-0.0.6-r3::gentoo was built with the following:
USE="" ABI_X86="(64)"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,-z,lazy"
Comment 1 Chí-Thanh Christopher Nguyễn gentoo-dev 2018-08-20 09:01:52 UTC
No need to compress build.log unless it exceeds maximum attachment size.

In file included from ../config.h:4:0,
                 from tslib.c:34:
tslib.c: At top level:
/usr/include/xorg/xorg-server.h:106:15: error: expected identifier or '(' before
 numeric constant
 #define TSLIB 1
               ^
tslib.c:609:26: note: in expansion of macro 'TSLIB'
 _X_EXPORT InputDriverRec TSLIB = {
                          ^~~~~

Looks like some redefinition is happening that didn't happen before. Presumably that is fallout from removal of some stuff in xorg-server.

https://cgit.freedesktop.org/xorg/xserver/commit/?id=27819950e4158326e0f83a30f2e8968b932625ef
https://cgit.freedesktop.org/xorg/xserver/commit/?id=5c7ed785e3bdb9f0fbf8fbfdc93b5fdd2b2c7dbf

Anyway, I am unsure whether the xf86-input-tslib driver will be useful at all with modern X.
Comment 2 Pär Karlsson 2018-08-22 17:21:18 UTC
Apologies for the late reply.

I removed "tslib" from my INPUT_DEVICES and recompiled/restarted X.

Turns out that, at least on my Dell XPS15 9560, tslib is not needed, which I somewhat foolishly had assumed :-) Everything with the touchscreen works just fine via the ELAN driver in evdev.

There might be other devices that may need tslib, but at least I can do without it.
Comment 3 Matt Turner gentoo-dev 2018-10-09 15:53:50 UTC
Might be best to give tslib last rites.
Comment 4 Thomas 2018-11-02 20:25:44 UTC
xf86-input-tslib-1.2.0_rc1 does compile against xorg-server-1.20.3, but it fails to load (some missing symbol).

As PK already mentioned: xf86-input-tslib does not seem to be necessary any longer.  It has to be explicitly removed for the TS to work, however.

This is tested on an XPS15 9550.
Comment 5 Larry the Git Cow gentoo-dev 2018-11-02 21:29:46 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=652d080eb5d297c4955d9d54199d81211f6678d6

commit 652d080eb5d297c4955d9d54199d81211f6678d6
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2018-11-02 21:27:48 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2018-11-02 21:27:48 +0000

    profiles: Mask x11-drivers/xf86-input-tslib for removal
    
    Bug: https://bugs.gentoo.org/664096
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 profiles/base/use.mask | 4 ++++
 profiles/package.mask  | 5 +++++
 2 files changed, 9 insertions(+)
Comment 6 Larry the Git Cow gentoo-dev 2018-12-02 07:53:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b7a385a05e69f1b7df98e07d5da36d609f4df3b5

commit b7a385a05e69f1b7df98e07d5da36d609f4df3b5
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2018-12-02 07:52:36 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-12-02 07:52:36 +0000

    x11-drivers/xf86-input-tslib: Remove last-rited pkg
    
    Closes: https://bugs.gentoo.org/664096
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 profiles/package.mask                              |  5 ----
 x11-drivers/xf86-input-tslib/Manifest              |  1 -
 x11-drivers/xf86-input-tslib/metadata.xml          | 12 --------
 .../xf86-input-tslib-1.2.0_rc1.ebuild              | 32 ----------------------
 4 files changed, 50 deletions(-)