Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 663668 - mail-client/thunderbird-60.0 tries to apply user patches in the comm directory
Summary: mail-client/thunderbird-60.0 tries to apply user patches in the comm directory
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-15 12:42 UTC by Attila Tóth
Modified: 2018-09-27 22:34 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Attila Tóth 2018-08-15 12:42:37 UTC
# Apply our Thunderbird patchset
        pushd "${S}"/comm &>/dev/null || doe
        eapply "${WORKDIR}"/thunderbird

seems to modify the current directory to comm

eapply_user comes later and before:

        popd &>/dev/null || die

Moving the eapply_user out of its new place solves the issue.

Note that the above mentioned way to apply the patchset is a new element. It was a simple eapply before.

I assume user patches must be applied in ${S}. Doing it from comm makes the whole stuff uneasy and unnecessary complicated, requiring hacks.

Please make sure user patches gets applied from ${S}! Thanks: Dw.
Comment 1 Larry the Git Cow gentoo-dev 2018-09-27 22:34:56 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=01c3c1a42e3e7ff13a8fa239b8854443f2443770

commit 01c3c1a42e3e7ff13a8fa239b8854443f2443770
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2018-09-27 22:34:30 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2018-09-27 22:34:48 +0000

    mail-client/thunderbird: restore $S before calling eapply_user
    
    Closes: https://bugs.gentoo.org/663668
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>
    Package-Manager: Portage-2.3.50, Repoman-2.3.11

 mail-client/thunderbird/thunderbird-60.0-r3.ebuild | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)